Re: [PATCH 1/3] MTD: m25p80: fix write return value.

2015-05-21 Thread Michal Suchanek
Hello, On 21 May 2015 at 01:45, Brian Norris wrote: > On Thu, Apr 30, 2015 at 03:33:47PM +0200, Michal Suchanek wrote: >> The 'retlen' points to a variable representing the number of data bytes >> written/read (see include/linux/mtd/mtd.h) by the current invocation of >> the function. This

Re: [PATCH 1/3] MTD: m25p80: fix write return value.

2015-05-21 Thread Michal Suchanek
Hello, On 21 May 2015 at 01:45, Brian Norris computersforpe...@gmail.com wrote: On Thu, Apr 30, 2015 at 03:33:47PM +0200, Michal Suchanek wrote: The 'retlen' points to a variable representing the number of data bytes written/read (see include/linux/mtd/mtd.h) by the current invocation of the

Re: [PATCH 1/3] MTD: m25p80: fix write return value.

2015-05-20 Thread Brian Norris
On Thu, Apr 30, 2015 at 03:33:47PM +0200, Michal Suchanek wrote: > The 'retlen' points to a variable representing the number of data bytes > written/read (see include/linux/mtd/mtd.h) by the current invocation of > the function. This variable must be set, not incremented. > > v2: clearer commit

Re: [PATCH 1/3] MTD: m25p80: fix write return value.

2015-05-20 Thread Brian Norris
On Thu, Apr 30, 2015 at 03:33:47PM +0200, Michal Suchanek wrote: The 'retlen' points to a variable representing the number of data bytes written/read (see include/linux/mtd/mtd.h) by the current invocation of the function. This variable must be set, not incremented. v2: clearer commit

Re: [PATCH 1/3] MTD: m25p80: fix write return value.

2015-04-30 Thread Marek Vasut
On Thursday, April 30, 2015 at 03:33:47 PM, Michal Suchanek wrote: > The 'retlen' points to a variable representing the number of data bytes > written/read (see include/linux/mtd/mtd.h) by the current invocation of > the function. This variable must be set, not incremented. > > v2: clearer commit

Re: [PATCH 1/3] MTD: m25p80: fix write return value.

2015-04-30 Thread Michal Suchanek
On 30 April 2015 at 20:43, Marek Vasut wrote: > On Thursday, April 30, 2015 at 03:33:47 PM, Michal Suchanek wrote: >> The size of written data was added to user supplied value rather than >> written at the provided address. > > You might want to work on the commit message a little, something like

Re: [PATCH 1/3] MTD: m25p80: fix write return value.

2015-04-30 Thread Marek Vasut
On Thursday, April 30, 2015 at 03:33:47 PM, Michal Suchanek wrote: > The size of written data was added to user supplied value rather than > written at the provided address. You might want to work on the commit message a little, something like the following, but feel free to reword as seen fit.

Re: [PATCH 1/3] MTD: m25p80: fix write return value.

2015-04-30 Thread Marek Vasut
On Thursday, April 30, 2015 at 03:33:47 PM, Michal Suchanek wrote: The size of written data was added to user supplied value rather than written at the provided address. You might want to work on the commit message a little, something like the following, but feel free to reword as seen fit.

Re: [PATCH 1/3] MTD: m25p80: fix write return value.

2015-04-30 Thread Marek Vasut
On Thursday, April 30, 2015 at 03:33:47 PM, Michal Suchanek wrote: The 'retlen' points to a variable representing the number of data bytes written/read (see include/linux/mtd/mtd.h) by the current invocation of the function. This variable must be set, not incremented. v2: clearer commit

Re: [PATCH 1/3] MTD: m25p80: fix write return value.

2015-04-30 Thread Michal Suchanek
On 30 April 2015 at 20:43, Marek Vasut ma...@denx.de wrote: On Thursday, April 30, 2015 at 03:33:47 PM, Michal Suchanek wrote: The size of written data was added to user supplied value rather than written at the provided address. You might want to work on the commit message a little,