Re: [PATCH 1/3] X.509: Fix certificate gathering again

2015-05-28 Thread David Woodhouse
On Thu, 2015-05-28 at 10:58 +0100, David Howells wrote: > David Woodhouse wrote: > > > > The only issue is that the makefile expressions are a bit hairy. For > > > starters, we already have definitions for $(quote) and $(space) in > > > kbuild. I'll have a closer look at the config_filename

Re: [PATCH 1/3] X.509: Fix certificate gathering again

2015-05-28 Thread David Howells
David Woodhouse wrote: > > The only issue is that the makefile expressions are a bit hairy. For > > starters, we already have definitions for $(quote) and $(space) in > > kbuild. I'll have a closer look at the config_filename macro and try to > > simplify it somehow. But it's just cosmetics, the

Re: [PATCH 1/3] X.509: Fix certificate gathering again

2015-05-28 Thread David Woodhouse
On Thu, 2015-05-28 at 13:18 +0800, Michal Marek wrote: > > The only issue is that the makefile expressions are a bit hairy. For > starters, we already have definitions for $(quote) and $(space) in > kbuild. I'll have a closer look at the config_filename macro and try to > simplify it somehow. But

Re: [PATCH 1/3] X.509: Fix certificate gathering again

2015-05-28 Thread David Woodhouse
On Thu, 2015-05-28 at 13:18 +0800, Michal Marek wrote: The only issue is that the makefile expressions are a bit hairy. For starters, we already have definitions for $(quote) and $(space) in kbuild. I'll have a closer look at the config_filename macro and try to simplify it somehow. But it's

Re: [PATCH 1/3] X.509: Fix certificate gathering again

2015-05-28 Thread David Howells
David Woodhouse dw...@infradead.org wrote: The only issue is that the makefile expressions are a bit hairy. For starters, we already have definitions for $(quote) and $(space) in kbuild. I'll have a closer look at the config_filename macro and try to simplify it somehow. But it's just

Re: [PATCH 1/3] X.509: Fix certificate gathering again

2015-05-28 Thread David Woodhouse
On Thu, 2015-05-28 at 10:58 +0100, David Howells wrote: David Woodhouse dw...@infradead.org wrote: The only issue is that the makefile expressions are a bit hairy. For starters, we already have definitions for $(quote) and $(space) in kbuild. I'll have a closer look at the

Re: [PATCH 1/3] X.509: Fix certificate gathering again

2015-05-27 Thread Michal Marek
Dne 27.5.2015 v 00:15 David Howells napsal(a): > Hi Michal, > > Could you have a look at the patch at the end of my branch: > > > http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=modsign-pkcs7 > > It changes things from picking up arbitrary *.x509 files dropped in

Re: [PATCH 1/3] X.509: Fix certificate gathering again

2015-05-27 Thread Michal Marek
Dne 27.5.2015 v 00:15 David Howells napsal(a): Hi Michal, Could you have a look at the patch at the end of my branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=modsign-pkcs7 It changes things from picking up arbitrary *.x509 files dropped in the

Re: [PATCH 1/3] X.509: Fix certificate gathering again

2015-05-26 Thread David Howells
Petko Manolov wrote: > >+Beyond the public key generated specifically for module signing, > > I think this should be "private", not "public" key. The modules are signed > with the private key... No. Private keys aren't added to the keyring. The title of the section is "Public keys in the

Re: [PATCH 1/3] X.509: Fix certificate gathering again

2015-05-26 Thread Petko Manolov
On May 26, 2015 7:15:38 PM GMT+03:00, David Howells wrote: >Hi Michal, > >Could you have a look at the patch at the end of my branch: > > > http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=modsign-pkcs7 > >It changes things from picking up arbitrary *.x509 files

Re: [PATCH 1/3] X.509: Fix certificate gathering again

2015-05-26 Thread David Howells
Hi Michal, Could you have a look at the patch at the end of my branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=modsign-pkcs7 It changes things from picking up arbitrary *.x509 files dropped in the kernel source and/or build directory to taking a single

Re: [PATCH 1/3] X.509: Fix certificate gathering again

2015-05-26 Thread David Howells
Hi Michal, Could you have a look at the patch at the end of my branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=modsign-pkcs7 It changes things from picking up arbitrary *.x509 files dropped in the kernel source and/or build directory to taking a single

Re: [PATCH 1/3] X.509: Fix certificate gathering again

2015-05-26 Thread Petko Manolov
On May 26, 2015 7:15:38 PM GMT+03:00, David Howells dhowe...@redhat.com wrote: Hi Michal, Could you have a look at the patch at the end of my branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=modsign-pkcs7 It changes things from picking up arbitrary

Re: [PATCH 1/3] X.509: Fix certificate gathering again

2015-05-26 Thread David Howells
Petko Manolov pet...@mip-labs.com wrote: +Beyond the public key generated specifically for module signing, I think this should be private, not public key. The modules are signed with the private key... No. Private keys aren't added to the keyring. The title of the section is Public keys

[PATCH 1/3] X.509: Fix certificate gathering again

2015-05-19 Thread Michal Marek
Commit d7ec435f (X.509: Fix certificate gathering) fixed the issue of changing .x509.list, but in the CONFIG_MODULE_SIG=y case, it assumed that $(objtree) was an absolute path. Commit 7e1c0477 (kbuild: Use relative path for $(objtree)) broke this assumption and we get uncecessary rebuilds again,

[PATCH 1/3] X.509: Fix certificate gathering again

2015-05-19 Thread Michal Marek
Commit d7ec435f (X.509: Fix certificate gathering) fixed the issue of changing .x509.list, but in the CONFIG_MODULE_SIG=y case, it assumed that $(objtree) was an absolute path. Commit 7e1c0477 (kbuild: Use relative path for $(objtree)) broke this assumption and we get uncecessary rebuilds again,