Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Fri, Jan 22, 2016 at 2:05 PM, Måns Rullgård wrote: > Andy Shevchenko writes: >> On Fri, 2016-01-22 at 11:13 +, Måns Rullgård wrote: >>> Andy Shevchenko writes: >>> > On Wed, 2016-01-20 at 20:07 +, Måns Rullgård wrote: >>> > > Andy Shevchenko writes: >> + u8 _dms =

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Fri, 2016-01-22 at 11:13 +, Måns Rullgård wrote: >> Andy Shevchenko writes: >> > On Wed, 2016-01-20 at 20:07 +, Måns Rullgård wrote: >> > > Andy Shevchenko writes: > >> > In DWC_DEFAULT_CTLLO() can we do tab indentation for \ ? >> >> Is there a wrong

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Fri, 2016-01-22 at 11:13 +, Måns Rullgård wrote: > Andy Shevchenko writes: > > On Wed, 2016-01-20 at 20:07 +, Måns Rullgård wrote: > > > Andy Shevchenko writes: > > In DWC_DEFAULT_CTLLO() can we do tab indentation for \ ? > > Is there a wrong indentation somewhere?  I don't see it.

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Wed, 2016-01-20 at 20:07 +, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >> > > > > > One comment still regarding to lli types. We can avoid >> > > > > > warnings by >> > > > > > using (__force u32) in macros. >> > > > > >> > > > > But that won't give

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, 2015-12-21 at 16:29 -0400, Julian Margetson wrote: > On 12/21/2015 4:25 PM, Andy Shevchenko wrote: > > On Mon, 2015-12-21 at 15:19 -0400, Julian Margetson wrote: > > > On 12/21/2015 2:27 PM, Måns Rullgård wrote: > > > > The hard drive is recognized . > > > > > These system gets

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Wed, 2016-01-20 at 20:07 +, Måns Rullgård wrote: > Andy Shevchenko writes: > > > > > > > One comment still regarding to lli types. We can avoid > > > > > > warnings by > > > > > > using (__force u32) in macros. > > > > > > > > > > But that won't give the benefits of having the types

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, 2015-12-21 at 16:29 -0400, Julian Margetson wrote: > On 12/21/2015 4:25 PM, Andy Shevchenko wrote: > > On Mon, 2015-12-21 at 15:19 -0400, Julian Margetson wrote: > > > On 12/21/2015 2:27 PM, Måns Rullgård wrote: > > > > The hard drive is recognized . > > > > > These system gets

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Wed, 2016-01-20 at 20:07 +, Måns Rullgård wrote: > Andy Shevchenko writes: > > > > > > > One comment still regarding to lli types. We can avoid > > > > > > warnings by > > > > > > using (__force u32) in macros. > > > > > > > > > > But that won't give the

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Fri, 2016-01-22 at 11:13 +, Måns Rullgård wrote: > Andy Shevchenko writes: > > On Wed, 2016-01-20 at 20:07 +, Måns Rullgård wrote: > > > Andy Shevchenko writes: > > In DWC_DEFAULT_CTLLO() can we do tab indentation for \ ?

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Fri, Jan 22, 2016 at 2:05 PM, Måns Rullgård wrote: > Andy Shevchenko writes: >> On Fri, 2016-01-22 at 11:13 +, Måns Rullgård wrote: >>> Andy Shevchenko writes: >>> > On Wed, 2016-01-20 at 20:07 +,

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Wed, 2016-01-20 at 20:07 +, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >> > > > > > One comment still regarding to lli types. We can avoid >> > > > > > warnings by >> > > > > > using (__force

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Fri, 2016-01-22 at 11:13 +, Måns Rullgård wrote: >> Andy Shevchenko writes: >> > On Wed, 2016-01-20 at 20:07 +, Måns Rullgård wrote: >> > > Andy Shevchenko

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Wed, Jan 20, 2016 at 9:46 PM, Måns Rullgård wrote: > > One comment still regarding to lli types. We can avoid warnings by > using (__force u32) in macros. But that won't give the benefits of having the types checked. >>> >>> You mean if we access

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Wed, Jan 20, 2016 at 9:46 PM, Måns Rullgård wrote: One comment still regarding to lli types. We can avoid warnings by using (__force u32) in macros. >>> >>> But that won't give the benefits of having the types checked. >> >> You mean if we access the lli->field directly? I didn't

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Wed, Jan 20, 2016 at 9:24 PM, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >>> On Wed, 2016-01-20 at 18:50 +, Måns Rullgård wrote: Andy Shevchenko writes: > > Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver). > > > >

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Wed, Jan 20, 2016 at 9:24 PM, Måns Rullgård wrote: > Andy Shevchenko writes: > >> On Wed, 2016-01-20 at 18:50 +, Måns Rullgård wrote: >>> Andy Shevchenko writes: >>> >>> > > Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver). >>> > > >>> > > Code here: >>> > >

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Wed, 2016-01-20 at 18:50 +, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >> > > Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver). >> > > >> > > Code here: >> > > https://bitbucket.org/mansr/linux-dwc/branch/dwc-sata >> > >> > Thanks for

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Wed, 2016-01-20 at 18:50 +, Måns Rullgård wrote: > Andy Shevchenko writes: > > > > Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver). > > > > > > Code here: > > > https://bitbucket.org/mansr/linux-dwc/branch/dwc-sata > > > > Thanks for testing! > > Have you had time to look

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: >> Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver). >> >> Code here: >> https://bitbucket.org/mansr/linux-dwc/branch/dwc-sata > > Thanks for testing! Have you had time to look any more at these patches? -- Måns Rullgård

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: >> Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver). >> >> Code here: >> https://bitbucket.org/mansr/linux-dwc/branch/dwc-sata > > Thanks for testing! Have you had time to look any more at these patches? -- Måns Rullgård

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Wed, Jan 20, 2016 at 9:46 PM, Måns Rullgård wrote: One comment still regarding to lli types. We can avoid warnings by using (__force u32) in macros. >>> >>> But that won't give the benefits of having the types checked. >> >> You mean if we access the lli->field

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Wed, Jan 20, 2016 at 9:24 PM, Måns Rullgård wrote: > Andy Shevchenko writes: > >> On Wed, 2016-01-20 at 18:50 +, Måns Rullgård wrote: >>> Andy Shevchenko writes: >>> >>> > > Tested on AVR32 (DMA driver)

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Wed, Jan 20, 2016 at 9:24 PM, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >>> On Wed, 2016-01-20 at 18:50 +, Måns Rullgård wrote: Andy Shevchenko

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Wed, 2016-01-20 at 18:50 +, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >> > > Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver). >> > > >> > > Code here: >> > >

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Wed, 2016-01-20 at 18:50 +, Måns Rullgård wrote: > Andy Shevchenko writes: > > > > Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver). > > > > > > Code here: > > > https://bitbucket.org/mansr/linux-dwc/branch/dwc-sata > > > > Thanks for

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Wed, Jan 20, 2016 at 9:46 PM, Måns Rullgård wrote: > > One comment still regarding to lli types. We can avoid warnings by > using (__force u32) in macros. But that won't give the benefits of having the

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Wed, 2016-01-06 at 19:36 +0200, Andy Shevchenko wrote: > On Wed, Jan 6, 2016 at 6:26 PM, Måns Rullgård wrote: > > Andy Shevchenko writes: > > > > > On Tue, 2015-12-22 at 00:08 +, Måns Rullgård wrote: > > > > Andy Shevchenko writes: > > > > > > > > > Here's what I have:

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Wed, 2016-01-06 at 19:36 +0200, Andy Shevchenko wrote: > On Wed, Jan 6, 2016 at 6:26 PM, Måns Rullgård wrote: > > Andy Shevchenko writes: > > > > > On Tue, 2015-12-22 at 00:08 +, Måns Rullgård wrote: > > > > Andy Shevchenko

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Wed, Jan 6, 2016 at 6:26 PM, Måns Rullgård wrote: > Andy Shevchenko writes: > >> On Tue, 2015-12-22 at 00:08 +, Måns Rullgård wrote: >>> Andy Shevchenko writes: >>> >>> > On Mon, 2015-12-21 at 19:27 +, Måns Rullgård wrote: >>> > > Andy Shevchenko writes: >>> > > >>> > > > I can

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Tue, 2015-12-22 at 00:08 +, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >> > On Mon, 2015-12-21 at 19:27 +, Måns Rullgård wrote: >> > > Andy Shevchenko writes: >> > > >> > > > I can share my working branch with a set of patches regarding >> > > >

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Tue, 2015-12-22 at 00:08 +, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >> > On Mon, 2015-12-21 at 19:27 +, Måns Rullgård wrote: >> > > Andy Shevchenko

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Wed, Jan 6, 2016 at 6:26 PM, Måns Rullgård wrote: > Andy Shevchenko writes: > >> On Tue, 2015-12-22 at 00:08 +, Måns Rullgård wrote: >>> Andy Shevchenko writes: >>> >>> > On Mon, 2015-12-21 at 19:27

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Tue, 2015-12-22 at 00:08 +, Måns Rullgård wrote: > Andy Shevchenko writes: > > > On Mon, 2015-12-21 at 19:27 +, Måns Rullgård wrote: > > > Andy Shevchenko writes: > > > > > > > I can share my working branch with a set of patches regarding > > > > to > > > > dw_dmac. We may do our

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Tue, 2015-12-22 at 00:08 +, Måns Rullgård wrote: > Andy Shevchenko writes: > > > On Mon, 2015-12-21 at 19:27 +, Måns Rullgård wrote: > > > Andy Shevchenko writes: > > > > > > > I can share my working branch with a

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Mon, 2015-12-21 at 19:27 +, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >> > I can share my working branch with a set of patches regarding to >> > dw_dmac. We may do our work based on that code and after I'll >> > submit >> > everything to upstream. Does

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: >> > 4. CHECK: PROTCTL bit (documentation says that recommended value is >> > 0x01) >> >> Any idea what the value of 0x3 used by the old sata driver means? >> Presumably that's decided by the bus. > > Nope, documentation says that it is direct representation of

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, 2015-12-21 at 19:27 +, Måns Rullgård wrote: > Andy Shevchenko writes: > > > On Mon, 2015-12-21 at 01:19 +, Måns Rullgård wrote: > > > Andy Shevchenko writes: > > >   > > > > P.S. I also noticed that original driver enables interrupt per > > > > each > > > > block > > > > > >

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Mon, 2015-12-21 at 15:19 -0400, Julian Margetson wrote: >> On 12/21/2015 2:27 PM, Måns Rullgård wrote: >> > The hard drive is recognized . >> > > These system gets unresponsive with USB devices like the mouse >> > > and >> > > keyboard not responding  when I start

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On 12/21/2015 4:25 PM, Andy Shevchenko wrote: On Mon, 2015-12-21 at 15:19 -0400, Julian Margetson wrote: On 12/21/2015 2:27 PM, Måns Rullgård wrote: The hard drive is recognized . These system gets unresponsive with USB devices like the mouse and keyboard not responding when I start Gparted.

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, 2015-12-21 at 15:19 -0400, Julian Margetson wrote: > On 12/21/2015 2:27 PM, Måns Rullgård wrote: > > The hard drive is recognized . > > > These system gets unresponsive with USB devices like the mouse > > > and > > > keyboard not responding  when I start Gparted. > > Did you disable the

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Mon, 2015-12-21 at 18:16 +, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >> > On Mon, Dec 21, 2015 at 2:15 PM, Måns Rullgård >> > wrote: >> > > Andy Shevchenko writes: >> > >  >> > I used to have a patch to implement this in dw_dmac driver. >> >

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On 12/21/2015 3:27 PM, Måns Rullgård wrote: Julian Margetson writes: On 12/21/2015 2:27 PM, Måns Rullgård wrote: Julian Margetson writes: On 12/21/2015 1:55 PM, Andy Shevchenko wrote: On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: On 12/21/2015 12:48 PM, Andy Shevchenko

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Julian Margetson writes: > On 12/21/2015 2:27 PM, Måns Rullgård wrote: >> Julian Margetson writes: >> >>> On 12/21/2015 1:55 PM, Andy Shevchenko wrote: On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: > On 12/21/2015 12:48 PM, Andy Shevchenko wrote: >> On Sun, 2015-12-20

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Mon, 2015-12-21 at 01:19 +, Måns Rullgård wrote: >> Andy Shevchenko writes: >>  >> > P.S. I also noticed that original driver enables interrupt per each >> > block >> >> And then ignores all but the transfer complete interrupt. >> >> > and sets protection

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, 2015-12-21 at 18:16 +, Måns Rullgård wrote: > Andy Shevchenko writes: > > > On Mon, Dec 21, 2015 at 2:15 PM, Måns Rullgård > > wrote: > > > Andy Shevchenko writes: > > >  > > I used to have a patch to implement this in dw_dmac driver. > > However, I > > dropped it at some point.

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On 12/21/2015 2:27 PM, Måns Rullgård wrote: Julian Margetson writes: On 12/21/2015 1:55 PM, Andy Shevchenko wrote: On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: On 12/21/2015 12:48 PM, Andy Shevchenko wrote: On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: On Sun, Dec

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On 12/21/2015 2:27 PM, Måns Rullgård wrote: Julian Margetson writes: On 12/21/2015 1:55 PM, Andy Shevchenko wrote: On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: On 12/21/2015 12:48 PM, Andy Shevchenko wrote: On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: On Sun, Dec

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, 2015-12-21 at 01:19 +, Måns Rullgård wrote: > Andy Shevchenko writes: >  > > P.S. I also noticed that original driver enables interrupt per each > > block > > And then ignores all but the transfer complete interrupt. > > > and sets protection control bits. > > With no indication

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Julian Margetson writes: > On 12/21/2015 1:55 PM, Andy Shevchenko wrote: >> On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: >>> On 12/21/2015 12:48 PM, Andy Shevchenko wrote: On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: > On Sun, Dec 20, 2015 at 10:17 PM, Andy

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: >> On 12/21/2015 12:48 PM, Andy Shevchenko wrote: >>> >>> On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko wrote: > > On Sun, Dec

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On 12/21/2015 1:55 PM, Andy Shevchenko wrote: On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: On 12/21/2015 12:48 PM, Andy Shevchenko wrote: On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko wrote: On Sun, Dec 20, 2015 at

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Mon, 2015-12-21 at 15:24 +, Måns Rullgård wrote: >> Julian Margetson writes: >> >> >> Oh, that one again.  My patch still applies.  Here it is as applied >> to >> that revision of the file. >> >> From what I can tell, that bug has always been there.  Probably

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Mon, Dec 21, 2015 at 2:15 PM, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >>> +Viresh >>> >>> On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote: Andy Shevchenko writes: > On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: >> Julian

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: > On 12/21/2015 12:48 PM, Andy Shevchenko wrote: >> >> On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: >>> >>> On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko >>> wrote: On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, Dec 21, 2015 at 2:15 PM, Måns Rullgård wrote: > Andy Shevchenko writes: > >> +Viresh >> >> On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote: >>> Andy Shevchenko writes: >>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: > Julian Margetson writes: >> On

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On 12/21/2015 12:48 PM, Andy Shevchenko wrote: On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko wrote: On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: I noticed thanks to DWC_PARAMS that burst size is hardcoded to 32 items on

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: > On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko > wrote: > > On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård > > wrote: > > I noticed thanks to DWC_PARAMS that burst size is hardcoded to 32 > > items on this board, however registers

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, 2015-12-21 at 15:24 +, Måns Rullgård wrote: > Julian Margetson writes: > > > Oh, that one again.  My patch still applies.  Here it is as applied > to > that revision of the file. > > From what I can tell, that bug has always been there.  Probably > nobody > ever tested the driver

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Julian Margetson writes: > On 12/21/2015 9:24 AM, Måns Rullgård wrote: >> Julian Margetson writes: >> >> P.S. Anyway we have to ask Julian to try the kernel with >> 8b3444852a2b58129 reverted. >> > git revert 8b3444852a2b58129 > error: could not revert 8b34448...

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Julian Margetson writes: P.S. Anyway we have to ask Julian to try the kernel with 8b3444852a2b58129 reverted. >>> git revert 8b3444852a2b58129 >>> error: could not revert 8b34448... sata_dwc_460ex: move to generic DMA >>> driver >>> hint: after resolving the conflicts, mark the

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On 12/21/2015 8:16 AM, Måns Rullgård wrote: Julian Margetson writes: On 12/21/2015 4:40 AM, Andy Shevchenko wrote: +Viresh On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote: Andy Shevchenko writes: On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: Julian Margetson writes: On

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Julian Margetson writes: > On 12/21/2015 4:40 AM, Andy Shevchenko wrote: >> +Viresh >> >> On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote: >>> Andy Shevchenko writes: >>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: > Julian Margetson writes: >> On 12/20/2015 1:11

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > +Viresh > > On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: Julian Margetson writes: > On 12/20/2015 1:11 PM, Måns Rullgård wrote: >> Julian Margetson writes:

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

+Viresh On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote: > Andy Shevchenko writes: > >> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: >>> Julian Margetson writes: On 12/20/2015 1:11 PM, Måns Rullgård wrote: > Julian Margetson writes: >> [ 48.769671] ata3.00:

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Mon, 2015-12-21 at 18:16 +, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >> > On Mon, Dec 21, 2015 at 2:15 PM, Måns Rullgård >> > wrote: >> > > Andy Shevchenko

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Mon, 2015-12-21 at 15:19 -0400, Julian Margetson wrote: >> On 12/21/2015 2:27 PM, Måns Rullgård wrote: >> > The hard drive is recognized . >> > > These system gets unresponsive with USB devices like the mouse >> > > and >> > >

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Mon, Dec 21, 2015 at 2:15 PM, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >>> +Viresh >>> >>> On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote: Andy Shevchenko

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, 2015-12-21 at 15:19 -0400, Julian Margetson wrote: > On 12/21/2015 2:27 PM, Måns Rullgård wrote: > > The hard drive is recognized . > > > These system gets unresponsive with USB devices like the mouse > > > and > > > keyboard not responding  when I start Gparted. > > Did you disable the

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Julian Margetson writes: > On 12/21/2015 2:27 PM, Måns Rullgård wrote: >> Julian Margetson writes: >> >>> On 12/21/2015 1:55 PM, Andy Shevchenko wrote: On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: > On 12/21/2015 12:48

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Julian Margetson writes: > On 12/21/2015 1:55 PM, Andy Shevchenko wrote: >> On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: >>> On 12/21/2015 12:48 PM, Andy Shevchenko wrote: On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: > On

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, 2015-12-21 at 19:27 +, Måns Rullgård wrote: > Andy Shevchenko writes: > > > On Mon, 2015-12-21 at 01:19 +, Måns Rullgård wrote: > > > Andy Shevchenko writes: > > >   > > > > P.S. I also noticed that original driver

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, 2015-12-21 at 18:16 +, Måns Rullgård wrote: > Andy Shevchenko writes: > > > On Mon, Dec 21, 2015 at 2:15 PM, Måns Rullgård > > wrote: > > > Andy Shevchenko writes: > > >  > > I used to have a patch to implement

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On 12/21/2015 3:27 PM, Måns Rullgård wrote: Julian Margetson writes: On 12/21/2015 2:27 PM, Måns Rullgård wrote: Julian Margetson writes: On 12/21/2015 1:55 PM, Andy Shevchenko wrote: On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Mon, 2015-12-21 at 15:24 +, Måns Rullgård wrote: >> Julian Margetson writes: >> >> >> Oh, that one again.  My patch still applies.  Here it is as applied >> to >> that revision of the file. >> >> From what

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On 12/21/2015 1:55 PM, Andy Shevchenko wrote: On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: On 12/21/2015 12:48 PM, Andy Shevchenko wrote: On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On 12/21/2015 2:27 PM, Måns Rullgård wrote: Julian Margetson writes: On 12/21/2015 1:55 PM, Andy Shevchenko wrote: On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: On 12/21/2015 12:48 PM, Andy Shevchenko wrote: On Sun, 2015-12-20 at 22:55 +0200,

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On 12/21/2015 2:27 PM, Måns Rullgård wrote: Julian Margetson writes: On 12/21/2015 1:55 PM, Andy Shevchenko wrote: On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: On 12/21/2015 12:48 PM, Andy Shevchenko wrote: On Sun, 2015-12-20 at 22:55 +0200,

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, 2015-12-21 at 01:19 +, Måns Rullgård wrote: > Andy Shevchenko writes: >  > > P.S. I also noticed that original driver enables interrupt per each > > block > > And then ignores all but the transfer complete interrupt. > > > and sets protection control bits.

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On 12/21/2015 4:25 PM, Andy Shevchenko wrote: On Mon, 2015-12-21 at 15:19 -0400, Julian Margetson wrote: On 12/21/2015 2:27 PM, Måns Rullgård wrote: The hard drive is recognized . These system gets unresponsive with USB devices like the mouse and keyboard not responding when I start Gparted.

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: >> > 4. CHECK: PROTCTL bit (documentation says that recommended value is >> > 0x01) >> >> Any idea what the value of 0x3 used by the old sata driver means? >> Presumably that's decided by the bus. > > Nope, documentation says that it is

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: >> On 12/21/2015 12:48 PM, Andy Shevchenko wrote: >>> >>> On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: On Sun, Dec 20, 2015 at 10:17 PM, Andy

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Mon, 2015-12-21 at 01:19 +, Måns Rullgård wrote: >> Andy Shevchenko writes: >>  >> > P.S. I also noticed that original driver enables interrupt per each >> > block >> >> And then ignores all but the

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Mon, 2015-12-21 at 19:27 +, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >> > I can share my working branch with a set of patches regarding to >> > dw_dmac. We may do our work based on

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote: > On 12/21/2015 12:48 PM, Andy Shevchenko wrote: >> >> On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: >>> >>> On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko >>> wrote: On

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Julian Margetson writes: P.S. Anyway we have to ask Julian to try the kernel with 8b3444852a2b58129 reverted. >>> git revert 8b3444852a2b58129 >>> error: could not revert 8b34448... sata_dwc_460ex: move to generic DMA >>> driver >>> hint: after resolving the

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

+Viresh On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote: > Andy Shevchenko writes: > >> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: >>> Julian Margetson writes: On 12/20/2015 1:11 PM, Måns

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On 12/21/2015 8:16 AM, Måns Rullgård wrote: Julian Margetson writes: On 12/21/2015 4:40 AM, Andy Shevchenko wrote: +Viresh On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote: Andy Shevchenko writes: On Sun, Dec 20, 2015 at

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > +Viresh > > On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: Julian Margetson

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Julian Margetson writes: > On 12/21/2015 4:40 AM, Andy Shevchenko wrote: >> +Viresh >> >> On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote: >>> Andy Shevchenko writes: >>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: > On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko > wrote: > > On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård > > wrote: > > I noticed thanks to DWC_PARAMS that burst size is hardcoded to 32 >

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, 2015-12-21 at 15:24 +, Måns Rullgård wrote: > Julian Margetson writes: > > > Oh, that one again.  My patch still applies.  Here it is as applied > to > that revision of the file. > > From what I can tell, that bug has always been there.  Probably > nobody > ever

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Julian Margetson writes: > On 12/21/2015 9:24 AM, Måns Rullgård wrote: >> Julian Margetson writes: >> >> P.S. Anyway we have to ask Julian to try the kernel with >> 8b3444852a2b58129 reverted. >> > git revert 8b3444852a2b58129 > error:

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Mon, Dec 21, 2015 at 2:15 PM, Måns Rullgård wrote: > Andy Shevchenko writes: > >> +Viresh >> >> On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote: >>> Andy Shevchenko writes: >>> On Sun, Dec 20,

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On 12/21/2015 12:48 PM, Andy Shevchenko wrote: On Sun, 2015-12-20 at 22:55 +0200, Andy Shevchenko wrote: On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko wrote: On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: I noticed thanks to DWC_PARAMS

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko > wrote: >> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: >>> Julian Margetson writes: On 12/20/2015 1:11 PM, Måns Rullgård wrote: > Julian Margetson writes: >> [ 48.769671] ata3.00: failed

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Måns Rullgård writes: > Andy Shevchenko writes: > >> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: >>> Julian Margetson writes: On 12/20/2015 1:11 PM, Måns Rullgård wrote: > Julian Margetson writes: >> [ 48.769671] ata3.00: failed command: READ FPDMA QUEUED >>> >>>

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: >> Julian Margetson writes: >>> On 12/20/2015 1:11 PM, Måns Rullgård wrote: Julian Margetson writes: > >>> [ 48.769671] ata3.00: failed command: READ FPDMA QUEUED >> >> Well, that didn't help. I still

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko writes: > On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: >> Julian Margetson writes: >>> On 12/20/2015 1:11 PM, Måns Rullgård wrote: Julian Margetson writes: > >>> [ 48.769671] ata3.00: failed command: READ FPDMA QUEUED >> >> Well, that didn't help. I still

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko wrote: > On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: >> Julian Margetson writes: >>> On 12/20/2015 1:11 PM, Måns Rullgård wrote: Julian Margetson writes: > >>> [ 48.769671] ata3.00: failed command: READ FPDMA QUEUED >> >> Well,

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote: > Julian Margetson writes: >> On 12/20/2015 1:11 PM, Måns Rullgård wrote: >>> Julian Margetson writes: >> [ 48.769671] ata3.00: failed command: READ FPDMA QUEUED > > Well, that didn't help. I still think it's part of the problem, but >

  1   2   3   >