Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

On 02/09/2017 11:03 PM, Valo, Kalle wrote: Ben Greear writes: On 02/07/2017 01:14 AM, Valo, Kalle wrote: Adrian Chadd writes: Removing this method makes the diff to FreeBSD larger, as "vif" in FreeBSD is a different pointer. (Yes, I have

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

On 02/09/2017 11:03 PM, Valo, Kalle wrote: Ben Greear writes: On 02/07/2017 01:14 AM, Valo, Kalle wrote: Adrian Chadd writes: Removing this method makes the diff to FreeBSD larger, as "vif" in FreeBSD is a different pointer. (Yes, I have ath10k on freebsd working and I'd like to find a

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

On 9 February 2017 at 23:37, Joe Perches wrote: > On Thu, 2017-02-09 at 23:14 -0800, Adrian Chadd wrote: > >> If there >> were accessors for the skb data / len fields (like we do for mbufs) >> then porting the code would've involved about 5,000 less changed >> lines. > > What

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

On 9 February 2017 at 23:37, Joe Perches wrote: > On Thu, 2017-02-09 at 23:14 -0800, Adrian Chadd wrote: > >> If there >> were accessors for the skb data / len fields (like we do for mbufs) >> then porting the code would've involved about 5,000 less changed >> lines. > > What generic mechanisms

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

On Thu, 2017-02-09 at 23:14 -0800, Adrian Chadd wrote: > If there > were accessors for the skb data / len fields (like we do for mbufs) > then porting the code would've involved about 5,000 less changed > lines. What generic mechanisms would you suggest to make porting easier between bsd and

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

On Thu, 2017-02-09 at 23:14 -0800, Adrian Chadd wrote: > If there > were accessors for the skb data / len fields (like we do for mbufs) > then porting the code would've involved about 5,000 less changed > lines. What generic mechanisms would you suggest to make porting easier between bsd and

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

On 9 February 2017 at 23:03, Valo, Kalle wrote: > Ben Greear writes: > >> On 02/07/2017 01:14 AM, Valo, Kalle wrote: >>> Adrian Chadd writes: >>> Removing this method makes the diff to FreeBSD larger, as "vif" in

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

On 9 February 2017 at 23:03, Valo, Kalle wrote: > Ben Greear writes: > >> On 02/07/2017 01:14 AM, Valo, Kalle wrote: >>> Adrian Chadd writes: >>> Removing this method makes the diff to FreeBSD larger, as "vif" in FreeBSD is a different pointer. (Yes, I have ath10k on freebsd

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

Ben Greear writes: > On 02/07/2017 01:14 AM, Valo, Kalle wrote: >> Adrian Chadd writes: >> >>> Removing this method makes the diff to FreeBSD larger, as "vif" in >>> FreeBSD is a different pointer. >>> >>> (Yes, I have ath10k on freebsd working and

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

Ben Greear writes: > On 02/07/2017 01:14 AM, Valo, Kalle wrote: >> Adrian Chadd writes: >> >>> Removing this method makes the diff to FreeBSD larger, as "vif" in >>> FreeBSD is a different pointer. >>> >>> (Yes, I have ath10k on freebsd working and I'd like to find a way to >>> reduce the diff

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

On 02/07/2017 01:14 AM, Valo, Kalle wrote: Adrian Chadd writes: Removing this method makes the diff to FreeBSD larger, as "vif" in FreeBSD is a different pointer. (Yes, I have ath10k on freebsd working and I'd like to find a way to reduce the diff moving forward.) I

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

On 02/07/2017 01:14 AM, Valo, Kalle wrote: Adrian Chadd writes: Removing this method makes the diff to FreeBSD larger, as "vif" in FreeBSD is a different pointer. (Yes, I have ath10k on freebsd working and I'd like to find a way to reduce the diff moving forward.) I don't like this

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

Adrian Chadd writes: > Removing this method makes the diff to FreeBSD larger, as "vif" in > FreeBSD is a different pointer. > > (Yes, I have ath10k on freebsd working and I'd like to find a way to > reduce the diff moving forward.) I don't like this "(void *) vif->drv_priv"

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

Adrian Chadd writes: > Removing this method makes the diff to FreeBSD larger, as "vif" in > FreeBSD is a different pointer. > > (Yes, I have ath10k on freebsd working and I'd like to find a way to > reduce the diff moving forward.) I don't like this "(void *) vif->drv_priv" style that much

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

hiya, Removing this method makes the diff to FreeBSD larger, as "vif" in FreeBSD is a different pointer. (Yes, I have ath10k on freebsd working and I'd like to find a way to reduce the diff moving forward.) -adrian

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

hiya, Removing this method makes the diff to FreeBSD larger, as "vif" in FreeBSD is a different pointer. (Yes, I have ath10k on freebsd working and I'd like to find a way to reduce the diff moving forward.) -adrian

[PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

it adds unnecessary level of indirection, while we just access structure field Signed-off-by: Amadeusz Sławiński --- drivers/net/wireless/ath/ath10k/mac.c | 68 +-- drivers/net/wireless/ath/ath10k/mac.h | 7 +---

[PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

it adds unnecessary level of indirection, while we just access structure field Signed-off-by: Amadeusz Sławiński --- drivers/net/wireless/ath/ath10k/mac.c | 68 +-- drivers/net/wireless/ath/ath10k/mac.h | 7 +--- drivers/net/wireless/ath/ath10k/p2p.c | 2 +-