Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-05 Thread Kim Phillips
On Thu, 5 Mar 2015 09:12:13 +0200 Cristian Stoica wrote: > On 03/04/2015 08:34 PM, Kim Phillips wrote: > > > I don't see how, e.g., for one, dma_map_sg is I/O TLB > > implementation-dependent. > > I'll need some remedial classes on this topic, but for the moment I > don't see how this matters

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-05 Thread Kim Phillips
On Thu, 5 Mar 2015 09:12:13 +0200 Cristian Stoica cristian.sto...@freescale.com wrote: On 03/04/2015 08:34 PM, Kim Phillips wrote: I don't see how, e.g., for one, dma_map_sg is I/O TLB implementation-dependent. I'll need some remedial classes on this topic, but for the moment I don't

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-04 Thread Cristian Stoica
On 03/04/2015 08:34 PM, Kim Phillips wrote: > I don't see how, e.g., for one, dma_map_sg is I/O TLB > implementation-dependent. I'll need some remedial classes on this topic, but for the moment I don't see how this matters for mapping sg chains. Can you share some pointers? Thanks, Cristian S.

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-04 Thread Kim Phillips
On Wed, 4 Mar 2015 11:03:28 +0200 Cristian Stoica wrote: > On 03/04/2015 06:57 AM, yjin wrote: > > An alternative is moving the definitions to a ".c" file, but I don't > > think it will be fundamental different. > > I know I am fixing a potential error which doesn't exist now, it seems > >

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-04 Thread Cristian Stoica
Hi Yanjiang, On 03/04/2015 04:32 AM, yjin wrote: > > On 2015年03月04日 02:59, Kim Phillips wrote: >> On Tue, 3 Mar 2015 14:50:51 +0800 >> wrote: >> >>> This commit is to avoid the below warnings: >>> >>> drivers/crypto/caam/sg_sw_sec4.h:88:12: warning: >>> 'dma_map_sg_chained' defined but not used

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-04 Thread Cristian Stoica
Hi Yanjiang, On 03/04/2015 04:32 AM, yjin wrote: > > On 2015年03月04日 02:59, Kim Phillips wrote: >> On Tue, 3 Mar 2015 14:50:51 +0800 >> wrote: >> >>> This commit is to avoid the below warnings: >>> >>> drivers/crypto/caam/sg_sw_sec4.h:88:12: warning: >>> 'dma_map_sg_chained' defined but not used

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-04 Thread Cristian Stoica
On 03/04/2015 06:57 AM, yjin wrote: > An alternative is moving the definitions to a ".c" file, but I don't > think it will be fundamental different. > I know I am fixing a potential error which doesn't exist now, it seems > useless for the current upstream version, we can abandon my patch. But I >

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-04 Thread Kim Phillips
On Wed, 4 Mar 2015 11:03:28 +0200 Cristian Stoica cristian.sto...@freescale.com wrote: On 03/04/2015 06:57 AM, yjin wrote: An alternative is moving the definitions to a .c file, but I don't think it will be fundamental different. I know I am fixing a potential error which doesn't exist

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-04 Thread Cristian Stoica
On 03/04/2015 08:34 PM, Kim Phillips wrote: I don't see how, e.g., for one, dma_map_sg is I/O TLB implementation-dependent. I'll need some remedial classes on this topic, but for the moment I don't see how this matters for mapping sg chains. Can you share some pointers? Thanks, Cristian S.

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-04 Thread Cristian Stoica
On 03/04/2015 06:57 AM, yjin wrote: An alternative is moving the definitions to a .c file, but I don't think it will be fundamental different. I know I am fixing a potential error which doesn't exist now, it seems useless for the current upstream version, we can abandon my patch. But I still

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-04 Thread Cristian Stoica
Hi Yanjiang, On 03/04/2015 04:32 AM, yjin wrote: On 2015年03月04日 02:59, Kim Phillips wrote: On Tue, 3 Mar 2015 14:50:51 +0800 yanjiang@windriver.com wrote: This commit is to avoid the below warnings: drivers/crypto/caam/sg_sw_sec4.h:88:12: warning: 'dma_map_sg_chained' defined but

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-04 Thread Cristian Stoica
Hi Yanjiang, On 03/04/2015 04:32 AM, yjin wrote: On 2015年03月04日 02:59, Kim Phillips wrote: On Tue, 3 Mar 2015 14:50:51 +0800 yanjiang@windriver.com wrote: This commit is to avoid the below warnings: drivers/crypto/caam/sg_sw_sec4.h:88:12: warning: 'dma_map_sg_chained' defined but not

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-03 Thread yjin
On 2015年03月04日 10:32, yjin wrote: On 2015年03月04日 02:59, Kim Phillips wrote: On Tue, 3 Mar 2015 14:50:51 +0800 wrote: This commit is to avoid the below warnings: drivers/crypto/caam/sg_sw_sec4.h:88:12: warning: 'dma_map_sg_chained' defined but not used [-Wunused-function] static int

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-03 Thread yjin
On 2015年03月04日 02:59, Kim Phillips wrote: On Tue, 3 Mar 2015 14:50:51 +0800 wrote: This commit is to avoid the below warnings: drivers/crypto/caam/sg_sw_sec4.h:88:12: warning: 'dma_map_sg_chained' defined but not used [-Wunused-function] static int dma_map_sg_chained(struct device *dev,

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-03 Thread Kim Phillips
On Tue, 3 Mar 2015 14:50:51 +0800 wrote: > This commit is to avoid the below warnings: > > drivers/crypto/caam/sg_sw_sec4.h:88:12: warning: > 'dma_map_sg_chained' defined but not used [-Wunused-function] > static int dma_map_sg_chained(struct device *dev, struct scatterlist *sg, >

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-03 Thread Kim Phillips
On Tue, 3 Mar 2015 14:50:51 +0800 yanjiang@windriver.com wrote: This commit is to avoid the below warnings: drivers/crypto/caam/sg_sw_sec4.h:88:12: warning: 'dma_map_sg_chained' defined but not used [-Wunused-function] static int dma_map_sg_chained(struct device *dev, struct

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-03 Thread yjin
On 2015年03月04日 10:32, yjin wrote: On 2015年03月04日 02:59, Kim Phillips wrote: On Tue, 3 Mar 2015 14:50:51 +0800 yanjiang@windriver.com wrote: This commit is to avoid the below warnings: drivers/crypto/caam/sg_sw_sec4.h:88:12: warning: 'dma_map_sg_chained' defined but not used

Re: [PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-03 Thread yjin
On 2015年03月04日 02:59, Kim Phillips wrote: On Tue, 3 Mar 2015 14:50:51 +0800 yanjiang@windriver.com wrote: This commit is to avoid the below warnings: drivers/crypto/caam/sg_sw_sec4.h:88:12: warning: 'dma_map_sg_chained' defined but not used [-Wunused-function] static int

[PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-02 Thread yanjiang.jin
From: Yanjiang Jin This commit is to avoid the below warnings: drivers/crypto/caam/sg_sw_sec4.h:88:12: warning: 'dma_map_sg_chained' defined but not used [-Wunused-function] static int dma_map_sg_chained(struct device *dev, struct scatterlist *sg, ^

[PATCH 1/3] crypto: caam: fix some compile warnings

2015-03-02 Thread yanjiang.jin
From: Yanjiang Jin yanjiang@windriver.com This commit is to avoid the below warnings: drivers/crypto/caam/sg_sw_sec4.h:88:12: warning: 'dma_map_sg_chained' defined but not used [-Wunused-function] static int dma_map_sg_chained(struct device *dev, struct scatterlist *sg, ^