Re: [PATCH 1/3] dt-bindings: Add optional nvmem MAC address bindings to ti,wlink-st

2017-12-04 Thread Sergei Shtylyov 

On 12/4/2017 12:54 PM, Sergei Shtylyov wrote:


This adds optional nvmem consumer properties to the ti,wlink-st device tree
bindings to allow specifying the Bluetooth MAC address.

Signed-off-by: David Lechner 
---
  Documentation/devicetree/bindings/net/ti,wilink-st.txt | 4 
  1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/ti,wilink-st.txt 
b/Documentation/devicetree/bindings/net/ti,wilink-st.txt

index 1649c1f..24eb897 100644
--- a/Documentation/devicetree/bindings/net/ti,wilink-st.txt
+++ b/Documentation/devicetree/bindings/net/ti,wilink-st.txt
@@ -32,6 +32,8 @@ Optional properties:
 See ../clocks/clock-bindings.txt for details.
   - clock-names : Must include the following entry:
 "ext_clock" (External clock provided to the TI combo chip).
+ - nvmem-cells: phandle to nvmem data cell that contains a MAC address
+ - nvmem-cell-names: "mac-address" (required when nvmem-cells is specified)
  Example:
@@ -43,5 +45,7 @@ Example:
  enable-gpios = < 7 GPIO_ACTIVE_HIGH>;
  clocks = <_wl18xx>;
  clock-names = "ext_clock";
+    nvmem-cells: <_address>


    s/:/ = /?


+    nvmem-cell-names "mac-address"


    Where's =?


   And ;? :-)

[...]

MBR, Sergei

Re: [PATCH 1/3] dt-bindings: Add optional nvmem MAC address bindings to ti,wlink-st

2017-12-04 Thread Sergei Shtylyov 

On 12/4/2017 12:54 PM, Sergei Shtylyov wrote:


This adds optional nvmem consumer properties to the ti,wlink-st device tree
bindings to allow specifying the Bluetooth MAC address.

Signed-off-by: David Lechner 
---
  Documentation/devicetree/bindings/net/ti,wilink-st.txt | 4 
  1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/ti,wilink-st.txt 
b/Documentation/devicetree/bindings/net/ti,wilink-st.txt

index 1649c1f..24eb897 100644
--- a/Documentation/devicetree/bindings/net/ti,wilink-st.txt
+++ b/Documentation/devicetree/bindings/net/ti,wilink-st.txt
@@ -32,6 +32,8 @@ Optional properties:
 See ../clocks/clock-bindings.txt for details.
   - clock-names : Must include the following entry:
 "ext_clock" (External clock provided to the TI combo chip).
+ - nvmem-cells: phandle to nvmem data cell that contains a MAC address
+ - nvmem-cell-names: "mac-address" (required when nvmem-cells is specified)
  Example:
@@ -43,5 +45,7 @@ Example:
  enable-gpios = < 7 GPIO_ACTIVE_HIGH>;
  clocks = <_wl18xx>;
  clock-names = "ext_clock";
+    nvmem-cells: <_address>


    s/:/ = /?


+    nvmem-cell-names "mac-address"


    Where's =?


   And ;? :-)

[...]

MBR, Sergei

Re: [PATCH 1/3] dt-bindings: Add optional nvmem MAC address bindings to ti,wlink-st

2017-12-04 Thread Sergei Shtylyov 

Hello!

On 12/4/2017 6:21 AM, David Lechner wrote:


This adds optional nvmem consumer properties to the ti,wlink-st device tree
bindings to allow specifying the Bluetooth MAC address.

Signed-off-by: David Lechner 
---
  Documentation/devicetree/bindings/net/ti,wilink-st.txt | 4 
  1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/ti,wilink-st.txt 
b/Documentation/devicetree/bindings/net/ti,wilink-st.txt
index 1649c1f..24eb897 100644
--- a/Documentation/devicetree/bindings/net/ti,wilink-st.txt
+++ b/Documentation/devicetree/bindings/net/ti,wilink-st.txt
@@ -32,6 +32,8 @@ Optional properties:
 See ../clocks/clock-bindings.txt for details.
   - clock-names : Must include the following entry:
 "ext_clock" (External clock provided to the TI combo chip).
+ - nvmem-cells: phandle to nvmem data cell that contains a MAC address
+ - nvmem-cell-names: "mac-address" (required when nvmem-cells is specified)
  
  Example:
  
@@ -43,5 +45,7 @@ Example:

enable-gpios = < 7 GPIO_ACTIVE_HIGH>;
clocks = <_wl18xx>;
clock-names = "ext_clock";
+   nvmem-cells: <_address>


   s/:/ = /?


+   nvmem-cell-names "mac-address"


   Where's =?

[...]

MBR, Sergei

Re: [PATCH 1/3] dt-bindings: Add optional nvmem MAC address bindings to ti,wlink-st

2017-12-04 Thread Sergei Shtylyov 

Hello!

On 12/4/2017 6:21 AM, David Lechner wrote:


This adds optional nvmem consumer properties to the ti,wlink-st device tree
bindings to allow specifying the Bluetooth MAC address.

Signed-off-by: David Lechner 
---
  Documentation/devicetree/bindings/net/ti,wilink-st.txt | 4 
  1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/ti,wilink-st.txt 
b/Documentation/devicetree/bindings/net/ti,wilink-st.txt
index 1649c1f..24eb897 100644
--- a/Documentation/devicetree/bindings/net/ti,wilink-st.txt
+++ b/Documentation/devicetree/bindings/net/ti,wilink-st.txt
@@ -32,6 +32,8 @@ Optional properties:
 See ../clocks/clock-bindings.txt for details.
   - clock-names : Must include the following entry:
 "ext_clock" (External clock provided to the TI combo chip).
+ - nvmem-cells: phandle to nvmem data cell that contains a MAC address
+ - nvmem-cell-names: "mac-address" (required when nvmem-cells is specified)
  
  Example:
  
@@ -43,5 +45,7 @@ Example:

enable-gpios = < 7 GPIO_ACTIVE_HIGH>;
clocks = <_wl18xx>;
clock-names = "ext_clock";
+   nvmem-cells: <_address>


   s/:/ = /?


+   nvmem-cell-names "mac-address"


   Where's =?

[...]

MBR, Sergei

Re: [PATCH 1/3] dt-bindings: Add optional nvmem MAC address bindings to ti,wlink-st

2017-12-03 Thread Marcel Holtmann 
Hi David,

> This adds optional nvmem consumer properties to the ti,wlink-st device tree
> bindings to allow specifying the Bluetooth MAC address.
> 
> Signed-off-by: David Lechner 
> ---
> Documentation/devicetree/bindings/net/ti,wilink-st.txt | 4 
> 1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,wilink-st.txt 
> b/Documentation/devicetree/bindings/net/ti,wilink-st.txt
> index 1649c1f..24eb897 100644
> --- a/Documentation/devicetree/bindings/net/ti,wilink-st.txt
> +++ b/Documentation/devicetree/bindings/net/ti,wilink-st.txt
> @@ -32,6 +32,8 @@ Optional properties:
>See ../clocks/clock-bindings.txt for details.
>  - clock-names : Must include the following entry:
>"ext_clock" (External clock provided to the TI combo chip).
> + - nvmem-cells: phandle to nvmem data cell that contains a MAC address
> + - nvmem-cell-names: "mac-address" (required when nvmem-cells is specified)

lets call these “bt-address” since they are not really MAC addresses. They have 
special formatting etc. Also I prefer that the actual format on how they are 
stored is described. See Documentation/devicetree/bindings/net/bluetooth.txt 
for an example.

> Example:
> 
> @@ -43,5 +45,7 @@ Example:
>   enable-gpios = < 7 GPIO_ACTIVE_HIGH>;
>   clocks = <_wl18xx>;
>   clock-names = "ext_clock";
> + nvmem-cells: <_address>
> + nvmem-cell-names "mac-address"
>   };
> };

Regards

Marcel

Re: [PATCH 1/3] dt-bindings: Add optional nvmem MAC address bindings to ti,wlink-st

2017-12-03 Thread Marcel Holtmann 
Hi David,

> This adds optional nvmem consumer properties to the ti,wlink-st device tree
> bindings to allow specifying the Bluetooth MAC address.
> 
> Signed-off-by: David Lechner 
> ---
> Documentation/devicetree/bindings/net/ti,wilink-st.txt | 4 
> 1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,wilink-st.txt 
> b/Documentation/devicetree/bindings/net/ti,wilink-st.txt
> index 1649c1f..24eb897 100644
> --- a/Documentation/devicetree/bindings/net/ti,wilink-st.txt
> +++ b/Documentation/devicetree/bindings/net/ti,wilink-st.txt
> @@ -32,6 +32,8 @@ Optional properties:
>See ../clocks/clock-bindings.txt for details.
>  - clock-names : Must include the following entry:
>"ext_clock" (External clock provided to the TI combo chip).
> + - nvmem-cells: phandle to nvmem data cell that contains a MAC address
> + - nvmem-cell-names: "mac-address" (required when nvmem-cells is specified)

lets call these “bt-address” since they are not really MAC addresses. They have 
special formatting etc. Also I prefer that the actual format on how they are 
stored is described. See Documentation/devicetree/bindings/net/bluetooth.txt 
for an example.

> Example:
> 
> @@ -43,5 +45,7 @@ Example:
>   enable-gpios = < 7 GPIO_ACTIVE_HIGH>;
>   clocks = <_wl18xx>;
>   clock-names = "ext_clock";
> + nvmem-cells: <_address>
> + nvmem-cell-names "mac-address"
>   };
> };

Regards

Marcel

[PATCH 1/3] dt-bindings: Add optional nvmem MAC address bindings to ti,wlink-st

2017-12-03 Thread David Lechner 
This adds optional nvmem consumer properties to the ti,wlink-st device tree
bindings to allow specifying the Bluetooth MAC address.

Signed-off-by: David Lechner 
---
 Documentation/devicetree/bindings/net/ti,wilink-st.txt | 4 
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/ti,wilink-st.txt 
b/Documentation/devicetree/bindings/net/ti,wilink-st.txt
index 1649c1f..24eb897 100644
--- a/Documentation/devicetree/bindings/net/ti,wilink-st.txt
+++ b/Documentation/devicetree/bindings/net/ti,wilink-st.txt
@@ -32,6 +32,8 @@ Optional properties:
See ../clocks/clock-bindings.txt for details.
  - clock-names : Must include the following entry:
"ext_clock" (External clock provided to the TI combo chip).
+ - nvmem-cells: phandle to nvmem data cell that contains a MAC address
+ - nvmem-cell-names: "mac-address" (required when nvmem-cells is specified)
 
 Example:
 
@@ -43,5 +45,7 @@ Example:
enable-gpios = < 7 GPIO_ACTIVE_HIGH>;
clocks = <_wl18xx>;
clock-names = "ext_clock";
+   nvmem-cells: <_address>
+   nvmem-cell-names "mac-address"
};
 };
-- 
2.7.4

[PATCH 1/3] dt-bindings: Add optional nvmem MAC address bindings to ti,wlink-st

2017-12-03 Thread David Lechner 
This adds optional nvmem consumer properties to the ti,wlink-st device tree
bindings to allow specifying the Bluetooth MAC address.

Signed-off-by: David Lechner 
---
 Documentation/devicetree/bindings/net/ti,wilink-st.txt | 4 
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/ti,wilink-st.txt 
b/Documentation/devicetree/bindings/net/ti,wilink-st.txt
index 1649c1f..24eb897 100644
--- a/Documentation/devicetree/bindings/net/ti,wilink-st.txt
+++ b/Documentation/devicetree/bindings/net/ti,wilink-st.txt
@@ -32,6 +32,8 @@ Optional properties:
See ../clocks/clock-bindings.txt for details.
  - clock-names : Must include the following entry:
"ext_clock" (External clock provided to the TI combo chip).
+ - nvmem-cells: phandle to nvmem data cell that contains a MAC address
+ - nvmem-cell-names: "mac-address" (required when nvmem-cells is specified)
 
 Example:
 
@@ -43,5 +45,7 @@ Example:
enable-gpios = < 7 GPIO_ACTIVE_HIGH>;
clocks = <_wl18xx>;
clock-names = "ext_clock";
+   nvmem-cells: <_address>
+   nvmem-cell-names "mac-address"
};
 };
-- 
2.7.4