On Fri, Jul 17, 2020 at 5:01 AM Linus Walleij wrote:
>
> Greg, John,
>
> we need some guidance here. See below.
>
> On Thu, Jul 16, 2020 at 4:38 PM Anson Huang wrote:
> > [Me]
> > > On Wed, Jul 15, 2020 at 4:44 AM Anson Huang
>
> > > > I tried to replace the subsys_initcall() with
> > > >
On Fri, Jul 17, 2020 at 04:13:44PM +0200, Greg KH wrote:
> On Fri, Jul 17, 2020 at 03:54:49PM +0200, Arnd Bergmann wrote:
> > > And look at the driver core work for many driver subsystems to be fixed
> > > up just to get a single kernel image to work on multiple platforms.
> > > Just because
On Fri, Jul 17, 2020 at 03:54:49PM +0200, Arnd Bergmann wrote:
> > And look at the driver core work for many driver subsystems to be fixed
> > up just to get a single kernel image to work on multiple platforms.
> > Just because older ones did it, doesn't mean it actually works today :)
>
> Can
On Fri, Jul 17, 2020 at 3:21 PM Greg KH wrote:
> On Fri, Jul 17, 2020 at 02:27:43PM +0200, Geert Uytterhoeven wrote:
> > Hi Greg,
> >
> > On Fri, Jul 17, 2020 at 2:14 PM Greg KH wrote:
> > > Android is just finally pushing vendors to get their code upstream,
> > > which is a good thing to see.
On Fri, Jul 17, 2020 at 2:14 PM Greg KH wrote:
> So moving drivers to modules is good. If a module can be removed, even
> better, but developers should not be lazy and just flat out not try at
> all to make their code unloadable if at all possible.
>
> Does that help?
Yeah it confirms my
On Fri, Jul 17, 2020 at 03:02:54PM +0200, Arnd Bergmann wrote:
> On Fri, Jul 17, 2020 at 2:16 PM Greg KH wrote:
> > On Fri, Jul 17, 2020 at 02:01:16PM +0200, Linus Walleij wrote:
> > > While I am a big fan of the Android GKI initiative this needs to be
> > > aligned
> > > with the Linux core
On Fri, Jul 17, 2020 at 02:27:43PM +0200, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Fri, Jul 17, 2020 at 2:14 PM Greg KH wrote:
> > Android is just finally pushing vendors to get their code upstream,
> > which is a good thing to see. And building things as a module is an
> > even better thing
On Fri, Jul 17, 2020 at 2:16 PM Greg KH wrote:
> On Fri, Jul 17, 2020 at 02:01:16PM +0200, Linus Walleij wrote:
> > While I am a big fan of the Android GKI initiative this needs to be aligned
> > with the Linux core maintainers, so let's ask Greg. I am also paging
> > John Stultz on this: he is
Hi Greg,
On Fri, Jul 17, 2020 at 2:14 PM Greg KH wrote:
> Android is just finally pushing vendors to get their code upstream,
> which is a good thing to see. And building things as a module is an
> even better thing as now it is finally allowing arm64 systems to be
> built to support more than
On Fri, Jul 17, 2020 at 02:01:16PM +0200, Linus Walleij wrote:
> Greg, John,
>
> we need some guidance here. See below.
>
> On Thu, Jul 16, 2020 at 4:38 PM Anson Huang wrote:
> > [Me]
> > > On Wed, Jul 15, 2020 at 4:44 AM Anson Huang
>
> > > > I tried to replace the subsys_initcall() with
> >
Greg, John,
we need some guidance here. See below.
On Thu, Jul 16, 2020 at 4:38 PM Anson Huang wrote:
> [Me]
> > On Wed, Jul 15, 2020 at 4:44 AM Anson Huang
> > > I tried to replace the subsys_initcall() with
> > > module_platform_driver(), but met issue about "
> > >
Hi, Linus
> Subject: Re: [PATCH 1/3] gpio: mxc: Support module build
>
> On Wed, Jul 15, 2020 at 4:44 AM Anson Huang
> wrote:
>
> > > Subject: RE: [PATCH 1/3] gpio: mxc: Support module build
> > >
> > > Hi, Linus
> > >
> > >
On Wed, Jul 15, 2020 at 4:44 AM Anson Huang wrote:
> > Subject: RE: [PATCH 1/3] gpio: mxc: Support module build
> >
> > Hi, Linus
> >
> > > Subject: Re: [PATCH 1/3] gpio: mxc: Support module build
> > >
> > > On Wed, Jul 8, 2020 at 1:28 AM Anson
Hi, Linus
> Subject: RE: [PATCH 1/3] gpio: mxc: Support module build
>
> Hi, Linus
>
> > Subject: Re: [PATCH 1/3] gpio: mxc: Support module build
> >
> > On Wed, Jul 8, 2020 at 1:28 AM Anson Huang
> > wrote:
> >
> > > subsys_initcall(gpio
Hi, Linus
> Subject: Re: [PATCH 1/3] gpio: mxc: Support module build
>
> On Wed, Jul 8, 2020 at 1:28 AM Anson Huang
> wrote:
>
> > subsys_initcall(gpio_mxc_init);
> > +
> > +MODULE_AUTHOR("Shawn Guo ");
> > +MODULE_DESCRIPTION("i.MX GPI
On Wed, Jul 8, 2020 at 1:28 AM Anson Huang wrote:
> subsys_initcall(gpio_mxc_init);
> +
> +MODULE_AUTHOR("Shawn Guo ");
> +MODULE_DESCRIPTION("i.MX GPIO Driver");
> +MODULE_LICENSE("GPL");
You are making this modualrizable but keeping the subsys_initcall(),
which doesn't make very much sense.
Change config to tristate, add module device table, module author,
description and license to support module build for i.MX GPIO driver.
Signed-off-by: Anson Huang
---
drivers/gpio/Kconfig| 2 +-
drivers/gpio/gpio-mxc.c | 6 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git
17 matches
Mail list logo
