Re: [PATCH 1/3] iio: adc: aspeed: Orgnaize and add the define of adc

On Sun, Oct 18, 2020 at 1:32 PM Jonathan Cameron wrote: > On Tue, 13 Oct 2020 18:32:43 +0800 > Billy Tsai wrote: ... > > +/* [31:16] */ Useless comment. > > +#define ASPEED_ADC_CTRL_CH_EN(n) (1 << (16 + n)) > > +#define ASPEED_ADC_CTRL_CH_EN_ALLGENMASK(31, 16) But the main point is

Re: [PATCH 1/3] iio: adc: aspeed: Orgnaize and add the define of adc

On Tue, 13 Oct 2020 18:32:43 +0800 Billy Tsai wrote: > This patch organizes the define of adc to multiple partitions > and adds the new bit field define for ast2600 driver. Should be 2 patch patches. If you need to do a reorg, do it first, then add new bits in a second patch. That way we are

[PATCH 1/3] iio: adc: aspeed: Orgnaize and add the define of adc

This patch organizes the define of adc to multiple partitions and adds the new bit field define for ast2600 driver. Signed-off-by: Billy Tsai --- drivers/iio/adc/aspeed_adc.c | 42 1 file changed, 38 insertions(+), 4 deletions(-) diff --git