Re: [PATCH 1/3] kernel/workqueue: Remove lockdep annotation from __flush_work()

2018-10-25 Thread Bart Van Assche
On Thu, 2018-10-25 at 17:31 +0200, Johannes Berg wrote: > > Remove > > the lockdep annotation from __flush_work() because start_flush_work() > > already has such an annotation. > > This part at least isn't true, there's no annotation on the work > *struct*, only one on the work *queue*. You are r

Re: [PATCH 1/3] kernel/workqueue: Remove lockdep annotation from __flush_work()

2018-10-25 Thread Johannes Berg
On Thu, 2018-10-25 at 17:31 +0200, Johannes Berg wrote: > On Thu, 2018-10-25 at 15:05 +, Bart Van Assche wrote: > > As documented in a comment in start_flush_work(), calling flush_work() > > from a multi-threaded workqueue is safe if that workqueue is not > > equipped with a rescuer. Avoid that

Re: [PATCH 1/3] kernel/workqueue: Remove lockdep annotation from __flush_work()

2018-10-25 Thread Johannes Berg
On Thu, 2018-10-25 at 15:05 +, Bart Van Assche wrote: > As documented in a comment in start_flush_work(), calling flush_work() > from a multi-threaded workqueue is safe if that workqueue is not > equipped with a rescuer. Avoid that flush_work() calls from inside a > work item executing on such

[PATCH 1/3] kernel/workqueue: Remove lockdep annotation from __flush_work()

2018-10-25 Thread Bart Van Assche
As documented in a comment in start_flush_work(), calling flush_work() from a multi-threaded workqueue is safe if that workqueue is not equipped with a rescuer. Avoid that flush_work() calls from inside a work item executing on such a queue trigger a lockdep complaint. Remove the lockdep annotation