Re: [PATCH 1/3] mm/memcg: Fix min/low usage in propagate_protected_usage()

2018-12-05 Thread Roman Gushchin
On Wed, Dec 05, 2018 at 04:58:31PM +0800, Xunlei Pang wrote: > Hi Roman, > > On 2018/12/4 AM 2:00, Roman Gushchin wrote: > > On Mon, Dec 03, 2018 at 04:01:17PM +0800, Xunlei Pang wrote: > >> When usage exceeds min, min usage should be min other than 0. > >> Apply the same for low. > >> > >>

Re: [PATCH 1/3] mm/memcg: Fix min/low usage in propagate_protected_usage()

2018-12-05 Thread Xunlei Pang
Hi Roman, On 2018/12/4 AM 2:00, Roman Gushchin wrote: > On Mon, Dec 03, 2018 at 04:01:17PM +0800, Xunlei Pang wrote: >> When usage exceeds min, min usage should be min other than 0. >> Apply the same for low. >> >> Signed-off-by: Xunlei Pang >> --- >> mm/page_counter.c | 12 ++-- >> 1

Re: [PATCH 1/3] mm/memcg: Fix min/low usage in propagate_protected_usage()

2018-12-03 Thread Roman Gushchin
On Mon, Dec 03, 2018 at 04:01:17PM +0800, Xunlei Pang wrote: > When usage exceeds min, min usage should be min other than 0. > Apply the same for low. > > Signed-off-by: Xunlei Pang > --- > mm/page_counter.c | 12 ++-- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git

Re: [PATCH 1/3] mm/memcg: Fix min/low usage in propagate_protected_usage()

2018-12-03 Thread Xunlei Pang
On 2018/12/3 下午7:54, Michal Hocko wrote: > On Mon 03-12-18 16:01:17, Xunlei Pang wrote: >> When usage exceeds min, min usage should be min other than 0. >> Apply the same for low. > > Why? What is the actual problem. children_min_usage tracks the total children usages under min, it's natural

Re: [PATCH 1/3] mm/memcg: Fix min/low usage in propagate_protected_usage()

2018-12-03 Thread Michal Hocko
On Mon 03-12-18 16:01:17, Xunlei Pang wrote: > When usage exceeds min, min usage should be min other than 0. > Apply the same for low. Why? What is the actual problem. > Signed-off-by: Xunlei Pang > --- > mm/page_counter.c | 12 ++-- > 1 file changed, 2 insertions(+), 10 deletions(-) >

[PATCH 1/3] mm/memcg: Fix min/low usage in propagate_protected_usage()

2018-12-03 Thread Xunlei Pang
When usage exceeds min, min usage should be min other than 0. Apply the same for low. Signed-off-by: Xunlei Pang --- mm/page_counter.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/mm/page_counter.c b/mm/page_counter.c index de31470655f6..75d53f15f040 100644