Re: [PATCH 1/3] nvme: Add Arbitration Burst support

2020-06-23 Thread Baolin Wang
On Tue, Jun 23, 2020 at 07:57:15PM -0700, Keith Busch wrote: > On Tue, Jun 23, 2020 at 09:24:32PM +0800, Baolin Wang wrote: > > +void nvme_set_arbitration_burst(struct nvme_ctrl *ctrl) > > +{ > > + u32 result; > > + int status; > > + > > + if (!ctrl->rab) > > + return; > > + > > +

Re: [PATCH 1/3] nvme: Add Arbitration Burst support

2020-06-23 Thread Keith Busch
On Tue, Jun 23, 2020 at 09:24:32PM +0800, Baolin Wang wrote: > +void nvme_set_arbitration_burst(struct nvme_ctrl *ctrl) > +{ > + u32 result; > + int status; > + > + if (!ctrl->rab) > + return; > + > + /* > + * The Arbitration Burst setting indicates the maximum

Re: [PATCH 1/3] nvme: Add Arbitration Burst support

2020-06-23 Thread Baolin Wang
On Tue, Jun 23, 2020 at 07:51:35PM -0700, Keith Busch wrote: > On Wed, Jun 24, 2020 at 09:34:08AM +0800, Baolin Wang wrote: > > OK, I understaood your concern. Now we will select the RR arbitration as > > default > > in nvme_enable_ctrl(), but for some cases, we will not set the arbitration > >

Re: [PATCH 1/3] nvme: Add Arbitration Burst support

2020-06-23 Thread Keith Busch
On Wed, Jun 24, 2020 at 09:34:08AM +0800, Baolin Wang wrote: > OK, I understaood your concern. Now we will select the RR arbitration as > default > in nvme_enable_ctrl(), but for some cases, we will not set the arbitration > burst > values from userspace, and we still want to use the defaut

Re: [PATCH 1/3] nvme: Add Arbitration Burst support

2020-06-23 Thread Baolin Wang
On Tue, Jun 23, 2020 at 11:01:08AM -0700, Keith Busch wrote: > On Tue, Jun 23, 2020 at 10:39:01AM -0700, Sagi Grimberg wrote: > > > > > > From the NVMe spec, "In order to make efficient use of the non-volatile > > > > memory, it is often advantageous to execute multiple commands from a > > > >

Re: [PATCH 1/3] nvme: Add Arbitration Burst support

2020-06-23 Thread Keith Busch
On Tue, Jun 23, 2020 at 10:39:01AM -0700, Sagi Grimberg wrote: > > > > From the NVMe spec, "In order to make efficient use of the non-volatile > > > memory, it is often advantageous to execute multiple commands from a > > > Submission Queue in parallel. For Submission Queues that are using > > >

Re: [PATCH 1/3] nvme: Add Arbitration Burst support

2020-06-23 Thread Sagi Grimberg
From the NVMe spec, "In order to make efficient use of the non-volatile memory, it is often advantageous to execute multiple commands from a Submission Queue in parallel. For Submission Queues that are using weighted round robin with urgent priority class or round robin arbitration, host

Re: [PATCH 1/3] nvme: Add Arbitration Burst support

2020-06-23 Thread Keith Busch
On Tue, Jun 23, 2020 at 09:24:32PM +0800, Baolin Wang wrote: > From the NVMe spec, "In order to make efficient use of the non-volatile > memory, it is often advantageous to execute multiple commands from a > Submission Queue in parallel. For Submission Queues that are using > weighted round robin

[PATCH 1/3] nvme: Add Arbitration Burst support

2020-06-23 Thread Baolin Wang
>From the NVMe spec, "In order to make efficient use of the non-volatile memory, it is often advantageous to execute multiple commands from a Submission Queue in parallel. For Submission Queues that are using weighted round robin with urgent priority class or round robin arbitration, host software