Re: [PATCH 1/3] paravirt,xen: remove xen_patch()

2017-08-10 Thread Juergen Gross
On 10/08/17 18:29, Peter Zijlstra wrote: > On Thu, Aug 10, 2017 at 06:24:53PM +0200, Peter Zijlstra wrote: >> -ENTRY(xen_irq_enable_direct) >> -FRAME_BEGIN >> -/* Unmask events */ >> -movb $0, PER_CPU_VAR(xen_vcpu_info) + XEN_vcpu_info_mask >> - >> -/* >> - * Preempt here

Re: [PATCH 1/3] paravirt,xen: remove xen_patch()

2017-08-10 Thread Juergen Gross
On 10/08/17 18:29, Peter Zijlstra wrote: > On Thu, Aug 10, 2017 at 06:24:53PM +0200, Peter Zijlstra wrote: >> -ENTRY(xen_irq_enable_direct) >> -FRAME_BEGIN >> -/* Unmask events */ >> -movb $0, PER_CPU_VAR(xen_vcpu_info) + XEN_vcpu_info_mask >> - >> -/* >> - * Preempt here

Re: [PATCH 1/3] paravirt,xen: remove xen_patch()

2017-08-10 Thread Peter Zijlstra
On Thu, Aug 10, 2017 at 06:24:53PM +0200, Peter Zijlstra wrote: > -ENTRY(xen_irq_enable_direct) > - FRAME_BEGIN > - /* Unmask events */ > - movb $0, PER_CPU_VAR(xen_vcpu_info) + XEN_vcpu_info_mask > - > - /* > - * Preempt here doesn't matter because that will deal with any > -

Re: [PATCH 1/3] paravirt,xen: remove xen_patch()

2017-08-10 Thread Peter Zijlstra
On Thu, Aug 10, 2017 at 06:24:53PM +0200, Peter Zijlstra wrote: > -ENTRY(xen_irq_enable_direct) > - FRAME_BEGIN > - /* Unmask events */ > - movb $0, PER_CPU_VAR(xen_vcpu_info) + XEN_vcpu_info_mask > - > - /* > - * Preempt here doesn't matter because that will deal with any > -

Re: [PATCH 1/3] paravirt,xen: remove xen_patch()

2017-08-10 Thread Josh Poimboeuf
On Thu, Aug 10, 2017 at 02:52:52PM +0200, Juergen Gross wrote: > Xen's paravirt patch function xen_patch() does some special casing for > irq_ops functions to apply relocations when those functions can be > patched inline instead of calls. > > Unfortunately none of the special case function

Re: [PATCH 1/3] paravirt,xen: remove xen_patch()

2017-08-10 Thread Josh Poimboeuf
On Thu, Aug 10, 2017 at 02:52:52PM +0200, Juergen Gross wrote: > Xen's paravirt patch function xen_patch() does some special casing for > irq_ops functions to apply relocations when those functions can be > patched inline instead of calls. > > Unfortunately none of the special case function

Re: [PATCH 1/3] paravirt,xen: remove xen_patch()

2017-08-10 Thread Peter Zijlstra
On Thu, Aug 10, 2017 at 02:52:52PM +0200, Juergen Gross wrote: > Xen's paravirt patch function xen_patch() does some special casing for > irq_ops functions to apply relocations when those functions can be > patched inline instead of calls. > > Unfortunately none of the special case function

Re: [PATCH 1/3] paravirt,xen: remove xen_patch()

2017-08-10 Thread Peter Zijlstra
On Thu, Aug 10, 2017 at 02:52:52PM +0200, Juergen Gross wrote: > Xen's paravirt patch function xen_patch() does some special casing for > irq_ops functions to apply relocations when those functions can be > patched inline instead of calls. > > Unfortunately none of the special case function

[PATCH 1/3] paravirt,xen: remove xen_patch()

2017-08-10 Thread Juergen Gross
Xen's paravirt patch function xen_patch() does some special casing for irq_ops functions to apply relocations when those functions can be patched inline instead of calls. Unfortunately none of the special case function replacements is small enough to be patches inline, so the special case never

[PATCH 1/3] paravirt,xen: remove xen_patch()

2017-08-10 Thread Juergen Gross
Xen's paravirt patch function xen_patch() does some special casing for irq_ops functions to apply relocations when those functions can be patched inline instead of calls. Unfortunately none of the special case function replacements is small enough to be patches inline, so the special case never