Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-22 Thread Bjorn Andersson
On Thu 21 Jun 08:14 PDT 2018, Stephen Boyd wrote: > Quoting Bjorn Andersson (2018-06-19 23:45:09) > > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > > > @@ -647,6 +660,10 @@ static void msm_gpio_irq_unmask(struct irq_data *d) > > > raw_spin_lock_irqsave(>lock, flags); > > > > > >

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-22 Thread Bjorn Andersson
On Thu 21 Jun 08:14 PDT 2018, Stephen Boyd wrote: > Quoting Bjorn Andersson (2018-06-19 23:45:09) > > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > > > @@ -647,6 +660,10 @@ static void msm_gpio_irq_unmask(struct irq_data *d) > > > raw_spin_lock_irqsave(>lock, flags); > > > > > >

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-21 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-06-19 23:45:09) > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > > @@ -647,6 +660,10 @@ static void msm_gpio_irq_unmask(struct irq_data *d) > > raw_spin_lock_irqsave(>lock, flags); > > > > val = readl(pctrl->regs + g->intr_cfg_reg); > > + if

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-21 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-06-19 23:45:09) > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > > @@ -647,6 +660,10 @@ static void msm_gpio_irq_unmask(struct irq_data *d) > > raw_spin_lock_irqsave(>lock, flags); > > > > val = readl(pctrl->regs + g->intr_cfg_reg); > > + if

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-20 Thread Doug Anderson
Hi, On Tue, Jun 19, 2018 at 11:45 PM, Bjorn Andersson wrote: > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > >> The interrupt controller hardware in this pin controller has two status >> enable bits. The first "normal" status enable bit enables or disables >> the summary interrupt line

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-20 Thread Doug Anderson
Hi, On Tue, Jun 19, 2018 at 11:45 PM, Bjorn Andersson wrote: > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > >> The interrupt controller hardware in this pin controller has two status >> enable bits. The first "normal" status enable bit enables or disables >> the summary interrupt line

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-20 Thread Bjorn Andersson
On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > The interrupt controller hardware in this pin controller has two status > enable bits. The first "normal" status enable bit enables or disables > the summary interrupt line being raised when a gpio interrupt triggers > and the "raw" status

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-20 Thread Bjorn Andersson
On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > The interrupt controller hardware in this pin controller has two status > enable bits. The first "normal" status enable bit enables or disables > the summary interrupt line being raised when a gpio interrupt triggers > and the "raw" status

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-19 Thread Stephen Boyd
Quoting Doug Anderson (2018-06-18 16:38:27) > Hi, > > On Mon, Jun 18, 2018 at 4:28 PM, Stephen Boyd wrote: > > Quoting Doug Anderson (2018-06-18 15:43:06) > >> > >> On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd wrote: > >> > >> > +*/ > >> > + if (irqd_get_trigger_type(d) &

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-19 Thread Stephen Boyd
Quoting Doug Anderson (2018-06-18 16:38:27) > Hi, > > On Mon, Jun 18, 2018 at 4:28 PM, Stephen Boyd wrote: > > Quoting Doug Anderson (2018-06-18 15:43:06) > >> > >> On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd wrote: > >> > >> > +*/ > >> > + if (irqd_get_trigger_type(d) &

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-18 Thread Doug Anderson
Hi, On Mon, Jun 18, 2018 at 4:28 PM, Stephen Boyd wrote: > Quoting Doug Anderson (2018-06-18 15:43:06) >> >> On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd wrote: >> >> > +*/ >> > + if (irqd_get_trigger_type(d) & IRQ_TYPE_LEVEL_MASK) { >> > + val &=

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-18 Thread Doug Anderson
Hi, On Mon, Jun 18, 2018 at 4:28 PM, Stephen Boyd wrote: > Quoting Doug Anderson (2018-06-18 15:43:06) >> >> On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd wrote: >> >> > +*/ >> > + if (irqd_get_trigger_type(d) & IRQ_TYPE_LEVEL_MASK) { >> > + val &=

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-18 Thread Stephen Boyd
Quoting Doug Anderson (2018-06-18 15:43:06) > > On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd wrote: > > > +*/ > > + if (irqd_get_trigger_type(d) & IRQ_TYPE_LEVEL_MASK) { > > + val &= ~BIT(g->intr_raw_status_bit); > > + writel(val, pctrl->regs +

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-18 Thread Stephen Boyd
Quoting Doug Anderson (2018-06-18 15:43:06) > > On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd wrote: > > > +*/ > > + if (irqd_get_trigger_type(d) & IRQ_TYPE_LEVEL_MASK) { > > + val &= ~BIT(g->intr_raw_status_bit); > > + writel(val, pctrl->regs +

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-18 Thread Doug Anderson
Hi, On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd wrote: > The interrupt controller hardware in this pin controller has two status > enable bits. The first "normal" status enable bit enables or disables > the summary interrupt line being raised when a gpio interrupt triggers > and the "raw"

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-18 Thread Doug Anderson
Hi, On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd wrote: > The interrupt controller hardware in this pin controller has two status > enable bits. The first "normal" status enable bit enables or disables > the summary interrupt line being raised when a gpio interrupt triggers > and the "raw"

[PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-18 Thread Stephen Boyd
The interrupt controller hardware in this pin controller has two status enable bits. The first "normal" status enable bit enables or disables the summary interrupt line being raised when a gpio interrupt triggers and the "raw" status enable bit allows or prevents the hardware from latching an

[PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-18 Thread Stephen Boyd
The interrupt controller hardware in this pin controller has two status enable bits. The first "normal" status enable bit enables or disables the summary interrupt line being raised when a gpio interrupt triggers and the "raw" status enable bit allows or prevents the hardware from latching an