Re: [PATCH 1/3] pmem: Initial version of persistent memory driver

2015-05-07 Thread Boaz Harrosh
On 05/07/2015 10:26 AM, Christoph Hellwig wrote: > On Mon, May 04, 2015 at 10:43:01AM -0600, Ross Zwisler wrote: >>> Yes, if CONFIG_DEBUG_BLOCK_EXT_DEVT isn't set that code doesn't work at all. >> >> I can't figure out a use case that breaks when using dynamically allocated >> minors without CONFIG

Re: [PATCH 1/3] pmem: Initial version of persistent memory driver

2015-05-07 Thread Christoph Hellwig
On Mon, May 04, 2015 at 10:43:01AM -0600, Ross Zwisler wrote: > > Yes, if CONFIG_DEBUG_BLOCK_EXT_DEVT isn't set that code doesn't work at all. > > I can't figure out a use case that breaks when using dynamically allocated > minors without CONFIG_DEBUG_BLOCK_EXT_DEVT. The patch that I've been test

Re: [PATCH 1/3] pmem: Initial version of persistent memory driver

2015-05-04 Thread Ross Zwisler
On Thu, 2015-03-26 at 09:06 +0100, Christoph Hellwig wrote: > On Wed, Mar 25, 2015 at 02:21:53PM -0600, Ross Zwisler wrote: > > What needed to be fixed with the partition support? I used to have real > > numbers for first_minor and passed into alloc_disk(), but simplified it > > based > > on code

Re: [PATCH 1/3] pmem: Initial version of persistent memory driver

2015-04-08 Thread Dr. Greg Wettstein
On Mar 26, 9:32am, Christoph Hellwig wrote: } Subject: [PATCH 1/3] pmem: Initial version of persistent memory driver Hi, I hope the week has been going well for everyone. > From: Ross Zwisler > > PMEM is a new driver that presents a reserved range of memory as a > block devi

Re: [Linux-nvdimm] [PATCH 1/3] pmem: Initial version of persistent memory driver

2015-03-26 Thread Ross Zwisler
On Thu, 2015-03-26 at 15:35 +0100, Christoph Hellwig wrote: > On Thu, Mar 26, 2015 at 07:12:23AM -0700, Dan Williams wrote: > > > + struct resource *res_mem; > > > + int err; > > > + > > > + res_mem = request_mem_region_exclusive(pmem->phys_addr, > > > pmem->size, > > > +

Re: [Linux-nvdimm] [PATCH 1/3] pmem: Initial version of persistent memory driver

2015-03-26 Thread Dan Williams
On Thu, Mar 26, 2015 at 7:52 AM, Boaz Harrosh wrote: > On 03/26/2015 04:12 PM, Dan Williams wrote: >> On Thu, Mar 26, 2015 at 1:32 AM, Christoph Hellwig wrote: >>> From: Ross Zwisler >>> > > Dan something is Broken with you mailer program it keeps dropping the > CC when sending replies. > > For

Re: [Linux-nvdimm] [PATCH 1/3] pmem: Initial version of persistent memory driver

2015-03-26 Thread Boaz Harrosh
On 03/26/2015 04:12 PM, Dan Williams wrote: > On Thu, Mar 26, 2015 at 1:32 AM, Christoph Hellwig wrote: >> From: Ross Zwisler >> Dan something is Broken with you mailer program it keeps dropping the CC when sending replies. For example Both me and Ross who were on CC got dropped, Jens Axboe tho

Re: [Linux-nvdimm] [PATCH 1/3] pmem: Initial version of persistent memory driver

2015-03-26 Thread Christoph Hellwig
On Thu, Mar 26, 2015 at 07:12:23AM -0700, Dan Williams wrote: > > + struct resource *res_mem; > > + int err; > > + > > + res_mem = request_mem_region_exclusive(pmem->phys_addr, pmem->size, > > + "pmem"); > > Isn't request_mem_region()

Re: [Linux-nvdimm] [PATCH 1/3] pmem: Initial version of persistent memory driver

2015-03-26 Thread Dan Williams
On Thu, Mar 26, 2015 at 1:32 AM, Christoph Hellwig wrote: > From: Ross Zwisler > > PMEM is a new driver that presents a reserved range of memory as a > block device. This is useful for developing with NV-DIMMs, and > can be used with volatile memory as a development platform. > > Signed-off-by:

[PATCH 1/3] pmem: Initial version of persistent memory driver

2015-03-26 Thread Christoph Hellwig
From: Ross Zwisler PMEM is a new driver that presents a reserved range of memory as a block device. This is useful for developing with NV-DIMMs, and can be used with volatile memory as a development platform. Signed-off-by: Ross Zwisler [hch: convert to use a platform_device for discovery, fix

Re: [PATCH 1/3] pmem: Initial version of persistent memory driver

2015-03-26 Thread Christoph Hellwig
On Wed, Mar 25, 2015 at 02:21:53PM -0600, Ross Zwisler wrote: > What needed to be fixed with the partition support? I used to have real > numbers for first_minor and passed into alloc_disk(), but simplified it based > on code found in this commit in the nvme driver: > > 469071a37afc NVMe: Dynamic

Re: [PATCH 1/3] pmem: Initial version of persistent memory driver

2015-03-26 Thread Christoph Hellwig
On Wed, Mar 25, 2015 at 02:26:52PM -0600, Ross Zwisler wrote: > Cool - yep, feel free to update this if you want in the next version of > your series, Christoph. Ok, I've fixed this up. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...

Re: [PATCH 1/3] pmem: Initial version of persistent memory driver

2015-03-25 Thread Ross Zwisler
On Wed, 2015-03-25 at 21:19 +0100, Paul Bolle wrote: > The same license nit I found in the previous two versions of this patch. > > On Wed, 2015-03-25 at 17:04 +0100, Christoph Hellwig wrote: > > --- /dev/null > > +++ b/drivers/block/pmem.c > > > + * This program is free software; you can redistr

Re: [PATCH 1/3] pmem: Initial version of persistent memory driver

2015-03-25 Thread Ross Zwisler
On Wed, 2015-03-25 at 17:04 +0100, Christoph Hellwig wrote: > From: Ross Zwisler > > PMEM is a new driver that presents a reserved range of memory as a > block device. This is useful for developing with NV-DIMMs, and > can be used with volatile memory as a development platform. > > Signed-off-b

Re: [PATCH 1/3] pmem: Initial version of persistent memory driver

2015-03-25 Thread Paul Bolle
The same license nit I found in the previous two versions of this patch. On Wed, 2015-03-25 at 17:04 +0100, Christoph Hellwig wrote: > --- /dev/null > +++ b/drivers/block/pmem.c > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of t

[PATCH 1/3] pmem: Initial version of persistent memory driver

2015-03-25 Thread Christoph Hellwig
From: Ross Zwisler PMEM is a new driver that presents a reserved range of memory as a block device. This is useful for developing with NV-DIMMs, and can be used with volatile memory as a development platform. Signed-off-by: Ross Zwisler [hch: convert to use a platform_device for discovery, fix