Re: [PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count

2014-01-15 Thread Rafael J. Wysocki
On Tuesday, January 14, 2014 12:23:40 PM Ben Dooks wrote: > The drivers/base/power/clock_ops.c file is causing warnings from > the clock driver (as shown below) due to failing to do a clk_prepare() > call before enabling a clock. It also fails to check the balance of > prepare/unprepare as

Re: [PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count

2014-01-15 Thread Rafael J. Wysocki
On Tuesday, January 14, 2014 12:23:40 PM Ben Dooks wrote: The drivers/base/power/clock_ops.c file is causing warnings from the clock driver (as shown below) due to failing to do a clk_prepare() call before enabling a clock. It also fails to check the balance of prepare/unprepare as

[PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count

2014-01-14 Thread Ben Dooks
The drivers/base/power/clock_ops.c file is causing warnings from the clock driver (as shown below) due to failing to do a clk_prepare() call before enabling a clock. It also fails to check the balance of prepare/unprepare as __pm_clk_remove() do clk_disable_unprepare() call. This bug has probably

[PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count

2014-01-14 Thread Ben Dooks
The drivers/base/power/clock_ops.c file is causing warnings from the clock driver (as shown below) due to failing to do a clk_prepare() call before enabling a clock. It also fails to check the balance of prepare/unprepare as __pm_clk_remove() do clk_disable_unprepare() call. This bug has probably

[PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count

2014-01-13 Thread Ben Dooks
The drivers/base/power/clock_ops.c file is causing warnings from the clock driver (as shown below) due to failing to do a clk_prepare() call before enabling a clock. It also fails to check the balance of prepare/unprepare as __pm_clk_remove() do clk_disable_unprepare() call. This bug has probably

Re: [PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count

2014-01-13 Thread Ben Dooks
On 13/01/14 08:50, Geert Uytterhoeven wrote: On Mon, Jan 13, 2014 at 7:28 AM, Ben Dooks wrote: I've never noticed this on Lager, probably because Lager multiplatform doesn't make use of clock_ops.c as drivers/sh/pm_runtime.c (which you addressed in another patch that I've also replied to). I'm

Re: [PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count

2014-01-13 Thread Geert Uytterhoeven
On Mon, Jan 13, 2014 at 7:28 AM, Ben Dooks wrote: >> I've never noticed this on Lager, probably because Lager multiplatform >> doesn't >> make use of clock_ops.c as drivers/sh/pm_runtime.c (which you addressed in >> another patch that I've also replied to). I'm thus not sure we need to >> apply

Re: [PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count

2014-01-13 Thread Geert Uytterhoeven
On Mon, Jan 13, 2014 at 7:28 AM, Ben Dooks ben.do...@codethink.co.uk wrote: I've never noticed this on Lager, probably because Lager multiplatform doesn't make use of clock_ops.c as drivers/sh/pm_runtime.c (which you addressed in another patch that I've also replied to). I'm thus not sure we

Re: [PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count

2014-01-13 Thread Ben Dooks
On 13/01/14 08:50, Geert Uytterhoeven wrote: On Mon, Jan 13, 2014 at 7:28 AM, Ben Dooks ben.do...@codethink.co.uk wrote: I've never noticed this on Lager, probably because Lager multiplatform doesn't make use of clock_ops.c as drivers/sh/pm_runtime.c (which you addressed in another patch that

[PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count

2014-01-13 Thread Ben Dooks
The drivers/base/power/clock_ops.c file is causing warnings from the clock driver (as shown below) due to failing to do a clk_prepare() call before enabling a clock. It also fails to check the balance of prepare/unprepare as __pm_clk_remove() do clk_disable_unprepare() call. This bug has probably

Re: [PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count

2014-01-12 Thread Ben Dooks
On 12/01/14 22:04, Laurent Pinchart wrote: Hi Ben, Thank you for the patch. On Saturday 11 January 2014 13:05:38 Ben Dooks wrote: The drivers/base/power/clock_ops.c file is causing warnings from the clock driver (as shown below) due to failing to do a clk_prepare() call before enabling a

Re: [PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count

2014-01-12 Thread Laurent Pinchart
Hi Ben, Thank you for the patch. On Saturday 11 January 2014 13:05:38 Ben Dooks wrote: > The drivers/base/power/clock_ops.c file is causing warnings from > the clock driver (as shown below) due to failing to do a clk_prepare() > call before enabling a clock. It also fails to check the balance of

Re: [PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count

2014-01-12 Thread Laurent Pinchart
Hi Ben, Thank you for the patch. On Saturday 11 January 2014 13:05:38 Ben Dooks wrote: The drivers/base/power/clock_ops.c file is causing warnings from the clock driver (as shown below) due to failing to do a clk_prepare() call before enabling a clock. It also fails to check the balance of

Re: [PATCH 1/3] power: clock_ops.c: fixup clk prepare/unprepare count

2014-01-12 Thread Ben Dooks
On 12/01/14 22:04, Laurent Pinchart wrote: Hi Ben, Thank you for the patch. On Saturday 11 January 2014 13:05:38 Ben Dooks wrote: The drivers/base/power/clock_ops.c file is causing warnings from the clock driver (as shown below) due to failing to do a clk_prepare() call before enabling a