Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-06 Thread Mark Brown
On Mon, Jun 02, 2014 at 03:27:21PM +0900, Jingoo Han wrote: > The site-specific OOM messages are unnecessary, because they > duplicate the MM subsystem generic OOM message. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-06 Thread Mark Brown
On Mon, Jun 02, 2014 at 03:27:21PM +0900, Jingoo Han wrote: The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-03 Thread 'Matt Porter'
On Mon, Jun 02, 2014 at 03:27:21PM +0900, Jingoo Han wrote: > The site-specific OOM messages are unnecessary, because they > duplicate the MM subsystem generic OOM message. > > Signed-off-by: Jingoo Han > --- > drivers/regulator/bcm590xx-regulator.c | 16 > 1 file changed, 4

Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-03 Thread Mark Brown
On Mon, Jun 02, 2014 at 11:41:01PM -0700, Tim Kryger wrote: > The real question is whether this change improves the driver. To me, > it seems like a draw. It's not really for the benefit of the driver, it's for the benefit of the kernel as a whole - the individually hand crafted error messages

Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-03 Thread Tim Kryger
On Mon, Jun 2, 2014 at 5:50 AM, Mark Brown wrote: > On Mon, Jun 02, 2014 at 12:12:20AM -0700, Tim Kryger wrote: > >> The probe method of this driver, on the other hand, performs several >> allocations and the error messages you intend to remove conveniently >> pinpoint which one failed. While

Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-03 Thread Tim Kryger
On Mon, Jun 2, 2014 at 5:50 AM, Mark Brown broo...@kernel.org wrote: On Mon, Jun 02, 2014 at 12:12:20AM -0700, Tim Kryger wrote: The probe method of this driver, on the other hand, performs several allocations and the error messages you intend to remove conveniently pinpoint which one failed.

Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-03 Thread Mark Brown
On Mon, Jun 02, 2014 at 11:41:01PM -0700, Tim Kryger wrote: The real question is whether this change improves the driver. To me, it seems like a draw. It's not really for the benefit of the driver, it's for the benefit of the kernel as a whole - the individually hand crafted error messages

Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-03 Thread 'Matt Porter'
On Mon, Jun 02, 2014 at 03:27:21PM +0900, Jingoo Han wrote: The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/regulator/bcm590xx-regulator.c | 16 1 file

Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-02 Thread Mark Brown
On Mon, Jun 02, 2014 at 12:12:20AM -0700, Tim Kryger wrote: > The probe method of this driver, on the other hand, performs several > allocations and the error messages you intend to remove conveniently > pinpoint which one failed. While the offsets in the trace could be > used to derive the same

Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-02 Thread Tim Kryger
On Sun, Jun 1, 2014 at 11:27 PM, Jingoo Han wrote: > The site-specific OOM messages are unnecessary, because they > duplicate the MM subsystem generic OOM message. > > Signed-off-by: Jingoo Han > --- > drivers/regulator/bcm590xx-regulator.c | 16 > 1 file changed, 4

[PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-02 Thread Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Signed-off-by: Jingoo Han --- drivers/regulator/bcm590xx-regulator.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git

[PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-02 Thread Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/regulator/bcm590xx-regulator.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git

Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-02 Thread Tim Kryger
On Sun, Jun 1, 2014 at 11:27 PM, Jingoo Han jg1@samsung.com wrote: The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/regulator/bcm590xx-regulator.c | 16

Re: [PATCH 1/3] regulator: bcm590xx: remove unnecessary OOM messages

2014-06-02 Thread Mark Brown
On Mon, Jun 02, 2014 at 12:12:20AM -0700, Tim Kryger wrote: The probe method of this driver, on the other hand, performs several allocations and the error messages you intend to remove conveniently pinpoint which one failed. While the offsets in the trace could be used to derive the same