Re: [PATCH 1/3] stopmachine semaphore to mutex
* Daniel Walker <[EMAIL PROTECTED]> wrote: > It's called stopmachine_mutex now, but it's a semaphore. So make it a > "struct mutex" . > > Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> Acked-by: Ingo Molnar <[EMAIL PROTECTED]> Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/3] stopmachine semaphore to mutex
* Daniel Walker [EMAIL PROTECTED] wrote: It's called stopmachine_mutex now, but it's a semaphore. So make it a struct mutex . Signed-off-by: Daniel Walker [EMAIL PROTECTED] Acked-by: Ingo Molnar [EMAIL PROTECTED] Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/3] stopmachine semaphore to mutex
It's called stopmachine_mutex now, but it's a semaphore. So make it a "struct mutex" . Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> --- kernel/stop_machine.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: linux-2.6.23/kernel/stop_machine.c === --- linux-2.6.23.orig/kernel/stop_machine.c +++ linux-2.6.23/kernel/stop_machine.c @@ -29,7 +29,7 @@ enum stopmachine_state { static enum stopmachine_state stopmachine_state; static unsigned int stopmachine_num_threads; static atomic_t stopmachine_thread_ack; -static DECLARE_MUTEX(stopmachine_mutex); +static DEFINE_MUTEX(stopmachine_mutex); static int stopmachine(void *cpu) { @@ -177,7 +177,7 @@ struct task_struct *__stop_machine_run(i smdata.data = data; init_completion(); - down(_mutex); + mutex_lock(_mutex); /* If they don't care which CPU fn runs on, bind to any online one. */ if (cpu == NR_CPUS) @@ -193,7 +193,7 @@ struct task_struct *__stop_machine_run(i wake_up_process(p); wait_for_completion(); } - up(_mutex); + mutex_unlock(_mutex); return p; } -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/3] stopmachine semaphore to mutex
It's called stopmachine_mutex now, but it's a semaphore. So make it a struct mutex . Signed-off-by: Daniel Walker [EMAIL PROTECTED] --- kernel/stop_machine.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: linux-2.6.23/kernel/stop_machine.c === --- linux-2.6.23.orig/kernel/stop_machine.c +++ linux-2.6.23/kernel/stop_machine.c @@ -29,7 +29,7 @@ enum stopmachine_state { static enum stopmachine_state stopmachine_state; static unsigned int stopmachine_num_threads; static atomic_t stopmachine_thread_ack; -static DECLARE_MUTEX(stopmachine_mutex); +static DEFINE_MUTEX(stopmachine_mutex); static int stopmachine(void *cpu) { @@ -177,7 +177,7 @@ struct task_struct *__stop_machine_run(i smdata.data = data; init_completion(smdata.done); - down(stopmachine_mutex); + mutex_lock(stopmachine_mutex); /* If they don't care which CPU fn runs on, bind to any online one. */ if (cpu == NR_CPUS) @@ -193,7 +193,7 @@ struct task_struct *__stop_machine_run(i wake_up_process(p); wait_for_completion(smdata.done); } - up(stopmachine_mutex); + mutex_unlock(stopmachine_mutex); return p; } -- -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/