Re: [PATCH 1/3] timer: Optimize fastpath_timer_check()

2015-08-31 Thread Jason Low
On Mon, 2015-08-31 at 08:15 -0700, Davidlohr Bueso wrote: > On Tue, 2015-08-25 at 20:17 -0700, Jason Low wrote: > > In fastpath_timer_check(), the task_cputime() function is always > > called to compute the utime and stime values. However, this is not > > necessary if there are no per-thread

Re: [PATCH 1/3] timer: Optimize fastpath_timer_check()

2015-08-31 Thread Davidlohr Bueso
On Tue, 2015-08-25 at 20:17 -0700, Jason Low wrote: > In fastpath_timer_check(), the task_cputime() function is always > called to compute the utime and stime values. However, this is not > necessary if there are no per-thread timers to check for. This patch > modifies the code such that we

Re: [PATCH 1/3] timer: Optimize fastpath_timer_check()

2015-08-31 Thread Davidlohr Bueso
On Tue, 2015-08-25 at 20:17 -0700, Jason Low wrote: > In fastpath_timer_check(), the task_cputime() function is always > called to compute the utime and stime values. However, this is not > necessary if there are no per-thread timers to check for. This patch > modifies the code such that we

Re: [PATCH 1/3] timer: Optimize fastpath_timer_check()

2015-08-31 Thread Jason Low
On Mon, 2015-08-31 at 08:15 -0700, Davidlohr Bueso wrote: > On Tue, 2015-08-25 at 20:17 -0700, Jason Low wrote: > > In fastpath_timer_check(), the task_cputime() function is always > > called to compute the utime and stime values. However, this is not > > necessary if there are no per-thread

Re: [PATCH 1/3] timer: Optimize fastpath_timer_check()

2015-08-26 Thread Frederic Weisbecker
On Tue, Aug 25, 2015 at 08:17:46PM -0700, Jason Low wrote: > In fastpath_timer_check(), the task_cputime() function is always > called to compute the utime and stime values. However, this is not > necessary if there are no per-thread timers to check for. This patch > modifies the code such that we

Re: [PATCH 1/3] timer: Optimize fastpath_timer_check()

2015-08-26 Thread Jason Low
On Wed, 2015-08-26 at 12:57 -0400, George Spelvin wrote: > > if (!task_cputime_zero(>cputime_expires)) { > >+struct task_cputime task_sample; > >+cputime_t utime, stime; > >+ > >+task_cputime(tsk, , ); > >+task_sample.utime = utime; > >+

Re: [PATCH 1/3] timer: Optimize fastpath_timer_check()

2015-08-26 Thread George Spelvin
> if (!task_cputime_zero(>cputime_expires)) { >+ struct task_cputime task_sample; >+ cputime_t utime, stime; >+ >+ task_cputime(tsk, , ); >+ task_sample.utime = utime; >+ task_sample.stime = stime; >+

Re: [PATCH 1/3] timer: Optimize fastpath_timer_check()

2015-08-26 Thread Jason Low
On Wed, 2015-08-26 at 12:57 -0400, George Spelvin wrote: if (!task_cputime_zero(tsk-cputime_expires)) { +struct task_cputime task_sample; +cputime_t utime, stime; + +task_cputime(tsk, utime, stime); +task_sample.utime = utime; +

Re: [PATCH 1/3] timer: Optimize fastpath_timer_check()

2015-08-26 Thread George Spelvin
if (!task_cputime_zero(tsk-cputime_expires)) { + struct task_cputime task_sample; + cputime_t utime, stime; + + task_cputime(tsk, utime, stime); + task_sample.utime = utime; + task_sample.stime = stime; +

Re: [PATCH 1/3] timer: Optimize fastpath_timer_check()

2015-08-26 Thread Frederic Weisbecker
On Tue, Aug 25, 2015 at 08:17:46PM -0700, Jason Low wrote: In fastpath_timer_check(), the task_cputime() function is always called to compute the utime and stime values. However, this is not necessary if there are no per-thread timers to check for. This patch modifies the code such that we

[PATCH 1/3] timer: Optimize fastpath_timer_check()

2015-08-25 Thread Jason Low
In fastpath_timer_check(), the task_cputime() function is always called to compute the utime and stime values. However, this is not necessary if there are no per-thread timers to check for. This patch modifies the code such that we compute the task_cputime values only when there are per-thread

[PATCH 1/3] timer: Optimize fastpath_timer_check()

2015-08-25 Thread Jason Low
In fastpath_timer_check(), the task_cputime() function is always called to compute the utime and stime values. However, this is not necessary if there are no per-thread timers to check for. This patch modifies the code such that we compute the task_cputime values only when there are per-thread