Re: [PATCH 1/3] tuntap: rx batching

2016-11-15 Thread Jason Wang
On 2016年11月15日 11:41, Michael S. Tsirkin wrote: On Tue, Nov 15, 2016 at 11:14:48AM +0800, Jason Wang wrote: > > >On 2016年11月12日 00:20, Michael S. Tsirkin wrote: > >On Fri, Nov 11, 2016 at 12:28:38PM +0800, Jason Wang wrote: > > > > > >On 2016年11月11日 12:17, John Fastabend wrote: > > > >On

Re: [PATCH 1/3] tuntap: rx batching

2016-11-15 Thread Jason Wang
On 2016年11月15日 11:41, Michael S. Tsirkin wrote: On Tue, Nov 15, 2016 at 11:14:48AM +0800, Jason Wang wrote: > > >On 2016年11月12日 00:20, Michael S. Tsirkin wrote: > >On Fri, Nov 11, 2016 at 12:28:38PM +0800, Jason Wang wrote: > > > > > >On 2016年11月11日 12:17, John Fastabend wrote: > > > >On

Re: [PATCH 1/3] tuntap: rx batching

2016-11-14 Thread Michael S. Tsirkin
On Tue, Nov 15, 2016 at 11:14:48AM +0800, Jason Wang wrote: > > > On 2016年11月12日 00:20, Michael S. Tsirkin wrote: > > On Fri, Nov 11, 2016 at 12:28:38PM +0800, Jason Wang wrote: > > > > > > On 2016年11月11日 12:17, John Fastabend wrote: > > > > On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: > > >

Re: [PATCH 1/3] tuntap: rx batching

2016-11-14 Thread Michael S. Tsirkin
On Tue, Nov 15, 2016 at 11:14:48AM +0800, Jason Wang wrote: > > > On 2016年11月12日 00:20, Michael S. Tsirkin wrote: > > On Fri, Nov 11, 2016 at 12:28:38PM +0800, Jason Wang wrote: > > > > > > On 2016年11月11日 12:17, John Fastabend wrote: > > > > On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: > > >

Re: [PATCH 1/3] tuntap: rx batching

2016-11-14 Thread Jason Wang
On 2016年11月12日 00:20, Michael S. Tsirkin wrote: On Fri, Nov 11, 2016 at 12:28:38PM +0800, Jason Wang wrote: On 2016年11月11日 12:17, John Fastabend wrote: On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: On 2016年11月10日 00:38,

Re: [PATCH 1/3] tuntap: rx batching

2016-11-14 Thread Jason Wang
On 2016年11月12日 00:20, Michael S. Tsirkin wrote: On Fri, Nov 11, 2016 at 12:28:38PM +0800, Jason Wang wrote: On 2016年11月11日 12:17, John Fastabend wrote: On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: On 2016年11月10日 00:38,

Re: [PATCH 1/3] tuntap: rx batching

2016-11-11 Thread Michael S. Tsirkin
On Fri, Nov 11, 2016 at 12:28:38PM +0800, Jason Wang wrote: > > > On 2016年11月11日 12:17, John Fastabend wrote: > > On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: > > > >On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: > > > > >> > > > > >> > > > > >>On 2016年11月10日 00:38, Michael S.

Re: [PATCH 1/3] tuntap: rx batching

2016-11-11 Thread Michael S. Tsirkin
On Fri, Nov 11, 2016 at 12:28:38PM +0800, Jason Wang wrote: > > > On 2016年11月11日 12:17, John Fastabend wrote: > > On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: > > > >On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: > > > > >> > > > > >> > > > > >>On 2016年11月10日 00:38, Michael S.

Re: [PATCH 1/3] tuntap: rx batching

2016-11-10 Thread John Fastabend
On 16-11-10 08:28 PM, Jason Wang wrote: > > > On 2016年11月11日 12:17, John Fastabend wrote: >> On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: >>> >On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: >> >> >>On 2016年11月10日 00:38, Michael S. Tsirkin wrote: > >>>On Wed,

Re: [PATCH 1/3] tuntap: rx batching

2016-11-10 Thread John Fastabend
On 16-11-10 08:28 PM, Jason Wang wrote: > > > On 2016年11月11日 12:17, John Fastabend wrote: >> On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: >>> >On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: >> >> >>On 2016年11月10日 00:38, Michael S. Tsirkin wrote: > >>>On Wed,

Re: [PATCH 1/3] tuntap: rx batching

2016-11-10 Thread Jason Wang
On 2016年11月11日 12:17, John Fastabend wrote: On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: >On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: >> >> >>On 2016年11月10日 00:38, Michael S. Tsirkin wrote: >>>On Wed, Nov 09, 2016 at 03:38:31PM +0800, Jason Wang wrote: Backlog were

Re: [PATCH 1/3] tuntap: rx batching

2016-11-10 Thread Jason Wang
On 2016年11月11日 12:17, John Fastabend wrote: On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: >On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: >> >> >>On 2016年11月10日 00:38, Michael S. Tsirkin wrote: >>>On Wed, Nov 09, 2016 at 03:38:31PM +0800, Jason Wang wrote: Backlog were

Re: [PATCH 1/3] tuntap: rx batching

2016-11-10 Thread John Fastabend
On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: > On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: >> >> >> On 2016年11月10日 00:38, Michael S. Tsirkin wrote: >>> On Wed, Nov 09, 2016 at 03:38:31PM +0800, Jason Wang wrote: Backlog were used for tuntap rx, but it can only process 1

Re: [PATCH 1/3] tuntap: rx batching

2016-11-10 Thread John Fastabend
On 16-11-10 07:31 PM, Michael S. Tsirkin wrote: > On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: >> >> >> On 2016年11月10日 00:38, Michael S. Tsirkin wrote: >>> On Wed, Nov 09, 2016 at 03:38:31PM +0800, Jason Wang wrote: Backlog were used for tuntap rx, but it can only process 1

Re: [PATCH 1/3] tuntap: rx batching

2016-11-10 Thread Jason Wang
On 2016年11月11日 11:31, Michael S. Tsirkin wrote: On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: > > >On 2016年11月10日 00:38, Michael S. Tsirkin wrote: > >On Wed, Nov 09, 2016 at 03:38:31PM +0800, Jason Wang wrote: > > >Backlog were used for tuntap rx, but it can only process 1

Re: [PATCH 1/3] tuntap: rx batching

2016-11-10 Thread Jason Wang
On 2016年11月11日 11:31, Michael S. Tsirkin wrote: On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: > > >On 2016年11月10日 00:38, Michael S. Tsirkin wrote: > >On Wed, Nov 09, 2016 at 03:38:31PM +0800, Jason Wang wrote: > > >Backlog were used for tuntap rx, but it can only process 1

Re: [PATCH 1/3] tuntap: rx batching

2016-11-10 Thread Michael S. Tsirkin
On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: > > > On 2016年11月10日 00:38, Michael S. Tsirkin wrote: > > On Wed, Nov 09, 2016 at 03:38:31PM +0800, Jason Wang wrote: > > > Backlog were used for tuntap rx, but it can only process 1 packet at > > > one time since it was scheduled

Re: [PATCH 1/3] tuntap: rx batching

2016-11-10 Thread Michael S. Tsirkin
On Fri, Nov 11, 2016 at 10:07:44AM +0800, Jason Wang wrote: > > > On 2016年11月10日 00:38, Michael S. Tsirkin wrote: > > On Wed, Nov 09, 2016 at 03:38:31PM +0800, Jason Wang wrote: > > > Backlog were used for tuntap rx, but it can only process 1 packet at > > > one time since it was scheduled

Re: [PATCH 1/3] tuntap: rx batching

2016-11-10 Thread Jason Wang
On 2016年11月10日 00:38, Michael S. Tsirkin wrote: On Wed, Nov 09, 2016 at 03:38:31PM +0800, Jason Wang wrote: Backlog were used for tuntap rx, but it can only process 1 packet at one time since it was scheduled during sendmsg() synchronously in process context. This lead bad cache utilization

Re: [PATCH 1/3] tuntap: rx batching

2016-11-10 Thread Jason Wang
On 2016年11月10日 00:38, Michael S. Tsirkin wrote: On Wed, Nov 09, 2016 at 03:38:31PM +0800, Jason Wang wrote: Backlog were used for tuntap rx, but it can only process 1 packet at one time since it was scheduled during sendmsg() synchronously in process context. This lead bad cache utilization

Re: [PATCH 1/3] tuntap: rx batching

2016-11-09 Thread Michael S. Tsirkin
On Wed, Nov 09, 2016 at 03:38:31PM +0800, Jason Wang wrote: > Backlog were used for tuntap rx, but it can only process 1 packet at > one time since it was scheduled during sendmsg() synchronously in > process context. This lead bad cache utilization so this patch tries > to do some batching before

Re: [PATCH 1/3] tuntap: rx batching

2016-11-09 Thread Michael S. Tsirkin
On Wed, Nov 09, 2016 at 03:38:31PM +0800, Jason Wang wrote: > Backlog were used for tuntap rx, but it can only process 1 packet at > one time since it was scheduled during sendmsg() synchronously in > process context. This lead bad cache utilization so this patch tries > to do some batching before

[PATCH 1/3] tuntap: rx batching

2016-11-08 Thread Jason Wang
Backlog were used for tuntap rx, but it can only process 1 packet at one time since it was scheduled during sendmsg() synchronously in process context. This lead bad cache utilization so this patch tries to do some batching before call rx NAPI. This is done through: - accept MSG_MORE as a hint

[PATCH 1/3] tuntap: rx batching

2016-11-08 Thread Jason Wang
Backlog were used for tuntap rx, but it can only process 1 packet at one time since it was scheduled during sendmsg() synchronously in process context. This lead bad cache utilization so this patch tries to do some batching before call rx NAPI. This is done through: - accept MSG_MORE as a hint