Re: [PATCH 1/4] loop: Enable correct physical blocksize

2015-12-01 Thread Hannes Reinecke
On 11/13/2015 09:57 PM, Jeff Moyer wrote: Hi Hannes, Hannes Reinecke writes: When running on files the physical blocksize is actually 4k, How did you come to that conclusion? Are you basing it on the file system block size? If so, that's configurable at mkfs time and can be anything from

Re: [PATCH 1/4] loop: Enable correct physical blocksize

2015-12-01 Thread Hannes Reinecke
On 11/13/2015 09:57 PM, Jeff Moyer wrote: Hi Hannes, Hannes Reinecke writes: When running on files the physical blocksize is actually 4k, How did you come to that conclusion? Are you basing it on the file system block size? If so, that's configurable at mkfs time and can be

Re: [PATCH 1/4] loop: Enable correct physical blocksize

2015-11-19 Thread Ming Lei
On Tue, Nov 10, 2015 at 4:13 PM, Hannes Reinecke wrote: > When running on files the physical blocksize is actually 4k, > so we should be announcing it as such. This is enabled with > a new LO_FLAGS_BLOCKSIZE flag value to the existing > loop_set_status ioctl. LO_FLAGS_BLOCKSIZE is defined in

Re: [PATCH 1/4] loop: Enable correct physical blocksize

2015-11-19 Thread Ming Lei
On Tue, Nov 10, 2015 at 4:13 PM, Hannes Reinecke wrote: > When running on files the physical blocksize is actually 4k, > so we should be announcing it as such. This is enabled with > a new LO_FLAGS_BLOCKSIZE flag value to the existing > loop_set_status ioctl. LO_FLAGS_BLOCKSIZE is

Re: [PATCH 1/4] loop: Enable correct physical blocksize

2015-11-13 Thread Jeff Moyer
Hi Hannes, Hannes Reinecke writes: > When running on files the physical blocksize is actually 4k, How did you come to that conclusion? Are you basing it on the file system block size? If so, that's configurable at mkfs time and can be anything from 512 bytes to 64k on current in-tree file

Re: [PATCH 1/4] loop: Enable correct physical blocksize

2015-11-13 Thread Jeff Moyer
Hi Hannes, Hannes Reinecke writes: > When running on files the physical blocksize is actually 4k, How did you come to that conclusion? Are you basing it on the file system block size? If so, that's configurable at mkfs time and can be anything from 512 bytes to 64k on current

[PATCH 1/4] loop: Enable correct physical blocksize

2015-11-10 Thread Hannes Reinecke
When running on files the physical blocksize is actually 4k, so we should be announcing it as such. This is enabled with a new LO_FLAGS_BLOCKSIZE flag value to the existing loop_set_status ioctl. Signed-off-by: Hannes Reinecke --- drivers/block/loop.c | 9 - 1 file changed, 8

[PATCH 1/4] loop: Enable correct physical blocksize

2015-11-10 Thread Hannes Reinecke
When running on files the physical blocksize is actually 4k, so we should be announcing it as such. This is enabled with a new LO_FLAGS_BLOCKSIZE flag value to the existing loop_set_status ioctl. Signed-off-by: Hannes Reinecke --- drivers/block/loop.c | 9 - 1 file

Re: [PATCH 1/4] loop: Enable correct physical blocksize

2015-08-07 Thread Christoph Hellwig
On Mon, Jul 27, 2015 at 07:59:47AM +0200, Hannes Reinecke wrote: > On 07/27/2015 07:15 AM, Christoph Hellwig wrote: > > On Fri, Jul 17, 2015 at 09:27:04AM +0200, Hannes Reinecke wrote: > >> When running on files the physical blocksize is actually 4k, > >> so we should be announcing it as such.

Re: [PATCH 1/4] loop: Enable correct physical blocksize

2015-08-07 Thread Christoph Hellwig
On Mon, Jul 27, 2015 at 07:59:47AM +0200, Hannes Reinecke wrote: On 07/27/2015 07:15 AM, Christoph Hellwig wrote: On Fri, Jul 17, 2015 at 09:27:04AM +0200, Hannes Reinecke wrote: When running on files the physical blocksize is actually 4k, so we should be announcing it as such. This is

Re: [PATCH 1/4] loop: Enable correct physical blocksize

2015-07-27 Thread Hannes Reinecke
On 07/27/2015 07:15 AM, Christoph Hellwig wrote: > On Fri, Jul 17, 2015 at 09:27:04AM +0200, Hannes Reinecke wrote: >> When running on files the physical blocksize is actually 4k, >> so we should be announcing it as such. This is enabled with >> a new LO_FLAGS_BLOCKSIZE flag value to the existing

Re: [PATCH 1/4] loop: Enable correct physical blocksize

2015-07-27 Thread Hannes Reinecke
On 07/27/2015 07:15 AM, Christoph Hellwig wrote: On Fri, Jul 17, 2015 at 09:27:04AM +0200, Hannes Reinecke wrote: When running on files the physical blocksize is actually 4k, so we should be announcing it as such. This is enabled with a new LO_FLAGS_BLOCKSIZE flag value to the existing ioctl.

Re: [PATCH 1/4] loop: Enable correct physical blocksize

2015-07-26 Thread Christoph Hellwig
On Fri, Jul 17, 2015 at 09:27:04AM +0200, Hannes Reinecke wrote: > When running on files the physical blocksize is actually 4k, > so we should be announcing it as such. This is enabled with > a new LO_FLAGS_BLOCKSIZE flag value to the existing ioctl. The flag is only used in this patch, but not

Re: [PATCH 1/4] loop: Enable correct physical blocksize

2015-07-26 Thread Christoph Hellwig
On Fri, Jul 17, 2015 at 09:27:04AM +0200, Hannes Reinecke wrote: When running on files the physical blocksize is actually 4k, so we should be announcing it as such. This is enabled with a new LO_FLAGS_BLOCKSIZE flag value to the existing ioctl. The flag is only used in this patch, but not

[PATCH 1/4] loop: Enable correct physical blocksize

2015-07-17 Thread Hannes Reinecke
When running on files the physical blocksize is actually 4k, so we should be announcing it as such. This is enabled with a new LO_FLAGS_BLOCKSIZE flag value to the existing ioctl. Signed-off-by: Hannes Reinecke --- drivers/block/loop.c | 9 - 1 file changed, 8 insertions(+), 1

[PATCH 1/4] loop: Enable correct physical blocksize

2015-07-17 Thread Hannes Reinecke
When running on files the physical blocksize is actually 4k, so we should be announcing it as such. This is enabled with a new LO_FLAGS_BLOCKSIZE flag value to the existing ioctl. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/block/loop.c | 9 - 1 file changed, 8 insertions(+),