Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-05-14 Thread Sudeep Holla
On 14/05/15 08:30, Jassi Brar wrote: On Thu, May 14, 2015 at 12:32 PM, Jassi Brar wrote: BTW is scpi_protocol.c meant/tested to work over arm_mhu.c? The spec says so but I don't see how because you pass 'struct scpi_xfer*' as the message whereas arm_mhu.c expects u32* Yes it's tested usin

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-05-14 Thread Jassi Brar
On Thu, May 14, 2015 at 12:32 PM, Jassi Brar wrote: > > BTW is scpi_protocol.c meant/tested to work over arm_mhu.c? The spec > says so but I don't see how because you pass 'struct scpi_xfer*' as > the message whereas arm_mhu.c expects u32* > It seems your remote doesn't interpret the value in STAT

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-05-14 Thread Jassi Brar
On Wed, May 13, 2015 at 10:39 PM, Sudeep Holla wrote: > On 13/05/15 17:52, Jassi Brar wrote: >> >>> This patch adds support for System Control and Power Interface (SCPI) >>> Message Protocol used between the Application Cores(AP) and the System >>> Control Processor(SCP). The MHU peripheral provid

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-05-13 Thread Sudeep Holla
On 13/05/15 17:52, Jassi Brar wrote: On Mon, Apr 27, 2015 at 5:10 PM, Sudeep Holla wrote: This patch adds support for System Control and Power Interface (SCPI) Message Protocol used between the Application Cores(AP) and the System Control Processor(SCP). The MHU peripheral provides a mechanis

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-05-13 Thread Jassi Brar
On Mon, Apr 27, 2015 at 5:10 PM, Sudeep Holla wrote: > This patch adds support for System Control and Power Interface (SCPI) > Message Protocol used between the Application Cores(AP) and the System > Control Processor(SCP). The MHU peripheral provides a mechanism for > inter-processor communicatio

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-04-30 Thread Jon Medhurst (Tixy)
On Wed, 2015-04-29 at 13:25 +0100, Jon Medhurst (Tixy) wrote: > diff --git a/drivers/mailbox/scpi_protocol.c > b/drivers/mailbox/scpi_protocol.c > index c74575b..5818d9b 100644 > --- a/drivers/mailbox/scpi_protocol.c > +++ b/drivers/mailbox/scpi_protocol.c > @@ -286,14 +286,23 @@ static void scpi_t

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-04-29 Thread Sudeep Holla
On 29/04/15 13:25, Jon Medhurst (Tixy) wrote: On Wed, 2015-04-29 at 12:43 +0100, Jon Medhurst (Tixy) wrote: On Wed, 2015-04-29 at 11:53 +0100, Sudeep Holla wrote: On 28/04/15 14:54, Jon Medhurst (Tixy) wrote: On Mon, 2015-04-27 at 12:40 +0100, Sudeep Holla wrote: [...] + int ret; +

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-04-29 Thread Sudeep Holla
Hi Tixy, On 29/04/15 12:43, Jon Medhurst (Tixy) wrote: On Wed, 2015-04-29 at 11:53 +0100, Sudeep Holla wrote: On 28/04/15 14:54, Jon Medhurst (Tixy) wrote: On Mon, 2015-04-27 at 12:40 +0100, Sudeep Holla wrote: [...] + int ret; + u8 token, chan; + struct scpi_xfer *msg; + str

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-04-29 Thread Jon Medhurst (Tixy)
On Wed, 2015-04-29 at 12:43 +0100, Jon Medhurst (Tixy) wrote: > On Wed, 2015-04-29 at 11:53 +0100, Sudeep Holla wrote: > > On 28/04/15 14:54, Jon Medhurst (Tixy) wrote: > > > On Mon, 2015-04-27 at 12:40 +0100, Sudeep Holla wrote: > [...] > > >> + int ret; > > >> + u8 token, chan; > > >> +

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-04-29 Thread Jon Medhurst (Tixy)
On Wed, 2015-04-29 at 11:53 +0100, Sudeep Holla wrote: > On 28/04/15 14:54, Jon Medhurst (Tixy) wrote: > > On Mon, 2015-04-27 at 12:40 +0100, Sudeep Holla wrote: [...] > >> + int ret; > >> + u8 token, chan; > >> + struct scpi_xfer *msg; > >> + struct scpi_chan *scpi_chan; > >> + > >

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-04-29 Thread Sudeep Holla
On 28/04/15 14:54, Jon Medhurst (Tixy) wrote: On Mon, 2015-04-27 at 12:40 +0100, Sudeep Holla wrote: This patch adds support for System Control and Power Interface (SCPI) Message Protocol used between the Application Cores(AP) and the System Control Processor(SCP). The MHU peripheral provides

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-04-28 Thread Jon Medhurst (Tixy)
On Mon, 2015-04-27 at 12:40 +0100, Sudeep Holla wrote: > This patch adds support for System Control and Power Interface (SCPI) > Message Protocol used between the Application Cores(AP) and the System > Control Processor(SCP). The MHU peripheral provides a mechanism for > inter-processor communicati

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-04-28 Thread Sudeep Holla
On 28/04/15 08:36, Paul Bolle wrote: Just one nit: a license mismatch. On Mon, 2015-04-27 at 12:40 +0100, Sudeep Holla wrote: --- /dev/null +++ b/drivers/mailbox/scpi_protocol.c + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions o

Re: [PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-04-28 Thread Paul Bolle
Just one nit: a license mismatch. On Mon, 2015-04-27 at 12:40 +0100, Sudeep Holla wrote: > --- /dev/null > +++ b/drivers/mailbox/scpi_protocol.c > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, >

[PATCH 1/4] mailbox: add support for System Control and Power Interface(SCPI) protocol

2015-04-27 Thread Sudeep Holla
This patch adds support for System Control and Power Interface (SCPI) Message Protocol used between the Application Cores(AP) and the System Control Processor(SCP). The MHU peripheral provides a mechanism for inter-processor communication between SCP's M3 processor and AP. SCP offers control and m