On Tue, Aug 21, 2012 at 05:09:24PM +0300, Felipe Balbi wrote:
> You can't possibly understand what that'll print. First of all, VEN_ID_H
> and VEN_ID_L should be ORed together. Second, the user will see the same
> message four times in a row, with different values, but see that driver
> claims
Hi,
On Tue, Aug 21, 2012 at 03:08:03PM +0100, Mark Brown wrote:
> On Tue, Aug 21, 2012 at 04:52:41PM +0300, Felipe Balbi wrote:
>
> > Fair enough, we have "quiet", but I'm not sure that's enough argument to
> > allow any simple driver to start poluting dmesg with whatever random
> > messages.
>
On Tue, Aug 21, 2012 at 04:52:41PM +0300, Felipe Balbi wrote:
> Fair enough, we have "quiet", but I'm not sure that's enough argument to
> allow any simple driver to start poluting dmesg with whatever random
> messages.
I think if the driver is just logging to say "I'm running" that's noise
and
On Tue, Aug 21, 2012 at 02:49:37PM +0100, Mark Brown wrote:
> On Tue, Aug 21, 2012 at 04:27:44PM +0300, Felipe Balbi wrote:
>
> > I still beg to differ. Even if it fails, dmesg will still contain the
> > message (provided you have it enabled). I really don't think we want
> > this to print to
On Tue, Aug 21, 2012 at 04:27:44PM +0300, Felipe Balbi wrote:
> I still beg to differ. Even if it fails, dmesg will still contain the
> message (provided you have it enabled). I really don't think we want
> this to print to console on every boot.
Only if it's enabled which is the trick...
> If
On Tue, Aug 21, 2012 at 02:22:22PM +0100, Mark Brown wrote:
> On Tue, Aug 21, 2012 at 03:42:45PM +0300, Felipe Balbi wrote:
> > On Tue, Aug 21, 2012 at 01:41:46PM +0100, Mark Brown wrote:
> > > > + regmap_read(smsc->regmap, SMSC_DEV_ID, );
> > > > + dev_dbg(>dev, "SMSC Device ID:
On Tue, Aug 21, 2012 at 03:42:45PM +0300, Felipe Balbi wrote:
> On Tue, Aug 21, 2012 at 01:41:46PM +0100, Mark Brown wrote:
> > > + regmap_read(smsc->regmap, SMSC_DEV_ID, );
> > > + dev_dbg(>dev, "SMSC Device ID: %d\n", ret);
> > I'd make these log messages dev_info() or something.
> dev_info()
On Tue, Aug 21, 2012 at 01:41:46PM +0100, Mark Brown wrote:
> > + regmap_read(smsc->regmap, SMSC_DEV_ID, );
> > + dev_dbg(>dev, "SMSC Device ID: %d\n", ret);
>
> I'd make these log messages dev_info() or something.
dev_info() ? It'lll just make boot noisier for no good reason. Which
user
On Tue, Aug 21, 2012 at 04:15:37PM +0530, Sourav Poddar wrote:
> +config MFD_SMSC
> + bool "Support for the SMSC ECE1099 series chips"
> + depends on I2C=y && MFD_CORE && REGMAP_I2C
This needs to select REGMAP_I2C not depend on it. REGMAP_I2C will only
be enabled by being selected.
smsc ece1099 is a keyboard scan or gpio expansion device.
The patch create keypad and gpio expander child for this
multi function smsc driver.
Cc: Samuel Ortiz
Cc: Benoit Cousson
Cc: Felipe Balbi
Cc: Santosh Shilimkar
Signed-off-by: Sourav Poddar
---
Documentation/smsc_ece1099.txt | 56
smsc ece1099 is a keyboard scan or gpio expansion device.
The patch create keypad and gpio expander child for this
multi function smsc driver.
Cc: Samuel Ortiz sa...@linux.intel.com
Cc: Benoit Cousson b-cous...@ti.com
Cc: Felipe Balbi ba...@ti.com
Cc: Santosh Shilimkar santosh.shilim...@ti.com
On Tue, Aug 21, 2012 at 04:15:37PM +0530, Sourav Poddar wrote:
+config MFD_SMSC
+ bool Support for the SMSC ECE1099 series chips
+ depends on I2C=y MFD_CORE REGMAP_I2C
This needs to select REGMAP_I2C not depend on it. REGMAP_I2C will only
be enabled by being selected.
+int
On Tue, Aug 21, 2012 at 01:41:46PM +0100, Mark Brown wrote:
+ regmap_read(smsc-regmap, SMSC_DEV_ID, ret);
+ dev_dbg(i2c-dev, SMSC Device ID: %d\n, ret);
I'd make these log messages dev_info() or something.
dev_info() ? It'lll just make boot noisier for no good reason. Which
user wants
On Tue, Aug 21, 2012 at 03:42:45PM +0300, Felipe Balbi wrote:
On Tue, Aug 21, 2012 at 01:41:46PM +0100, Mark Brown wrote:
+ regmap_read(smsc-regmap, SMSC_DEV_ID, ret);
+ dev_dbg(i2c-dev, SMSC Device ID: %d\n, ret);
I'd make these log messages dev_info() or something.
dev_info() ?
On Tue, Aug 21, 2012 at 02:22:22PM +0100, Mark Brown wrote:
On Tue, Aug 21, 2012 at 03:42:45PM +0300, Felipe Balbi wrote:
On Tue, Aug 21, 2012 at 01:41:46PM +0100, Mark Brown wrote:
+ regmap_read(smsc-regmap, SMSC_DEV_ID, ret);
+ dev_dbg(i2c-dev, SMSC Device ID: %d\n, ret);
On Tue, Aug 21, 2012 at 04:27:44PM +0300, Felipe Balbi wrote:
I still beg to differ. Even if it fails, dmesg will still contain the
message (provided you have it enabled). I really don't think we want
this to print to console on every boot.
Only if it's enabled which is the trick...
If
On Tue, Aug 21, 2012 at 02:49:37PM +0100, Mark Brown wrote:
On Tue, Aug 21, 2012 at 04:27:44PM +0300, Felipe Balbi wrote:
I still beg to differ. Even if it fails, dmesg will still contain the
message (provided you have it enabled). I really don't think we want
this to print to console on
On Tue, Aug 21, 2012 at 04:52:41PM +0300, Felipe Balbi wrote:
Fair enough, we have quiet, but I'm not sure that's enough argument to
allow any simple driver to start poluting dmesg with whatever random
messages.
I think if the driver is just logging to say I'm running that's noise
and I do
Hi,
On Tue, Aug 21, 2012 at 03:08:03PM +0100, Mark Brown wrote:
On Tue, Aug 21, 2012 at 04:52:41PM +0300, Felipe Balbi wrote:
Fair enough, we have quiet, but I'm not sure that's enough argument to
allow any simple driver to start poluting dmesg with whatever random
messages.
I think
On Tue, Aug 21, 2012 at 05:09:24PM +0300, Felipe Balbi wrote:
You can't possibly understand what that'll print. First of all, VEN_ID_H
and VEN_ID_L should be ORed together. Second, the user will see the same
message four times in a row, with different values, but see that driver
claims that
20 matches
Mail list logo
