Re: [PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits

2018-02-15 Thread Alexandre Belloni
On 15/02/2018 at 07:27:47 +, Denis OSTERLAND wrote: > Am Mittwoch, den 14.02.2018, 21:26 +0100 schrieb Alexandre Belloni: > > On 23/01/2018 at 13:17:58 +0100, Michael Grzeschik wrote: > > > > > > From: Denis Osterland > > > > > > After successful > > > sr =

Re: [PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits

2018-02-15 Thread Alexandre Belloni
On 15/02/2018 at 07:27:47 +, Denis OSTERLAND wrote: > Am Mittwoch, den 14.02.2018, 21:26 +0100 schrieb Alexandre Belloni: > > On 23/01/2018 at 13:17:58 +0100, Michael Grzeschik wrote: > > > > > > From: Denis Osterland > > > > > > After successful > > > sr = isl1208_i2c_set_regs(client, 0,

Re: [PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits

2018-02-14 Thread Denis OSTERLAND
Am Mittwoch, den 14.02.2018, 21:26 +0100 schrieb Alexandre Belloni: > On 23/01/2018 at 13:17:58 +0100, Michael Grzeschik wrote: > > > > From: Denis Osterland > > > > After successful > > sr = isl1208_i2c_set_regs(client, 0, regs, ISL1208_RTC_SECTION_LEN); > > sr will

Re: [PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits

2018-02-14 Thread Denis OSTERLAND
Am Mittwoch, den 14.02.2018, 21:26 +0100 schrieb Alexandre Belloni: > On 23/01/2018 at 13:17:58 +0100, Michael Grzeschik wrote: > > > > From: Denis Osterland > > > > After successful > > sr = isl1208_i2c_set_regs(client, 0, regs, ISL1208_RTC_SECTION_LEN); > > sr will be 0. > > As a result > >

Re: [PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits

2018-02-14 Thread Alexandre Belloni
On 23/01/2018 at 13:17:58 +0100, Michael Grzeschik wrote: > From: Denis Osterland > > After successful > sr = isl1208_i2c_set_regs(client, 0, regs, ISL1208_RTC_SECTION_LEN); > sr will be 0. > As a result > sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR, >

Re: [PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits

2018-02-14 Thread Alexandre Belloni
On 23/01/2018 at 13:17:58 +0100, Michael Grzeschik wrote: > From: Denis Osterland > > After successful > sr = isl1208_i2c_set_regs(client, 0, regs, ISL1208_RTC_SECTION_LEN); > sr will be 0. > As a result > sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR, > sr &

[PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits

2018-01-23 Thread Michael Grzeschik
From: Denis Osterland After successful sr = isl1208_i2c_set_regs(client, 0, regs, ISL1208_RTC_SECTION_LEN); sr will be 0. As a result sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR, sr & ~ISL1208_REG_SR_WRTC); is equal to sr =

[PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits

2018-01-23 Thread Michael Grzeschik
From: Denis Osterland After successful sr = isl1208_i2c_set_regs(client, 0, regs, ISL1208_RTC_SECTION_LEN); sr will be 0. As a result sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR, sr & ~ISL1208_REG_SR_WRTC); is equal to sr = i2c_smbus_write_byte_data(client,