Re: [PATCH 1/4] sys: remove unnecesscary parameter of set_one_prio

2013-05-31 Thread Andrew Morton
On Thu, 30 May 2013 01:08:25 -0700 Joe Perches wrote: > On Thu, 2013-05-30 at 15:58 +0800, liguang wrote: > [] > > diff --git a/kernel/sys.c b/kernel/sys.c > [] > > -static int set_one_prio(struct task_struct *p, int niceval, int error) > > +static int set_one_prio(struct task_struct *p, int

Re: [PATCH 1/4] sys: remove unnecesscary parameter of set_one_prio

2013-05-31 Thread Andrew Morton
On Thu, 30 May 2013 15:58:03 +0800 liguang wrote: > Signed-off-by: liguang > --- > kernel/sys.c | 12 +--- > 1 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/kernel/sys.c b/kernel/sys.c > index b95d3c7..07c6177 100644 > --- a/kernel/sys.c > +++ b/kernel/sys.c > @@

Re: [PATCH 1/4] sys: remove unnecesscary parameter of set_one_prio

2013-05-31 Thread Andrew Morton
On Thu, 30 May 2013 15:58:03 +0800 liguang lig.f...@cn.fujitsu.com wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- kernel/sys.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/kernel/sys.c b/kernel/sys.c index b95d3c7..07c6177 100644 ---

Re: [PATCH 1/4] sys: remove unnecesscary parameter of set_one_prio

2013-05-31 Thread Andrew Morton
On Thu, 30 May 2013 01:08:25 -0700 Joe Perches j...@perches.com wrote: On Thu, 2013-05-30 at 15:58 +0800, liguang wrote: [] diff --git a/kernel/sys.c b/kernel/sys.c [] -static int set_one_prio(struct task_struct *p, int niceval, int error) +static int set_one_prio(struct task_struct *p,

Re: [PATCH 1/4] sys: remove unnecesscary parameter of set_one_prio

2013-05-30 Thread Joe Perches
On Thu, 2013-05-30 at 15:58 +0800, liguang wrote: [] > diff --git a/kernel/sys.c b/kernel/sys.c [] > -static int set_one_prio(struct task_struct *p, int niceval, int error) > +static int set_one_prio(struct task_struct *p, int niceval) Umm, error is forwarded through do_each loops. Are you sure

[PATCH 1/4] sys: remove unnecesscary parameter of set_one_prio

2013-05-30 Thread liguang
Signed-off-by: liguang --- kernel/sys.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/kernel/sys.c b/kernel/sys.c index b95d3c7..07c6177 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -151,9 +151,9 @@ static bool set_one_prio_perm(struct task_struct *p) *

[PATCH 1/4] sys: remove unnecesscary parameter of set_one_prio

2013-05-30 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- kernel/sys.c | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/kernel/sys.c b/kernel/sys.c index b95d3c7..07c6177 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -151,9 +151,9 @@ static bool

Re: [PATCH 1/4] sys: remove unnecesscary parameter of set_one_prio

2013-05-30 Thread Joe Perches
On Thu, 2013-05-30 at 15:58 +0800, liguang wrote: [] diff --git a/kernel/sys.c b/kernel/sys.c [] -static int set_one_prio(struct task_struct *p, int niceval, int error) +static int set_one_prio(struct task_struct *p, int niceval) Umm, error is forwarded through do_each loops. Are you sure you