Re: [PATCH 1/4] x86, build: Fact out fdimage/isoimage generation commands to standalone script

2017-11-05 Thread Du, Changbin
On Sun, Nov 05, 2017 at 10:32:08AM +0100, Ingo Molnar wrote: > > A few spelling fixes: > > in the title: > > s/Fact out > /Factor out > > * changbin...@intel.com wrote: > > > From: Changbin Du > > > > The build message for fdimage/isoimage are

Re: [PATCH 1/4] x86, build: Fact out fdimage/isoimage generation commands to standalone script

2017-11-05 Thread Du, Changbin
On Sun, Nov 05, 2017 at 10:32:08AM +0100, Ingo Molnar wrote: > > A few spelling fixes: > > in the title: > > s/Fact out > /Factor out > > * changbin...@intel.com wrote: > > > From: Changbin Du > > > > The build message for fdimage/isoimage are pretty unstructured. The raw > > shell

Re: [PATCH 1/4] x86, build: Fact out fdimage/isoimage generation commands to standalone script

2017-11-05 Thread Ingo Molnar
A few spelling fixes: in the title: s/Fact out /Factor out * changbin...@intel.com wrote: > From: Changbin Du > > The build message for fdimage/isoimage are pretty unstructured. The raw > shell command blocks are printed. We can improve them

Re: [PATCH 1/4] x86, build: Fact out fdimage/isoimage generation commands to standalone script

2017-11-05 Thread Ingo Molnar
A few spelling fixes: in the title: s/Fact out /Factor out * changbin...@intel.com wrote: > From: Changbin Du > > The build message for fdimage/isoimage are pretty unstructured. The raw > shell command blocks are printed. We can improve them as regular build > system messages. Besides,

[PATCH 1/4] x86, build: Fact out fdimage/isoimage generation commands to standalone script

2017-11-05 Thread changbin . du
From: Changbin Du The build message for fdimage/isoimage are pretty unstructured. The raw shell command blocks are printed. We can improve them as regular build system messages. Besides, writing commands in shell script is much more easier than in a Makefile. See Ingo's

[PATCH 1/4] x86, build: Fact out fdimage/isoimage generation commands to standalone script

2017-11-05 Thread changbin . du
From: Changbin Du The build message for fdimage/isoimage are pretty unstructured. The raw shell command blocks are printed. We can improve them as regular build system messages. Besides, writing commands in shell script is much more easier than in a Makefile. See Ingo's suggestion here