Re: [PATCH 1/4] x86/perf/intel: Introduce PMU flag for Extended PEBS

2018-07-23 Thread Peter Zijlstra
On Mon, Jul 23, 2018 at 11:43:56AM -0400, Liang, Kan wrote: > > So I like PEBS_ALL.. what I don't like is that it seems to be mutually > > exclusive with PEBS Load Latency. > > Right, MSR_PEBS_ENABLE:32-35 is model specific. Doesn't mean they couldn't have avoided conflicting bits. > For Atom,

Re: [PATCH 1/4] x86/perf/intel: Introduce PMU flag for Extended PEBS

2018-07-23 Thread Peter Zijlstra
On Mon, Jul 23, 2018 at 11:43:56AM -0400, Liang, Kan wrote: > > So I like PEBS_ALL.. what I don't like is that it seems to be mutually > > exclusive with PEBS Load Latency. > > Right, MSR_PEBS_ENABLE:32-35 is model specific. Doesn't mean they couldn't have avoided conflicting bits. > For Atom,

Re: [PATCH 1/4] x86/perf/intel: Introduce PMU flag for Extended PEBS

2018-07-23 Thread Liang, Kan
On 7/23/2018 11:16 AM, Peter Zijlstra wrote: On Thu, Mar 08, 2018 at 06:15:39PM -0800, kan.li...@linux.intel.com wrote: From: Kan Liang The Extended PEBS feature, introduced in Goldmont Plus microarchitecture, supports all events as "Extended PEBS". Introduce flag PMU_FL_PEBS_ALL to

Re: [PATCH 1/4] x86/perf/intel: Introduce PMU flag for Extended PEBS

2018-07-23 Thread Liang, Kan
On 7/23/2018 11:16 AM, Peter Zijlstra wrote: On Thu, Mar 08, 2018 at 06:15:39PM -0800, kan.li...@linux.intel.com wrote: From: Kan Liang The Extended PEBS feature, introduced in Goldmont Plus microarchitecture, supports all events as "Extended PEBS". Introduce flag PMU_FL_PEBS_ALL to

Re: [PATCH 1/4] x86/perf/intel: Introduce PMU flag for Extended PEBS

2018-07-23 Thread Peter Zijlstra
On Thu, Mar 08, 2018 at 06:15:39PM -0800, kan.li...@linux.intel.com wrote: > From: Kan Liang > > The Extended PEBS feature, introduced in Goldmont Plus > microarchitecture, supports all events as "Extended PEBS". > > Introduce flag PMU_FL_PEBS_ALL to indicate the platforms which support >

Re: [PATCH 1/4] x86/perf/intel: Introduce PMU flag for Extended PEBS

2018-07-23 Thread Peter Zijlstra
On Thu, Mar 08, 2018 at 06:15:39PM -0800, kan.li...@linux.intel.com wrote: > From: Kan Liang > > The Extended PEBS feature, introduced in Goldmont Plus > microarchitecture, supports all events as "Extended PEBS". > > Introduce flag PMU_FL_PEBS_ALL to indicate the platforms which support >

[PATCH 1/4] x86/perf/intel: Introduce PMU flag for Extended PEBS

2018-03-08 Thread kan . liang
From: Kan Liang The Extended PEBS feature, introduced in Goldmont Plus microarchitecture, supports all events as "Extended PEBS". Introduce flag PMU_FL_PEBS_ALL to indicate the platforms which support extended PEBS. To support all events, it needs to support all

[PATCH 1/4] x86/perf/intel: Introduce PMU flag for Extended PEBS

2018-03-08 Thread kan . liang
From: Kan Liang The Extended PEBS feature, introduced in Goldmont Plus microarchitecture, supports all events as "Extended PEBS". Introduce flag PMU_FL_PEBS_ALL to indicate the platforms which support extended PEBS. To support all events, it needs to support all constraints for PEBS. To avoid