Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro

2020-09-19 Thread hpa
On September 19, 2020 9:23:22 AM PDT, Andy Lutomirski wrote: >On Fri, Sep 18, 2020 at 10:35 PM Christoph Hellwig >wrote: >> >> On Fri, Sep 18, 2020 at 03:24:36PM +0200, Arnd Bergmann wrote: >> > sys_move_pages() is an optional syscall, and once we remove >> > the compat version of it in favor of

Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro

2020-09-19 Thread Brian Gerst
An alternative to the patch I proposed earlier would be to use aliases with the __x32_ prefix for the common syscalls. -- Brian Gerst On Sat, Sep 19, 2020 at 1:14 PM wrote: > > On September 19, 2020 9:23:22 AM PDT, Andy Lutomirski wrote: > >On Fri, Sep 18, 2020 at 10:35 PM Christoph Hellwig >

Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro

2020-09-19 Thread Andy Lutomirski
> On Sep 19, 2020, at 10:14 AM, h...@zytor.com wrote: > > On September 19, 2020 9:23:22 AM PDT, Andy Lutomirski > wrote: >>> On Fri, Sep 18, 2020 at 10:35 PM Christoph Hellwig >>> wrote: >>> >>> On Fri, Sep 18, 2020 at 03:24:36PM +0200, Arnd Bergmann wrote: sys_move_pages() is an

Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro

2020-09-19 Thread Andy Lutomirski
On Fri, Sep 18, 2020 at 10:35 PM Christoph Hellwig wrote: > > On Fri, Sep 18, 2020 at 03:24:36PM +0200, Arnd Bergmann wrote: > > sys_move_pages() is an optional syscall, and once we remove > > the compat version of it in favor of the native one with an > > in_compat_syscall() check, the x32

Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro

2020-09-18 Thread Christoph Hellwig
On Fri, Sep 18, 2020 at 03:24:36PM +0200, Arnd Bergmann wrote: > sys_move_pages() is an optional syscall, and once we remove > the compat version of it in favor of the native one with an > in_compat_syscall() check, the x32 syscall table refers to > a __x32_sys_move_pages symbol that may not exist

[PATCH 1/4] x86: add __X32_COND_SYSCALL() macro

2020-09-18 Thread Arnd Bergmann
sys_move_pages() is an optional syscall, and once we remove the compat version of it in favor of the native one with an in_compat_syscall() check, the x32 syscall table refers to a __x32_sys_move_pages symbol that may not exist when the syscall is disabled. Change the COND_SYSCALL() definition on