Re: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, Andrew. 2015-03-20 10:17 GMT+09:00 Joseph Qi : > Hi Andrew, > > On 2015/3/20 6:23, Andrew Morton wrote: >> On Sat, 28 Feb 2015 08:48:40 +0900 Daeseok Youn >> wrote: >> >>> The use of 'status' in __ocfs2_add_entry() can return wrong >>> status when some functions are failed. >>> >>> If

Re: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, Andrew. 2015-03-20 10:17 GMT+09:00 Joseph Qi joseph...@huawei.com: Hi Andrew, On 2015/3/20 6:23, Andrew Morton wrote: On Sat, 28 Feb 2015 08:48:40 +0900 Daeseok Youn daeseok.y...@gmail.com wrote: The use of 'status' in __ocfs2_add_entry() can return wrong status when some functions

Re: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

2015-03-19 15:24 GMT+09:00 Joseph Qi : > Looks good to me. > > On 2015/2/28 7:48, Daeseok Youn wrote: >> The use of 'status' in __ocfs2_add_entry() can return wrong >> status when some functions are failed. >> >> If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, >> that status is

Re: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi Andrew, On 2015/3/20 6:23, Andrew Morton wrote: > On Sat, 28 Feb 2015 08:48:40 +0900 Daeseok Youn > wrote: > >> The use of 'status' in __ocfs2_add_entry() can return wrong >> status when some functions are failed. >> >> If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, >> that

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

On Sat, 28 Feb 2015 08:48:40 +0900 Daeseok Youn wrote: > The use of 'status' in __ocfs2_add_entry() can return wrong > status when some functions are failed. > > If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, > that status is saved to 'status' but return variable is 'retval' >

Re: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Looks good to me. On 2015/2/28 7:48, Daeseok Youn wrote: > The use of 'status' in __ocfs2_add_entry() can return wrong > status when some functions are failed. > > If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, > that status is saved to 'status' but return variable is 'retval' >

Re: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Looks good to me. On 2015/2/28 7:48, Daeseok Youn wrote: The use of 'status' in __ocfs2_add_entry() can return wrong status when some functions are failed. If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, that status is saved to 'status' but return variable is 'retval' which

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

On Sat, 28 Feb 2015 08:48:40 +0900 Daeseok Youn daeseok.y...@gmail.com wrote: The use of 'status' in __ocfs2_add_entry() can return wrong status when some functions are failed. If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, that status is saved to 'status' but return

Re: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

2015-03-19 15:24 GMT+09:00 Joseph Qi joseph...@huawei.com: Looks good to me. On 2015/2/28 7:48, Daeseok Youn wrote: The use of 'status' in __ocfs2_add_entry() can return wrong status when some functions are failed. If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, that status

Re: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi Andrew, On 2015/3/20 6:23, Andrew Morton wrote: On Sat, 28 Feb 2015 08:48:40 +0900 Daeseok Youn daeseok.y...@gmail.com wrote: The use of 'status' in __ocfs2_add_entry() can return wrong status when some functions are failed. If ocfs2_journal_access_db() in __ocfs2_add_entry() is

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Am 13.03.2015 um 04:59 schrieb DaeSeok Youn: > Hi, > > This patch have been pending for 2 weeks. > Do I need to check other things? > > please, check for me. I cannot speak for OCFS2 folks. But maybe you can give them a better feeling if you proof that your patch is tested. Thanks, //richard

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Am 13.03.2015 um 04:59 schrieb DaeSeok Youn: Hi, This patch have been pending for 2 weeks. Do I need to check other things? please, check for me. I cannot speak for OCFS2 folks. But maybe you can give them a better feeling if you proof that your patch is tested. Thanks, //richard

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, This patch have been pending for 2 weeks. Do I need to check other things? please, check for me. Thanks! regards, Daeseok Youn 2015-02-28 8:48 GMT+09:00 Daeseok Youn : > The use of 'status' in __ocfs2_add_entry() can return wrong > status when some functions are failed. > > If

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, This patch have been pending for 2 weeks. Do I need to check other things? please, check for me. Thanks! regards, Daeseok Youn 2015-02-28 8:48 GMT+09:00 Daeseok Youn daeseok.y...@gmail.com: The use of 'status' in __ocfs2_add_entry() can return wrong status when some functions are

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, How is this patch going on? please check for me. Thanks. Daeseok Youn. 2015-03-03 10:38 GMT+09:00 DaeSeok Youn : > Hi, all > > please, review this patch. > > thanks. > > regards, > Daeseok Youn. > > 2015-03-02 18:04 GMT+09:00 Richard Weinberger : >> Am 28.02.2015 um 00:48 schrieb Daeseok

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, How is this patch going on? please check for me. Thanks. Daeseok Youn. 2015-03-03 10:38 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com: Hi, all please, review this patch. thanks. regards, Daeseok Youn. 2015-03-02 18:04 GMT+09:00 Richard Weinberger rich...@nod.at: Am 28.02.2015 um

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, all please, review this patch. thanks. regards, Daeseok Youn. 2015-03-02 18:04 GMT+09:00 Richard Weinberger : > Am 28.02.2015 um 00:48 schrieb Daeseok Youn: >> The use of 'status' in __ocfs2_add_entry() can return wrong >> status when some functions are failed. >> >> If

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Am 28.02.2015 um 00:48 schrieb Daeseok Youn: > The use of 'status' in __ocfs2_add_entry() can return wrong > status when some functions are failed. > > If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, > that status is saved to 'status' but return variable is 'retval' > which is

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, all please, review this patch. thanks. regards, Daeseok Youn. 2015-03-02 18:04 GMT+09:00 Richard Weinberger rich...@nod.at: Am 28.02.2015 um 00:48 schrieb Daeseok Youn: The use of 'status' in __ocfs2_add_entry() can return wrong status when some functions are failed. If

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Am 28.02.2015 um 00:48 schrieb Daeseok Youn: The use of 'status' in __ocfs2_add_entry() can return wrong status when some functions are failed. If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, that status is saved to 'status' but return variable is 'retval' which is saved

[PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

The use of 'status' in __ocfs2_add_entry() can return wrong status when some functions are failed. If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, that status is saved to 'status' but return variable is 'retval' which is saved 'success' status. In case of this, __ocfs2_add_entry()

[PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

The use of 'status' in __ocfs2_add_entry() can return wrong status when some functions are failed. If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, that status is saved to 'status' but return variable is 'retval' which is saved 'success' status. In case of this, __ocfs2_add_entry()