[PATCH 1/5] Use wake_up_locked() in eventpoll
Replace the uses of __wake_up_locked with wake_up_locked Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> --- fs/eventpoll.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 34f68f3..81c04ab 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -656,8 +656,7 @@ is_linked: * wait list. */ if (waitqueue_active(>wq)) - __wake_up_locked(>wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(>wq); if (waitqueue_active(>poll_wait)) pwake++; @@ -780,7 +779,7 @@ static int ep_insert(struct eventpoll *ep, struct epoll_event *event, /* Notify waiting tasks that events are available */ if (waitqueue_active(>wq)) - __wake_up_locked(>wq, TASK_UNINTERRUPTIBLE | TASK_INTERRUPTIBLE); + wake_up_locked(>wq); if (waitqueue_active(>poll_wait)) pwake++; } @@ -854,8 +853,7 @@ static int ep_modify(struct eventpoll *ep, struct epitem *epi, struct epoll_even /* Notify waiting tasks that events are available */ if (waitqueue_active(>wq)) - __wake_up_locked(>wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(>wq); if (waitqueue_active(>poll_wait)) pwake++; } @@ -978,8 +976,7 @@ errxit: * wait list (delayed after we release the lock). */ if (waitqueue_active(>wq)) - __wake_up_locked(>wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(>wq); if (waitqueue_active(>poll_wait)) pwake++; } -- 1.4.4.2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/5] Use wake_up_locked() in eventpoll
Replace the uses of __wake_up_locked with wake_up_locked Signed-off-by: Matthew Wilcox [EMAIL PROTECTED] --- fs/eventpoll.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 34f68f3..81c04ab 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -656,8 +656,7 @@ is_linked: * wait list. */ if (waitqueue_active(ep-wq)) - __wake_up_locked(ep-wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(ep-wq); if (waitqueue_active(ep-poll_wait)) pwake++; @@ -780,7 +779,7 @@ static int ep_insert(struct eventpoll *ep, struct epoll_event *event, /* Notify waiting tasks that events are available */ if (waitqueue_active(ep-wq)) - __wake_up_locked(ep-wq, TASK_UNINTERRUPTIBLE | TASK_INTERRUPTIBLE); + wake_up_locked(ep-wq); if (waitqueue_active(ep-poll_wait)) pwake++; } @@ -854,8 +853,7 @@ static int ep_modify(struct eventpoll *ep, struct epitem *epi, struct epoll_even /* Notify waiting tasks that events are available */ if (waitqueue_active(ep-wq)) - __wake_up_locked(ep-wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(ep-wq); if (waitqueue_active(ep-poll_wait)) pwake++; } @@ -978,8 +976,7 @@ errxit: * wait list (delayed after we release the lock). */ if (waitqueue_active(ep-wq)) - __wake_up_locked(ep-wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(ep-wq); if (waitqueue_active(ep-poll_wait)) pwake++; } -- 1.4.4.2 - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] Use wake_up_locked() in eventpoll
On Thu, Oct 18, 2007 at 08:56:23PM -0700, Arjan van de Ven wrote: > Have you tested this patch with LOCKDEP enabled? eventpoll is... tricky > in what it does with waitqueues and locks and some of this stuff is > there, afaik, to deal with that. You're now changing this ... call me > chicken :) I haven't tested it, but it's a simple textual substitution: #define wake_up_locked(x) __wake_up_locked((x), TASK_UNINTERRUPTIBLE | TASK_INTERRUPTIBLE) so it should be identical in effect. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] Use wake_up_locked() in eventpoll
On Thu, Oct 18, 2007 at 08:56:23PM -0700, Arjan van de Ven wrote: Have you tested this patch with LOCKDEP enabled? eventpoll is... tricky in what it does with waitqueues and locks and some of this stuff is there, afaik, to deal with that. You're now changing this ... call me chicken :) I haven't tested it, but it's a simple textual substitution: #define wake_up_locked(x) __wake_up_locked((x), TASK_UNINTERRUPTIBLE | TASK_INTERRUPTIBLE) so it should be identical in effect. -- Intel are signing my paycheques ... these opinions are still mine Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] Use wake_up_locked() in eventpoll
On Thu, 18 Oct 2007 18:25:58 -0400 Matthew Wilcox <[EMAIL PROTECTED]> wrote: Have you tested this patch with LOCKDEP enabled? eventpoll is... tricky in what it does with waitqueues and locks and some of this stuff is there, afaik, to deal with that. You're now changing this ... call me chicken :) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/5] Use wake_up_locked() in eventpoll
Replace the uses of __wake_up_locked with wake_up_locked Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> --- fs/eventpoll.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 77b9953..72e4cb4 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -657,8 +657,7 @@ is_linked: * wait list. */ if (waitqueue_active(>wq)) - __wake_up_locked(>wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(>wq); if (waitqueue_active(>poll_wait)) pwake++; @@ -781,7 +780,7 @@ static int ep_insert(struct eventpoll *ep, struct epoll_event *event, /* Notify waiting tasks that events are available */ if (waitqueue_active(>wq)) - __wake_up_locked(>wq, TASK_UNINTERRUPTIBLE | TASK_INTERRUPTIBLE); + wake_up_locked(>wq); if (waitqueue_active(>poll_wait)) pwake++; } @@ -855,8 +854,7 @@ static int ep_modify(struct eventpoll *ep, struct epitem *epi, struct epoll_even /* Notify waiting tasks that events are available */ if (waitqueue_active(>wq)) - __wake_up_locked(>wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(>wq); if (waitqueue_active(>poll_wait)) pwake++; } @@ -979,8 +977,7 @@ errxit: * wait list (delayed after we release the lock). */ if (waitqueue_active(>wq)) - __wake_up_locked(>wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(>wq); if (waitqueue_active(>poll_wait)) pwake++; } -- 1.4.4.2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/5] Use wake_up_locked() in eventpoll
On Thu, 18 Oct 2007 18:25:58 -0400 Matthew Wilcox [EMAIL PROTECTED] wrote: Have you tested this patch with LOCKDEP enabled? eventpoll is... tricky in what it does with waitqueues and locks and some of this stuff is there, afaik, to deal with that. You're now changing this ... call me chicken :) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/5] Use wake_up_locked() in eventpoll
Replace the uses of __wake_up_locked with wake_up_locked Signed-off-by: Matthew Wilcox [EMAIL PROTECTED] --- fs/eventpoll.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 77b9953..72e4cb4 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -657,8 +657,7 @@ is_linked: * wait list. */ if (waitqueue_active(ep-wq)) - __wake_up_locked(ep-wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(ep-wq); if (waitqueue_active(ep-poll_wait)) pwake++; @@ -781,7 +780,7 @@ static int ep_insert(struct eventpoll *ep, struct epoll_event *event, /* Notify waiting tasks that events are available */ if (waitqueue_active(ep-wq)) - __wake_up_locked(ep-wq, TASK_UNINTERRUPTIBLE | TASK_INTERRUPTIBLE); + wake_up_locked(ep-wq); if (waitqueue_active(ep-poll_wait)) pwake++; } @@ -855,8 +854,7 @@ static int ep_modify(struct eventpoll *ep, struct epitem *epi, struct epoll_even /* Notify waiting tasks that events are available */ if (waitqueue_active(ep-wq)) - __wake_up_locked(ep-wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(ep-wq); if (waitqueue_active(ep-poll_wait)) pwake++; } @@ -979,8 +977,7 @@ errxit: * wait list (delayed after we release the lock). */ if (waitqueue_active(ep-wq)) - __wake_up_locked(ep-wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(ep-wq); if (waitqueue_active(ep-poll_wait)) pwake++; } -- 1.4.4.2 - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/5] Use wake_up_locked() in eventpoll
Replace the uses of __wake_up_locked with wake_up_locked Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> --- fs/eventpoll.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 77b9953..72e4cb4 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -657,8 +657,7 @@ is_linked: * wait list. */ if (waitqueue_active(>wq)) - __wake_up_locked(>wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(>wq); if (waitqueue_active(>poll_wait)) pwake++; @@ -781,7 +780,7 @@ static int ep_insert(struct eventpoll *ep, struct epoll_event *event, /* Notify waiting tasks that events are available */ if (waitqueue_active(>wq)) - __wake_up_locked(>wq, TASK_UNINTERRUPTIBLE | TASK_INTERRUPTIBLE); + wake_up_locked(>wq); if (waitqueue_active(>poll_wait)) pwake++; } @@ -855,8 +854,7 @@ static int ep_modify(struct eventpoll *ep, struct epitem *epi, struct epoll_even /* Notify waiting tasks that events are available */ if (waitqueue_active(>wq)) - __wake_up_locked(>wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(>wq); if (waitqueue_active(>poll_wait)) pwake++; } @@ -979,8 +977,7 @@ errxit: * wait list (delayed after we release the lock). */ if (waitqueue_active(>wq)) - __wake_up_locked(>wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(>wq); if (waitqueue_active(>poll_wait)) pwake++; } -- 1.4.4.2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/5] Use wake_up_locked() in eventpoll
Replace the uses of __wake_up_locked with wake_up_locked Signed-off-by: Matthew Wilcox [EMAIL PROTECTED] --- fs/eventpoll.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 77b9953..72e4cb4 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -657,8 +657,7 @@ is_linked: * wait list. */ if (waitqueue_active(ep-wq)) - __wake_up_locked(ep-wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(ep-wq); if (waitqueue_active(ep-poll_wait)) pwake++; @@ -781,7 +780,7 @@ static int ep_insert(struct eventpoll *ep, struct epoll_event *event, /* Notify waiting tasks that events are available */ if (waitqueue_active(ep-wq)) - __wake_up_locked(ep-wq, TASK_UNINTERRUPTIBLE | TASK_INTERRUPTIBLE); + wake_up_locked(ep-wq); if (waitqueue_active(ep-poll_wait)) pwake++; } @@ -855,8 +854,7 @@ static int ep_modify(struct eventpoll *ep, struct epitem *epi, struct epoll_even /* Notify waiting tasks that events are available */ if (waitqueue_active(ep-wq)) - __wake_up_locked(ep-wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(ep-wq); if (waitqueue_active(ep-poll_wait)) pwake++; } @@ -979,8 +977,7 @@ errxit: * wait list (delayed after we release the lock). */ if (waitqueue_active(ep-wq)) - __wake_up_locked(ep-wq, TASK_UNINTERRUPTIBLE | -TASK_INTERRUPTIBLE); + wake_up_locked(ep-wq); if (waitqueue_active(ep-poll_wait)) pwake++; } -- 1.4.4.2 - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
