Re: [PATCH 1/5] mfd:rtsx: Read vendor setting from config space

This code has a lot of undocumented magic flags and terrible naming in it. > +static void rtl8411_init_settings(struct rtsx_pcr *pcr) > +{ > + u32 val1; > + u8 val2; These names are 100% useless. "val" means nothing. "1" means nothing. "2" means nothing. In fact, val1 is REG1 and

[PATCH 1/5] mfd:rtsx: Read vendor setting from config space

From: Wei WANG Normally OEMs will set vendor setting to the config space of Realtek card reader in BIOS stage. This patch reads the setting at the first, and configure the internal registers according to it, to improve card reader's compatibility condition. Signed-off-by: Wei WANG ---

[PATCH 1/5] mfd:rtsx: Read vendor setting from config space

From: Wei WANG wei_w...@realsil.com.cn Normally OEMs will set vendor setting to the config space of Realtek card reader in BIOS stage. This patch reads the setting at the first, and configure the internal registers according to it, to improve card reader's compatibility condition. Signed-off-by:

Re: [PATCH 1/5] mfd:rtsx: Read vendor setting from config space

This code has a lot of undocumented magic flags and terrible naming in it. +static void rtl8411_init_settings(struct rtsx_pcr *pcr) +{ + u32 val1; + u8 val2; These names are 100% useless. val means nothing. 1 means nothing. 2 means nothing. In fact, val1 is REG1 and val2 is REG3