Re: [PATCH 1/5] perf session: Get rid of file_size variable

2018-12-27 Thread Jiri Olsa
On Wed, Dec 26, 2018 at 04:43:42PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 26, 2018 at 02:51:28PM +0100, Jiri Olsa escreveu: > > It's not needed and removing it makes the code little > > more simple for upcoming changes. > > > > It's safe to replace file_size with data_size, because

Re: [PATCH 1/5] perf session: Get rid of file_size variable

2018-12-26 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 26, 2018 at 02:51:28PM +0100, Jiri Olsa escreveu: > It's not needed and removing it makes the code little > more simple for upcoming changes. > > It's safe to replace file_size with data_size, because > perf_data__size value is never smaller than data_offset > + data_size. This is

[PATCH 1/5] perf session: Get rid of file_size variable

2018-12-26 Thread Jiri Olsa
It's not needed and removing it makes the code little more simple for upcoming changes. It's safe to replace file_size with data_size, because perf_data__size value is never smaller than data_offset + data_size. Link: http://lkml.kernel.org/n/tip-ocz7zwwkkx11v0mkxrtcd...@git.kernel.org