Re: [PATCH 1/5] pinctrl: at91-pio4: add missing of_node_put

2018-05-24 Thread Linus Walleij
On Wed, May 23, 2018 at 9:07 PM, Julia Lawall wrote: > The device node iterators perform an of_node_get on each iteration, so a > jump out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > //

Re: [PATCH 1/5] pinctrl: at91-pio4: add missing of_node_put

2018-05-24 Thread Ludovic Desroches
On Wed, May 23, 2018 at 09:07:12PM +0200, Julia Lawall wrote: > The device node iterators perform an of_node_get on each iteration, so a > jump out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ >

[PATCH 1/5] pinctrl: at91-pio4: add missing of_node_put

2018-05-23 Thread Julia Lawall
The device node iterators perform an of_node_get on each iteration, so a jump out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; iterator name for_each_child_of_node;