Re: [PATCH 1/5] pinctrl: at91-pio4: add missing of_node_put

[Linus Walleij]

On Wed, May 23, 2018 at 9:07 PM, Julia Lawall  wrote:

> The device node iterators perform an of_node_get on each iteration, so a
> jump out of the loop requires an of_node_put.
>
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
>
> // 
> @@
> expression root,e;
> local idexpression child;
> iterator name for_each_child_of_node;
> @@
>
>  for_each_child_of_node(root, child) {
>... when != of_node_put(child)
>when != e = child
> +  of_node_put(child);
> ?  break;
>...
> }
> ... when != child
> // 
>
> Signed-off-by: Julia Lawall 

Patch applied with Ludovic's ACK!

Yours,
Linus Walleij

Re: [PATCH 1/5] pinctrl: at91-pio4: add missing of_node_put

[Linus Walleij]

On Wed, May 23, 2018 at 9:07 PM, Julia Lawall  wrote:

> The device node iterators perform an of_node_get on each iteration, so a
> jump out of the loop requires an of_node_put.
>
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
>
> // 
> @@
> expression root,e;
> local idexpression child;
> iterator name for_each_child_of_node;
> @@
>
>  for_each_child_of_node(root, child) {
>... when != of_node_put(child)
>when != e = child
> +  of_node_put(child);
> ?  break;
>...
> }
> ... when != child
> // 
>
> Signed-off-by: Julia Lawall 

Patch applied with Ludovic's ACK!

Yours,
Linus Walleij

Re: [PATCH 1/5] pinctrl: at91-pio4: add missing of_node_put

[Ludovic Desroches]

On Wed, May 23, 2018 at 09:07:12PM +0200, Julia Lawall wrote:
> The device node iterators perform an of_node_get on each iteration, so a
> jump out of the loop requires an of_node_put.
> 
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
> 
> // 
> @@
> expression root,e;
> local idexpression child;
> iterator name for_each_child_of_node;
> @@
> 
>  for_each_child_of_node(root, child) {
>... when != of_node_put(child)
>when != e = child
> +  of_node_put(child);
> ?  break;
>...
> }
> ... when != child
> // 
> 
> Signed-off-by: Julia Lawall 
Acked-by: Ludovic Desroches 

Thanks
> 
> ---
>  drivers/pinctrl/pinctrl-at91-pio4.c |4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c 
> b/drivers/pinctrl/pinctrl-at91-pio4.c
> index 4b57a13..bafb3d4 100644
> --- a/drivers/pinctrl/pinctrl-at91-pio4.c
> +++ b/drivers/pinctrl/pinctrl-at91-pio4.c
> @@ -576,8 +576,10 @@ static int atmel_pctl_dt_node_to_map(struct pinctrl_dev 
> *pctldev,
>   for_each_child_of_node(np_config, np) {
>   ret = atmel_pctl_dt_subnode_to_map(pctldev, np, map,
>   _maps, num_maps);
> - if (ret < 0)
> + if (ret < 0) {
> + of_node_put(np);
>   break;
> + }
>   }
>   }
>  
> 

Re: [PATCH 1/5] pinctrl: at91-pio4: add missing of_node_put

[Ludovic Desroches]

On Wed, May 23, 2018 at 09:07:12PM +0200, Julia Lawall wrote:
> The device node iterators perform an of_node_get on each iteration, so a
> jump out of the loop requires an of_node_put.
> 
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
> 
> // 
> @@
> expression root,e;
> local idexpression child;
> iterator name for_each_child_of_node;
> @@
> 
>  for_each_child_of_node(root, child) {
>... when != of_node_put(child)
>when != e = child
> +  of_node_put(child);
> ?  break;
>...
> }
> ... when != child
> // 
> 
> Signed-off-by: Julia Lawall 
Acked-by: Ludovic Desroches 

Thanks
> 
> ---
>  drivers/pinctrl/pinctrl-at91-pio4.c |4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c 
> b/drivers/pinctrl/pinctrl-at91-pio4.c
> index 4b57a13..bafb3d4 100644
> --- a/drivers/pinctrl/pinctrl-at91-pio4.c
> +++ b/drivers/pinctrl/pinctrl-at91-pio4.c
> @@ -576,8 +576,10 @@ static int atmel_pctl_dt_node_to_map(struct pinctrl_dev 
> *pctldev,
>   for_each_child_of_node(np_config, np) {
>   ret = atmel_pctl_dt_subnode_to_map(pctldev, np, map,
>   _maps, num_maps);
> - if (ret < 0)
> + if (ret < 0) {
> + of_node_put(np);
>   break;
> + }
>   }
>   }
>  
> 

[PATCH 1/5] pinctrl: at91-pio4: add missing of_node_put

[Julia Lawall]

The device node iterators perform an of_node_get on each iteration, so a
jump out of the loop requires an of_node_put.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// 
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
   when != e = child
+  of_node_put(child);
?  break;
   ...
}
... when != child
// 

Signed-off-by: Julia Lawall 

---
 drivers/pinctrl/pinctrl-at91-pio4.c |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c 
b/drivers/pinctrl/pinctrl-at91-pio4.c
index 4b57a13..bafb3d4 100644
--- a/drivers/pinctrl/pinctrl-at91-pio4.c
+++ b/drivers/pinctrl/pinctrl-at91-pio4.c
@@ -576,8 +576,10 @@ static int atmel_pctl_dt_node_to_map(struct pinctrl_dev 
*pctldev,
for_each_child_of_node(np_config, np) {
ret = atmel_pctl_dt_subnode_to_map(pctldev, np, map,
_maps, num_maps);
-   if (ret < 0)
+   if (ret < 0) {
+   of_node_put(np);
break;
+   }
}
}
 

[PATCH 1/5] pinctrl: at91-pio4: add missing of_node_put

[Julia Lawall]

The device node iterators perform an of_node_get on each iteration, so a
jump out of the loop requires an of_node_put.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// 
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
   when != e = child
+  of_node_put(child);
?  break;
   ...
}
... when != child
// 

Signed-off-by: Julia Lawall 

---
 drivers/pinctrl/pinctrl-at91-pio4.c |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c 
b/drivers/pinctrl/pinctrl-at91-pio4.c
index 4b57a13..bafb3d4 100644
--- a/drivers/pinctrl/pinctrl-at91-pio4.c
+++ b/drivers/pinctrl/pinctrl-at91-pio4.c
@@ -576,8 +576,10 @@ static int atmel_pctl_dt_node_to_map(struct pinctrl_dev 
*pctldev,
for_each_child_of_node(np_config, np) {
ret = atmel_pctl_dt_subnode_to_map(pctldev, np, map,
_maps, num_maps);
-   if (ret < 0)
+   if (ret < 0) {
+   of_node_put(np);
break;
+   }
}
}