> >> And the masking with ~PAGE_MASK is not pointless in any case.
> >
> > Good point. In which might as well make the 'struct seg_buf' be an
> > simple array of unsigned int.
>
> I didn't do this because later on (when using indirect segments) I need
> a place to store the offset, since I don't
On 19/03/13 16:10, Konrad Rzeszutek Wilk wrote:
> On Tue, Mar 19, 2013 at 02:55:56PM +, Jan Beulich wrote:
> On 19.03.13 at 15:32, Konrad Rzeszutek Wilk
> wrote:
>>> On Mon, Mar 18, 2013 at 05:49:32PM +0100, Roger Pau Monne wrote:
dev_bus_addr returned in the grant ref map
>>> On 19.03.13 at 16:10, Konrad Rzeszutek Wilk wrote:
> On Tue, Mar 19, 2013 at 02:55:56PM +, Jan Beulich wrote:
>> >>> On 19.03.13 at 15:32, Konrad Rzeszutek Wilk
>> >>> wrote:
>> > @@ -971,7 +962,7 @@ static int dispatch_rw_block_io(struct xen_blkif
>> > *blkif,
>> >
On Tue, Mar 19, 2013 at 02:55:56PM +, Jan Beulich wrote:
> >>> On 19.03.13 at 15:32, Konrad Rzeszutek Wilk
> >>> wrote:
> > On Mon, Mar 18, 2013 at 05:49:32PM +0100, Roger Pau Monne wrote:
> >> dev_bus_addr returned in the grant ref map operation is the mfn of the
> >> passed page, there's
>>> On 19.03.13 at 15:32, Konrad Rzeszutek Wilk wrote:
> On Mon, Mar 18, 2013 at 05:49:32PM +0100, Roger Pau Monne wrote:
>> dev_bus_addr returned in the grant ref map operation is the mfn of the
>> passed page, there's no need to store it in the persistent grant
>> entry, since we can always get
On Mon, Mar 18, 2013 at 05:49:32PM +0100, Roger Pau Monne wrote:
> dev_bus_addr returned in the grant ref map operation is the mfn of the
> passed page, there's no need to store it in the persistent grant
> entry, since we can always get it provided that we have the page.
>
> This reduces the
On Mon, Mar 18, 2013 at 05:49:32PM +0100, Roger Pau Monne wrote:
dev_bus_addr returned in the grant ref map operation is the mfn of the
passed page, there's no need to store it in the persistent grant
entry, since we can always get it provided that we have the page.
This reduces the memory
On 19.03.13 at 15:32, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote:
On Mon, Mar 18, 2013 at 05:49:32PM +0100, Roger Pau Monne wrote:
dev_bus_addr returned in the grant ref map operation is the mfn of the
passed page, there's no need to store it in the persistent grant
entry, since we
On Tue, Mar 19, 2013 at 02:55:56PM +, Jan Beulich wrote:
On 19.03.13 at 15:32, Konrad Rzeszutek Wilk konrad.w...@oracle.com
wrote:
On Mon, Mar 18, 2013 at 05:49:32PM +0100, Roger Pau Monne wrote:
dev_bus_addr returned in the grant ref map operation is the mfn of the
passed page,
On 19.03.13 at 16:10, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote:
On Tue, Mar 19, 2013 at 02:55:56PM +, Jan Beulich wrote:
On 19.03.13 at 15:32, Konrad Rzeszutek Wilk konrad.w...@oracle.com
wrote:
@@ -971,7 +962,7 @@ static int dispatch_rw_block_io(struct xen_blkif
*blkif,
On 19/03/13 16:10, Konrad Rzeszutek Wilk wrote:
On Tue, Mar 19, 2013 at 02:55:56PM +, Jan Beulich wrote:
On 19.03.13 at 15:32, Konrad Rzeszutek Wilk konrad.w...@oracle.com
wrote:
On Mon, Mar 18, 2013 at 05:49:32PM +0100, Roger Pau Monne wrote:
dev_bus_addr returned in the grant ref map
And the masking with ~PAGE_MASK is not pointless in any case.
Good point. In which might as well make the 'struct seg_buf' be an
simple array of unsigned int.
I didn't do this because later on (when using indirect segments) I need
a place to store the offset, since I don't have the
dev_bus_addr returned in the grant ref map operation is the mfn of the
passed page, there's no need to store it in the persistent grant
entry, since we can always get it provided that we have the page.
This reduces the memory overhead of persistent grants in blkback.
Signed-off-by: Roger Pau
dev_bus_addr returned in the grant ref map operation is the mfn of the
passed page, there's no need to store it in the persistent grant
entry, since we can always get it provided that we have the page.
This reduces the memory overhead of persistent grants in blkback.
Signed-off-by: Roger Pau
14 matches
Mail list logo
