Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-10 Thread Linus Walleij
(As for the thread, which got flamy, let's put it to rest, and Ola: we are all impressed with your work on the ux500 ALSA SoC driver, no doubt about that, this was all ever about the DT patch set.) On Thu, Aug 2, 2012 at 7:58 AM, Ola Lilja wrote: > Linus W. could probably shed some light of

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-10 Thread Linus Walleij
(As for the thread, which got flamy, let's put it to rest, and Ola: we are all impressed with your work on the ux500 ALSA SoC driver, no doubt about that, this was all ever about the DT patch set.) On Thu, Aug 2, 2012 at 7:58 AM, Ola Lilja olali...@yahoo.se wrote: Linus W. could probably

Re: [alsa-devel] [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-03 Thread Mark Brown
On Fri, Aug 03, 2012 at 09:30:10AM +0100, Lee Jones wrote: > I do agree that it should be correct, but the difference between getting > it 90% correct and absolutely perfect increases the effort at least x2. > With so much left to do, I think it would be better to get everything in > and

Re: [alsa-devel] [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-03 Thread Lee Jones
On Thu, Aug 02, 2012 at 06:56:04PM +0100, Mark Brown wrote: > On Thu, Aug 02, 2012 at 08:45:18AM +0100, Lee Jones wrote: > > > Over time, the requests for Maintainers have Snowballed (pun intended). My > > task now seems to be enabling drivers for Device Tree _and_ fix all > > associated driver

Re: [alsa-devel] [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-03 Thread Lee Jones
On Thu, Aug 02, 2012 at 06:56:04PM +0100, Mark Brown wrote: On Thu, Aug 02, 2012 at 08:45:18AM +0100, Lee Jones wrote: Over time, the requests for Maintainers have Snowballed (pun intended). My task now seems to be enabling drivers for Device Tree _and_ fix all associated driver bugs,

Re: [alsa-devel] [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-03 Thread Mark Brown
On Fri, Aug 03, 2012 at 09:30:10AM +0100, Lee Jones wrote: I do agree that it should be correct, but the difference between getting it 90% correct and absolutely perfect increases the effort at least x2. With so much left to do, I think it would be better to get everything in and functioning,

Re: [alsa-devel] [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-02 Thread Mark Brown
On Thu, Aug 02, 2012 at 08:45:18AM +0100, Lee Jones wrote: > Over time, the requests for Maintainers have Snowballed (pun intended). My > task now seems to be enabling drivers for Device Tree _and_ fix all > associated driver bugs, including any requested restructuring and API One thing to

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-02 Thread Lee Jones
Patch withdrawn. On Tue, Jul 31, 2012 at 02:31:23PM +0100, Lee Jones wrote: > If a list of widgets is provided and one of them fails to be added as > a control, the present semantics fail all subsequent widgets. A better > solution would be to only fail that widget, but pursue in attempting > to

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-02 Thread Mark Brown
On Thu, Aug 02, 2012 at 07:58:24AM +0200, Ola Lilja wrote: > Accusing me of having "no interest in fixing the driver" is just absurd > regarding the time I've spent on this. I'm also still driving for Sorry, this is more directed at the current round of fixes that are being sent than the driver

Re: [alsa-devel] [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-02 Thread Lee Jones
On Wed, Aug 01, 2012 at 08:41:34PM +0100, Mark Brown wrote: > On Wed, Aug 01, 2012 at 05:08:24PM +0100, Mark Brown wrote: > > On Wed, Aug 01, 2012 at 02:50:32PM +0100, Lee Jones wrote: > > > > >It's very disappointing to see such an error exist, and even more > > > >disappointing that there's no

RE: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-02 Thread Ola Lilja
> -Original Message- > From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] > Sent: den 1 augusti 2012 15:20 > To: Lee Jones > Cc: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; > stericsson_nomadik_li...@list.st.com; linus.wall...@stericsson.com; >

RE: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-02 Thread Ola Lilja
-Original Message- From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com] Sent: den 1 augusti 2012 15:20 To: Lee Jones Cc: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; stericsson_nomadik_li...@list.st.com; linus.wall...@stericsson.com; a...@arndb.de;

Re: [alsa-devel] [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-02 Thread Lee Jones
On Wed, Aug 01, 2012 at 08:41:34PM +0100, Mark Brown wrote: On Wed, Aug 01, 2012 at 05:08:24PM +0100, Mark Brown wrote: On Wed, Aug 01, 2012 at 02:50:32PM +0100, Lee Jones wrote: It's very disappointing to see such an error exist, and even more disappointing that there's no interest in

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-02 Thread Mark Brown
On Thu, Aug 02, 2012 at 07:58:24AM +0200, Ola Lilja wrote: Accusing me of having no interest in fixing the driver is just absurd regarding the time I've spent on this. I'm also still driving for Sorry, this is more directed at the current round of fixes that are being sent than the driver

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-02 Thread Lee Jones
Patch withdrawn. On Tue, Jul 31, 2012 at 02:31:23PM +0100, Lee Jones wrote: If a list of widgets is provided and one of them fails to be added as a control, the present semantics fail all subsequent widgets. A better solution would be to only fail that widget, but pursue in attempting to add

Re: [alsa-devel] [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-02 Thread Mark Brown
On Thu, Aug 02, 2012 at 08:45:18AM +0100, Lee Jones wrote: Over time, the requests for Maintainers have Snowballed (pun intended). My task now seems to be enabling drivers for Device Tree _and_ fix all associated driver bugs, including any requested restructuring and API One thing to bear

Re: [alsa-devel] [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-01 Thread Mark Brown
On Wed, Aug 01, 2012 at 05:08:24PM +0100, Mark Brown wrote: > On Wed, Aug 01, 2012 at 02:50:32PM +0100, Lee Jones wrote: > > >It's very disappointing to see such an error exist, and even more > > >disappointing that there's no interest in fixing the driver. > > This is incorrect. I'm sure the

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-01 Thread Mark Brown
On Wed, Aug 01, 2012 at 02:50:32PM +0100, Lee Jones wrote: > I am under the impression that it was tested. Perhaps before it was > rebased, but tests were completed. Ola was very surprised when I > told him there were link failures. The only issue is that I only > found out and told him a day

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-01 Thread Lee Jones
On 01/08/12 14:20, Mark Brown wrote: On Wed, Aug 01, 2012 at 08:19:28AM +0100, Lee Jones wrote: On 31/07/12 16:18, Mark Brown wrote: I'm not going to apply this patch. This isn't a vendor BSP, we shouldn't be putting random hacks like this in core code. BSP kernel or otherwise, it still

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-01 Thread Mark Brown
On Wed, Aug 01, 2012 at 08:19:28AM +0100, Lee Jones wrote: > On 31/07/12 16:18, Mark Brown wrote: > >I'm not going to apply this patch. This isn't a vendor BSP, we > >shouldn't be putting random hacks like this in core code. > BSP kernel or otherwise, it still seems wrong to me to fail and >

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-01 Thread Lee Jones
On 31/07/12 16:18, Mark Brown wrote: It's certainly totally inappropriate for an "urgent" bugfix. Well it just means that audio won't work for the ux500 for this kernel release, but as we're waiting on clocks, this isn't a big issue for us. If you do take it (with or without the return code),

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-01 Thread Lee Jones
On 31/07/12 16:18, Mark Brown wrote: It's certainly totally inappropriate for an urgent bugfix. Well it just means that audio won't work for the ux500 for this kernel release, but as we're waiting on clocks, this isn't a big issue for us. If you do take it (with or without the return code),

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-01 Thread Mark Brown
On Wed, Aug 01, 2012 at 08:19:28AM +0100, Lee Jones wrote: On 31/07/12 16:18, Mark Brown wrote: I'm not going to apply this patch. This isn't a vendor BSP, we shouldn't be putting random hacks like this in core code. BSP kernel or otherwise, it still seems wrong to me to fail and entire

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-01 Thread Lee Jones
On 01/08/12 14:20, Mark Brown wrote: On Wed, Aug 01, 2012 at 08:19:28AM +0100, Lee Jones wrote: On 31/07/12 16:18, Mark Brown wrote: I'm not going to apply this patch. This isn't a vendor BSP, we shouldn't be putting random hacks like this in core code. BSP kernel or otherwise, it still

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-01 Thread Mark Brown
On Wed, Aug 01, 2012 at 02:50:32PM +0100, Lee Jones wrote: I am under the impression that it was tested. Perhaps before it was rebased, but tests were completed. Ola was very surprised when I told him there were link failures. The only issue is that I only found out and told him a day before

Re: [alsa-devel] [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-08-01 Thread Mark Brown
On Wed, Aug 01, 2012 at 05:08:24PM +0100, Mark Brown wrote: On Wed, Aug 01, 2012 at 02:50:32PM +0100, Lee Jones wrote: It's very disappointing to see such an error exist, and even more disappointing that there's no interest in fixing the driver. This is incorrect. I'm sure the driver will

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Mark Brown
On Tue, Jul 31, 2012 at 04:15:23PM +0100, Lee Jones wrote: > On 31/07/12 15:54, Mark Brown wrote: > >You might want to look at a better mail program. > Willingly. Any good suggestions? mutt works for me. > >It's certainly totally inappropriate for an "urgent" bugfix. > Well it just means that

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Lee Jones
On 31/07/12 15:54, Mark Brown wrote: On Tue, Jul 31, 2012 at 03:38:02PM +0100, Lee Jones wrote: Neither of those are in my Inbox. Blame Mozilla. :) You might want to look at a better mail program. Willingly. Any good suggestions? It's better because the whole audio system doesn't fail in

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Mark Brown
On Tue, Jul 31, 2012 at 03:38:02PM +0100, Lee Jones wrote: > Neither of those are in my Inbox. Blame Mozilla. :) You might want to look at a better mail program. > It's better because the whole audio system doesn't fail in the case > of minor failure. It'd be like calling off a football game

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Lee Jones
On 31/07/12 15:28, Mark Brown wrote: On Tue, Jul 31, 2012 at 03:25:07PM +0100, Lee Jones wrote: On 31/07/12 14:42, Mark Brown wrote: You're posting this *again* without bothering to respond to my review comments. I didn't see any comments on this. Read your email.

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Mark Brown
On Tue, Jul 31, 2012 at 03:25:07PM +0100, Lee Jones wrote: > On 31/07/12 14:42, Mark Brown wrote: > >You're posting this *again* without bothering to respond to my review > >comments. > I didn't see any comments on this. Read your email. <20120726115450.ge3...@opensource.wolfsonmicro.com> and

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Lee Jones
On 31/07/12 14:42, Mark Brown wrote: On Tue, Jul 31, 2012 at 02:31:23PM +0100, Lee Jones wrote: If a list of widgets is provided and one of them fails to be added as a control, the present semantics fail all subsequent widgets. A better solution would be to only fail that widget, but pursue in

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Mark Brown
On Tue, Jul 31, 2012 at 02:31:23PM +0100, Lee Jones wrote: > If a list of widgets is provided and one of them fails to be added as > a control, the present semantics fail all subsequent widgets. A better > solution would be to only fail that widget, but pursue in attempting > to add the rest of

[PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Lee Jones
If a list of widgets is provided and one of them fails to be added as a control, the present semantics fail all subsequent widgets. A better solution would be to only fail that widget, but pursue in attempting to add the rest of the list. Signed-off-by: Lee Jones --- sound/soc/soc-dapm.c |2

[PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Lee Jones
If a list of widgets is provided and one of them fails to be added as a control, the present semantics fail all subsequent widgets. A better solution would be to only fail that widget, but pursue in attempting to add the rest of the list. Signed-off-by: Lee Jones lee.jo...@linaro.org ---

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Mark Brown
On Tue, Jul 31, 2012 at 02:31:23PM +0100, Lee Jones wrote: If a list of widgets is provided and one of them fails to be added as a control, the present semantics fail all subsequent widgets. A better solution would be to only fail that widget, but pursue in attempting to add the rest of the

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Lee Jones
On 31/07/12 14:42, Mark Brown wrote: On Tue, Jul 31, 2012 at 02:31:23PM +0100, Lee Jones wrote: If a list of widgets is provided and one of them fails to be added as a control, the present semantics fail all subsequent widgets. A better solution would be to only fail that widget, but pursue in

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Mark Brown
On Tue, Jul 31, 2012 at 03:25:07PM +0100, Lee Jones wrote: On 31/07/12 14:42, Mark Brown wrote: You're posting this *again* without bothering to respond to my review comments. I didn't see any comments on this. Read your email. 20120726115450.ge3...@opensource.wolfsonmicro.com and

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Lee Jones
On 31/07/12 15:28, Mark Brown wrote: On Tue, Jul 31, 2012 at 03:25:07PM +0100, Lee Jones wrote: On 31/07/12 14:42, Mark Brown wrote: You're posting this *again* without bothering to respond to my review comments. I didn't see any comments on this. Read your email.

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Mark Brown
On Tue, Jul 31, 2012 at 03:38:02PM +0100, Lee Jones wrote: Neither of those are in my Inbox. Blame Mozilla. :) You might want to look at a better mail program. It's better because the whole audio system doesn't fail in the case of minor failure. It'd be like calling off a football game (or

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Lee Jones
On 31/07/12 15:54, Mark Brown wrote: On Tue, Jul 31, 2012 at 03:38:02PM +0100, Lee Jones wrote: Neither of those are in my Inbox. Blame Mozilla. :) You might want to look at a better mail program. Willingly. Any good suggestions? It's better because the whole audio system doesn't fail in

Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too

2012-07-31 Thread Mark Brown
On Tue, Jul 31, 2012 at 04:15:23PM +0100, Lee Jones wrote: On 31/07/12 15:54, Mark Brown wrote: You might want to look at a better mail program. Willingly. Any good suggestions? mutt works for me. It's certainly totally inappropriate for an urgent bugfix. Well it just means that audio