Re: [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-12-17 Thread Guido Martínez
On Sun, Nov 30, 2014 at 12:35:35PM +0100, Richard Weinberger wrote: > Add a ubi_fastmap_close() to free all resources used by fastmap > at WL shutdown. > > Signed-off-by: Richard Weinberger Either for this patch, or for a v3 if you move the -flush_work/+ubi_fastmap_close to shutdown_work:

Re: [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-12-17 Thread Guido Martínez
On Sun, Nov 30, 2014 at 12:35:35PM +0100, Richard Weinberger wrote: Add a ubi_fastmap_close() to free all resources used by fastmap at WL shutdown. Signed-off-by: Richard Weinberger rich...@nod.at Either for this patch, or for a v3 if you move the -flush_work/+ubi_fastmap_close to

Re: [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-12-07 Thread Richard Weinberger
Am 07.12.2014 um 14:26 schrieb Tanya Brokhman: > you're right, found it at ubi_detach_mtd_dev() several lines after calling > ubi_wl_close(). But if you're creating a fastmap-close dedicated function, > fm_buf should be freed in it > as it is fastmap related. The idea was to have WL related

Re: [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-12-07 Thread Tanya Brokhman
On 12/7/2014 1:34 PM, Richard Weinberger wrote: Am 07.12.2014 um 12:32 schrieb Tanya Brokhman: On 12/7/2014 11:54 AM, Richard Weinberger wrote: Am 07.12.2014 um 09:13 schrieb Tanya Brokhman: On 11/30/2014 1:35 PM, Richard Weinberger wrote: Add a ubi_fastmap_close() to free all resources used

Re: [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-12-07 Thread Richard Weinberger
Am 07.12.2014 um 12:32 schrieb Tanya Brokhman: > On 12/7/2014 11:54 AM, Richard Weinberger wrote: >> Am 07.12.2014 um 09:13 schrieb Tanya Brokhman: >>> On 11/30/2014 1:35 PM, Richard Weinberger wrote: Add a ubi_fastmap_close() to free all resources used by fastmap at WL shutdown.

Re: [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-12-07 Thread Tanya Brokhman
On 12/7/2014 11:54 AM, Richard Weinberger wrote: Am 07.12.2014 um 09:13 schrieb Tanya Brokhman: On 11/30/2014 1:35 PM, Richard Weinberger wrote: Add a ubi_fastmap_close() to free all resources used by fastmap at WL shutdown. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/wl.c | 21

Re: [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-12-07 Thread Richard Weinberger
Am 07.12.2014 um 09:13 schrieb Tanya Brokhman: > On 11/30/2014 1:35 PM, Richard Weinberger wrote: >> Add a ubi_fastmap_close() to free all resources used by fastmap >> at WL shutdown. >> >> Signed-off-by: Richard Weinberger >> --- >> drivers/mtd/ubi/wl.c | 21 ++--- >> 1 file

Re: [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-12-07 Thread Tanya Brokhman
On 11/30/2014 1:35 PM, Richard Weinberger wrote: Add a ubi_fastmap_close() to free all resources used by fastmap at WL shutdown. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/wl.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-12-07 Thread Tanya Brokhman
On 11/30/2014 1:35 PM, Richard Weinberger wrote: Add a ubi_fastmap_close() to free all resources used by fastmap at WL shutdown. Signed-off-by: Richard Weinberger rich...@nod.at --- drivers/mtd/ubi/wl.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-12-07 Thread Richard Weinberger
Am 07.12.2014 um 09:13 schrieb Tanya Brokhman: On 11/30/2014 1:35 PM, Richard Weinberger wrote: Add a ubi_fastmap_close() to free all resources used by fastmap at WL shutdown. Signed-off-by: Richard Weinberger rich...@nod.at --- drivers/mtd/ubi/wl.c | 21 ++--- 1 file

Re: [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-12-07 Thread Tanya Brokhman
On 12/7/2014 11:54 AM, Richard Weinberger wrote: Am 07.12.2014 um 09:13 schrieb Tanya Brokhman: On 11/30/2014 1:35 PM, Richard Weinberger wrote: Add a ubi_fastmap_close() to free all resources used by fastmap at WL shutdown. Signed-off-by: Richard Weinberger rich...@nod.at ---

Re: [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-12-07 Thread Richard Weinberger
Am 07.12.2014 um 12:32 schrieb Tanya Brokhman: On 12/7/2014 11:54 AM, Richard Weinberger wrote: Am 07.12.2014 um 09:13 schrieb Tanya Brokhman: On 11/30/2014 1:35 PM, Richard Weinberger wrote: Add a ubi_fastmap_close() to free all resources used by fastmap at WL shutdown. Signed-off-by:

Re: [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-12-07 Thread Tanya Brokhman
On 12/7/2014 1:34 PM, Richard Weinberger wrote: Am 07.12.2014 um 12:32 schrieb Tanya Brokhman: On 12/7/2014 11:54 AM, Richard Weinberger wrote: Am 07.12.2014 um 09:13 schrieb Tanya Brokhman: On 11/30/2014 1:35 PM, Richard Weinberger wrote: Add a ubi_fastmap_close() to free all resources used

Re: [PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-12-07 Thread Richard Weinberger
Am 07.12.2014 um 14:26 schrieb Tanya Brokhman: you're right, found it at ubi_detach_mtd_dev() several lines after calling ubi_wl_close(). But if you're creating a fastmap-close dedicated function, fm_buf should be freed in it as it is fastmap related. The idea was to have WL related stuff

[PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-11-30 Thread Richard Weinberger
Add a ubi_fastmap_close() to free all resources used by fastmap at WL shutdown. Signed-off-by: Richard Weinberger --- drivers/mtd/ubi/wl.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c index

[PATCH 1/6] UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2014-11-30 Thread Richard Weinberger
Add a ubi_fastmap_close() to free all resources used by fastmap at WL shutdown. Signed-off-by: Richard Weinberger rich...@nod.at --- drivers/mtd/ubi/wl.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c index