Re: [PATCH 1/6] genalloc: track beginning of allocations

On Wed, 21 Feb 2018 14:29:06 -0800 Kees Cook wrote: > >> I wonder if this might be more readable by splitting the kernel-doc > >> changes from the bitmap changes? I.e. fix all the kernel-doc in one > >> patch, and in the following, make the bitmap changes. Maybe it's such

Re: [PATCH 1/6] genalloc: track beginning of allocations

On Wed, 21 Feb 2018 14:29:06 -0800 Kees Cook wrote: > >> I wonder if this might be more readable by splitting the kernel-doc > >> changes from the bitmap changes? I.e. fix all the kernel-doc in one > >> patch, and in the following, make the bitmap changes. Maybe it's such > >> a small part that

Re: [PATCH 1/6] genalloc: track beginning of allocations

On Tue, Feb 20, 2018 at 9:07 AM, Igor Stoppa wrote: > On 13/02/18 01:52, Kees Cook wrote: >> On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: >>> @@ -738,14 +1031,16 @@ EXPORT_SYMBOL(devm_gen_pool_create); >>> >>> #ifdef CONFIG_OF >>> /** >>>

Re: [PATCH 1/6] genalloc: track beginning of allocations

On Tue, Feb 20, 2018 at 9:07 AM, Igor Stoppa wrote: > On 13/02/18 01:52, Kees Cook wrote: >> On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: >>> @@ -738,14 +1031,16 @@ EXPORT_SYMBOL(devm_gen_pool_create); >>> >>> #ifdef CONFIG_OF >>> /** >>> - * of_gen_pool_get - find a pool by phandle

Re: [PATCH 1/6] genalloc: track beginning of allocations

On 13/02/18 01:52, Kees Cook wrote: > On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: >> @@ -738,14 +1031,16 @@ EXPORT_SYMBOL(devm_gen_pool_create); >> >> #ifdef CONFIG_OF >> /** >> - * of_gen_pool_get - find a pool by phandle property >> + * of_gen_pool_get() - find

Re: [PATCH 1/6] genalloc: track beginning of allocations

On 13/02/18 01:52, Kees Cook wrote: > On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: >> @@ -738,14 +1031,16 @@ EXPORT_SYMBOL(devm_gen_pool_create); >> >> #ifdef CONFIG_OF >> /** >> - * of_gen_pool_get - find a pool by phandle property >> + * of_gen_pool_get() - find a pool by phandle

Re: [PATCH 1/6] genalloc: track beginning of allocations

Hi Igor, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc1 next-20180212] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/6] genalloc: track beginning of allocations

Hi Igor, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc1 next-20180212] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/6] genalloc: track beginning of allocations

On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: > @@ -738,14 +1031,16 @@ EXPORT_SYMBOL(devm_gen_pool_create); > > #ifdef CONFIG_OF > /** > - * of_gen_pool_get - find a pool by phandle property > + * of_gen_pool_get() - find a pool by phandle property > * @np:

Re: [PATCH 1/6] genalloc: track beginning of allocations

On Mon, Feb 12, 2018 at 8:52 AM, Igor Stoppa wrote: > @@ -738,14 +1031,16 @@ EXPORT_SYMBOL(devm_gen_pool_create); > > #ifdef CONFIG_OF > /** > - * of_gen_pool_get - find a pool by phandle property > + * of_gen_pool_get() - find a pool by phandle property > * @np: device node > * @propname:

[PATCH 1/6] genalloc: track beginning of allocations

The genalloc library is only capable of tracking if a certain unit of allocation is in use or not. It is not capable of discerning where the memory associated to an allocation request begins and where it ends. The reason is that units of allocations are tracked by using a bitmap, where each bit

[PATCH 1/6] genalloc: track beginning of allocations

The genalloc library is only capable of tracking if a certain unit of allocation is in use or not. It is not capable of discerning where the memory associated to an allocation request begins and where it ends. The reason is that units of allocations are tracked by using a bitmap, where each bit

Re: [PATCH 1/6] genalloc: track beginning of allocations

On Mon, Feb 12, 2018 at 01:17:01PM +0200, Igor Stoppa wrote: > > > On 11/02/18 14:24, Mike Rapoport wrote: > > On Sun, Feb 11, 2018 at 05:19:15AM +0200, Igor Stoppa wrote: > [...] > > >> +/** > >> + * mem_to_units - convert references to memory into orders of allocation > > > >

Re: [PATCH 1/6] genalloc: track beginning of allocations

On Mon, Feb 12, 2018 at 01:17:01PM +0200, Igor Stoppa wrote: > > > On 11/02/18 14:24, Mike Rapoport wrote: > > On Sun, Feb 11, 2018 at 05:19:15AM +0200, Igor Stoppa wrote: > [...] > > >> +/** > >> + * mem_to_units - convert references to memory into orders of allocation > > > >

Re: [PATCH 1/6] genalloc: track beginning of allocations

On 11/02/18 14:24, Mike Rapoport wrote: > On Sun, Feb 11, 2018 at 05:19:15AM +0200, Igor Stoppa wrote: [...] >> +/** >> + * mem_to_units - convert references to memory into orders of allocation > > Documentation/doc-guide/kernel-doc.rst recommends to to include brackets > for function

Re: [PATCH 1/6] genalloc: track beginning of allocations

On 11/02/18 14:24, Mike Rapoport wrote: > On Sun, Feb 11, 2018 at 05:19:15AM +0200, Igor Stoppa wrote: [...] >> +/** >> + * mem_to_units - convert references to memory into orders of allocation > > Documentation/doc-guide/kernel-doc.rst recommends to to include brackets > for function

Re: [PATCH 1/6] genalloc: track beginning of allocations

On Sun, Feb 11, 2018 at 05:19:15AM +0200, Igor Stoppa wrote: > The genalloc library is only capable of tracking if a certain unit of > allocation is in use or not. > > It is not capable of discerning where the memory associated to an > allocation request begins and where it ends. > > The reason

Re: [PATCH 1/6] genalloc: track beginning of allocations

On Sun, Feb 11, 2018 at 05:19:15AM +0200, Igor Stoppa wrote: > The genalloc library is only capable of tracking if a certain unit of > allocation is in use or not. > > It is not capable of discerning where the memory associated to an > allocation request begins and where it ends. > > The reason

[PATCH 1/6] genalloc: track beginning of allocations

The genalloc library is only capable of tracking if a certain unit of allocation is in use or not. It is not capable of discerning where the memory associated to an allocation request begins and where it ends. The reason is that units of allocations are tracked by using a bitmap, where each bit

[PATCH 1/6] genalloc: track beginning of allocations

The genalloc library is only capable of tracking if a certain unit of allocation is in use or not. It is not capable of discerning where the memory associated to an allocation request begins and where it ends. The reason is that units of allocations are tracked by using a bitmap, where each bit

Re: [PATCH 1/6] genalloc: track beginning of allocations

On 02/09/2018 08:18 AM, Igor Stoppa wrote: > > > On 05/02/18 00:34, Randy Dunlap wrote: >> On 02/04/2018 08:47 AM, Igor Stoppa wrote: > > [...] > >> It would be good for a lot of this to be in a source file or the >> pmalloc.rst documentation file instead of living only in the git repository.

Re: [PATCH 1/6] genalloc: track beginning of allocations

On 02/09/2018 08:18 AM, Igor Stoppa wrote: > > > On 05/02/18 00:34, Randy Dunlap wrote: >> On 02/04/2018 08:47 AM, Igor Stoppa wrote: > > [...] > >> It would be good for a lot of this to be in a source file or the >> pmalloc.rst documentation file instead of living only in the git repository.

Re: [PATCH 1/6] genalloc: track beginning of allocations

On 05/02/18 00:34, Randy Dunlap wrote: > On 02/04/2018 08:47 AM, Igor Stoppa wrote: [...] > It would be good for a lot of this to be in a source file or the > pmalloc.rst documentation file instead of living only in the git repository. This is actually about genalloc. The genalloc

Re: [PATCH 1/6] genalloc: track beginning of allocations

On 05/02/18 00:34, Randy Dunlap wrote: > On 02/04/2018 08:47 AM, Igor Stoppa wrote: [...] > It would be good for a lot of this to be in a source file or the > pmalloc.rst documentation file instead of living only in the git repository. This is actually about genalloc. The genalloc

Re: [PATCH 1/6] genalloc: track beginning of allocations

On 05/02/18 05:45, Matthew Wilcox wrote: > On Sun, Feb 04, 2018 at 02:34:08PM -0800, Randy Dunlap wrote: >>> +/** >>> + * cleart_bits_ll - according to the mask, clears the bits specified by >> >> clear_bits_ll > > 'make W=1' should catch this ... yes? > > (hint: building with 'make C=1

Re: [PATCH 1/6] genalloc: track beginning of allocations

On 05/02/18 05:45, Matthew Wilcox wrote: > On Sun, Feb 04, 2018 at 02:34:08PM -0800, Randy Dunlap wrote: >>> +/** >>> + * cleart_bits_ll - according to the mask, clears the bits specified by >> >> clear_bits_ll > > 'make W=1' should catch this ... yes? > > (hint: building with 'make C=1

Re: [PATCH 1/6] genalloc: track beginning of allocations

On Sun, Feb 04, 2018 at 02:34:08PM -0800, Randy Dunlap wrote: > > +/** > > + * cleart_bits_ll - according to the mask, clears the bits specified by > > clear_bits_ll 'make W=1' should catch this ... yes? (hint: building with 'make C=1 W=1' finds all kinds of interesting issues in your

Re: [PATCH 1/6] genalloc: track beginning of allocations

On Sun, Feb 04, 2018 at 02:34:08PM -0800, Randy Dunlap wrote: > > +/** > > + * cleart_bits_ll - according to the mask, clears the bits specified by > > clear_bits_ll 'make W=1' should catch this ... yes? (hint: building with 'make C=1 W=1' finds all kinds of interesting issues in your

Re: [PATCH 1/6] genalloc: track beginning of allocations

On 02/04/2018 08:47 AM, Igor Stoppa wrote: > The genalloc library is only capable of tracking if a certain unit of > allocation is in use or not. > > It is not capable of discerning where the memory associated to an > allocation request begins and where it ends. > > The reason is that units of

Re: [PATCH 1/6] genalloc: track beginning of allocations

On 02/04/2018 08:47 AM, Igor Stoppa wrote: > The genalloc library is only capable of tracking if a certain unit of > allocation is in use or not. > > It is not capable of discerning where the memory associated to an > allocation request begins and where it ends. > > The reason is that units of

[PATCH 1/6] genalloc: track beginning of allocations

The genalloc library is only capable of tracking if a certain unit of allocation is in use or not. It is not capable of discerning where the memory associated to an allocation request begins and where it ends. The reason is that units of allocations are tracked by using a bitmap, where each bit

[PATCH 1/6] genalloc: track beginning of allocations

The genalloc library is only capable of tracking if a certain unit of allocation is in use or not. It is not capable of discerning where the memory associated to an allocation request begins and where it ends. The reason is that units of allocations are tracked by using a bitmap, where each bit

[PATCH 1/6] genalloc: track beginning of allocations

The genalloc library is only capable of tracking if a certain unit of allocation is in use or not. It is not capable of discerning where the memory associated to an allocation request begins and where it ends. The reason is that units of allocations are tracked by using a bitmap, where each bit

[PATCH 1/6] genalloc: track beginning of allocations

The genalloc library is only capable of tracking if a certain unit of allocation is in use or not. It is not capable of discerning where the memory associated to an allocation request begins and where it ends. The reason is that units of allocations are tracked by using a bitmap, where each bit

[PATCH 1/6] genalloc: track beginning of allocations

The genalloc library is only capable of tracking if a certain unit of allocation is in use or not. It is not capable of discerning where the memory associated to an allocation request begins and where it ends. The reason is that units of allocations are tracked by using a bitmap, where each bit

[PATCH 1/6] genalloc: track beginning of allocations

The genalloc library is only capable of tracking if a certain unit of allocation is in use or not. It is not capable of discerning where the memory associated to an allocation request begins and where it ends. The reason is that units of allocations are tracked by using a bitmap, where each bit

[PATCH 1/6] genalloc: track beginning of allocations

The genalloc library is only capable of tracking if a certain unit of allocation is in use or not. It is not capable of discerning where the memory associated to an allocation request begins and where it ends. The reason is that units of allocations are tracked by using a bitmap, where each bit

[PATCH 1/6] genalloc: track beginning of allocations

The genalloc library is only capable of tracking if a certain unit of allocation is in use or not. It is not capable of discerning where the memory associated to an allocation request begins and where it ends. The reason is that units of allocations are tracked by using a bitmap, where each bit