Re: [PATCH 1/6] ibmvfc: byte swap login_buf.resp values in attribute show functions

2020-11-16 Thread Martin K. Petersen
Tyrel, > The checkpatch script only warns at 100 char lines these days. To be > fair though I did have two lines go over that limit by a couple > characters, there are a couple commit log typos, and I had an if > keyword with no space after before the opening parenthesis. So, I'll > happily

Re: [PATCH 1/6] ibmvfc: byte swap login_buf.resp values in attribute show functions

2020-11-13 Thread Tyrel Datwyler
On 11/12/20 1:37 AM, Christoph Hellwig wrote: > On Wed, Nov 11, 2020 at 07:04:37PM -0600, Tyrel Datwyler wrote: >> Both ibmvfc_show_host_(capabilities|npiv_version) functions retrieve >> values from vhost->login_buf.resp buffer. This is the MAD response >> buffer from the VIOS and as such any

Re: [PATCH 1/6] ibmvfc: byte swap login_buf.resp values in attribute show functions

2020-11-12 Thread Christoph Hellwig
On Wed, Nov 11, 2020 at 07:04:37PM -0600, Tyrel Datwyler wrote: > Both ibmvfc_show_host_(capabilities|npiv_version) functions retrieve > values from vhost->login_buf.resp buffer. This is the MAD response > buffer from the VIOS and as such any multi-byte non-string values are in > big endian

[PATCH 1/6] ibmvfc: byte swap login_buf.resp values in attribute show functions

2020-11-11 Thread Tyrel Datwyler
Both ibmvfc_show_host_(capabilities|npiv_version) functions retrieve values from vhost->login_buf.resp buffer. This is the MAD response buffer from the VIOS and as such any multi-byte non-string values are in big endian format. Byte swap these values to host cpu endian format for better human