Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-15 Thread Johannes Weiner
On Mon, Nov 14, 2016 at 10:40:54PM +0300, Kirill A. Shutemov wrote: > Could you just amend all these fixups into your patch? Will do.

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-15 Thread Johannes Weiner
On Mon, Nov 14, 2016 at 10:40:54PM +0300, Kirill A. Shutemov wrote: > Could you just amend all these fixups into your patch? Will do.

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-14 Thread Kirill A. Shutemov
On Mon, Nov 14, 2016 at 11:48:22AM -0500, Johannes Weiner wrote: > On Mon, Nov 14, 2016 at 10:52:50AM -0500, Johannes Weiner wrote: > > On Mon, Nov 14, 2016 at 05:29:02PM +0300, Kirill A. Shutemov wrote: > > > @@ -1400,7 +1400,9 @@ static void collapse_shmem(struct mm_struct *mm, > > >

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-14 Thread Kirill A. Shutemov
On Mon, Nov 14, 2016 at 11:48:22AM -0500, Johannes Weiner wrote: > On Mon, Nov 14, 2016 at 10:52:50AM -0500, Johannes Weiner wrote: > > On Mon, Nov 14, 2016 at 05:29:02PM +0300, Kirill A. Shutemov wrote: > > > @@ -1400,7 +1400,9 @@ static void collapse_shmem(struct mm_struct *mm, > > >

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-14 Thread Johannes Weiner
On Mon, Nov 14, 2016 at 10:52:50AM -0500, Johannes Weiner wrote: > On Mon, Nov 14, 2016 at 05:29:02PM +0300, Kirill A. Shutemov wrote: > > @@ -1400,7 +1400,9 @@ static void collapse_shmem(struct mm_struct *mm, > > PAGE_SIZE, 0); > > > >

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-14 Thread Johannes Weiner
On Mon, Nov 14, 2016 at 10:52:50AM -0500, Johannes Weiner wrote: > On Mon, Nov 14, 2016 at 05:29:02PM +0300, Kirill A. Shutemov wrote: > > @@ -1400,7 +1400,9 @@ static void collapse_shmem(struct mm_struct *mm, > > PAGE_SIZE, 0); > > > >

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-14 Thread Johannes Weiner
On Mon, Nov 14, 2016 at 05:29:02PM +0300, Kirill A. Shutemov wrote: > On Mon, Nov 14, 2016 at 09:07:44AM +0100, Jan Kara wrote: > > On Fri 11-11-16 19:37:53, Kirill A. Shutemov wrote: > > > On Fri, Nov 11, 2016 at 01:22:24PM +0100, Jan Kara wrote: > > > > On Fri 11-11-16 13:59:21, Kirill A.

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-14 Thread Johannes Weiner
On Mon, Nov 14, 2016 at 05:29:02PM +0300, Kirill A. Shutemov wrote: > On Mon, Nov 14, 2016 at 09:07:44AM +0100, Jan Kara wrote: > > On Fri 11-11-16 19:37:53, Kirill A. Shutemov wrote: > > > On Fri, Nov 11, 2016 at 01:22:24PM +0100, Jan Kara wrote: > > > > On Fri 11-11-16 13:59:21, Kirill A.

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-14 Thread Kirill A. Shutemov
On Mon, Nov 14, 2016 at 09:07:44AM +0100, Jan Kara wrote: > On Fri 11-11-16 19:37:53, Kirill A. Shutemov wrote: > > On Fri, Nov 11, 2016 at 01:22:24PM +0100, Jan Kara wrote: > > > On Fri 11-11-16 13:59:21, Kirill A. Shutemov wrote: > > > > On Tue, Nov 08, 2016 at 11:12:45AM -0500, Johannes Weiner

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-14 Thread Kirill A. Shutemov
On Mon, Nov 14, 2016 at 09:07:44AM +0100, Jan Kara wrote: > On Fri 11-11-16 19:37:53, Kirill A. Shutemov wrote: > > On Fri, Nov 11, 2016 at 01:22:24PM +0100, Jan Kara wrote: > > > On Fri 11-11-16 13:59:21, Kirill A. Shutemov wrote: > > > > On Tue, Nov 08, 2016 at 11:12:45AM -0500, Johannes Weiner

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-14 Thread Jan Kara
On Fri 11-11-16 19:37:53, Kirill A. Shutemov wrote: > On Fri, Nov 11, 2016 at 01:22:24PM +0100, Jan Kara wrote: > > On Fri 11-11-16 13:59:21, Kirill A. Shutemov wrote: > > > On Tue, Nov 08, 2016 at 11:12:45AM -0500, Johannes Weiner wrote: > > > > On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-14 Thread Jan Kara
On Fri 11-11-16 19:37:53, Kirill A. Shutemov wrote: > On Fri, Nov 11, 2016 at 01:22:24PM +0100, Jan Kara wrote: > > On Fri 11-11-16 13:59:21, Kirill A. Shutemov wrote: > > > On Tue, Nov 08, 2016 at 11:12:45AM -0500, Johannes Weiner wrote: > > > > On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-11 Thread Kirill A. Shutemov
On Fri, Nov 11, 2016 at 01:22:24PM +0100, Jan Kara wrote: > On Fri 11-11-16 13:59:21, Kirill A. Shutemov wrote: > > On Tue, Nov 08, 2016 at 11:12:45AM -0500, Johannes Weiner wrote: > > > On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara wrote: > > > > On Mon 07-11-16 14:07:36, Johannes Weiner

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-11 Thread Kirill A. Shutemov
On Fri, Nov 11, 2016 at 01:22:24PM +0100, Jan Kara wrote: > On Fri 11-11-16 13:59:21, Kirill A. Shutemov wrote: > > On Tue, Nov 08, 2016 at 11:12:45AM -0500, Johannes Weiner wrote: > > > On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara wrote: > > > > On Mon 07-11-16 14:07:36, Johannes Weiner

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-11 Thread Jan Kara
On Fri 11-11-16 13:59:21, Kirill A. Shutemov wrote: > On Tue, Nov 08, 2016 at 11:12:45AM -0500, Johannes Weiner wrote: > > On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara wrote: > > > On Mon 07-11-16 14:07:36, Johannes Weiner wrote: > > > > The radix tree counts valid entries in each tree node.

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-11 Thread Jan Kara
On Fri 11-11-16 13:59:21, Kirill A. Shutemov wrote: > On Tue, Nov 08, 2016 at 11:12:45AM -0500, Johannes Weiner wrote: > > On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara wrote: > > > On Mon 07-11-16 14:07:36, Johannes Weiner wrote: > > > > The radix tree counts valid entries in each tree node.

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-11 Thread Kirill A. Shutemov
On Tue, Nov 08, 2016 at 11:12:45AM -0500, Johannes Weiner wrote: > On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara wrote: > > On Mon 07-11-16 14:07:36, Johannes Weiner wrote: > > > The radix tree counts valid entries in each tree node. Entries stored > > > in the tree cannot be removed by

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-11 Thread Kirill A. Shutemov
On Tue, Nov 08, 2016 at 11:12:45AM -0500, Johannes Weiner wrote: > On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara wrote: > > On Mon 07-11-16 14:07:36, Johannes Weiner wrote: > > > The radix tree counts valid entries in each tree node. Entries stored > > > in the tree cannot be removed by

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-08 Thread Jan Kara
On Tue 08-11-16 11:12:45, Johannes Weiner wrote: > On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara wrote: > > On Mon 07-11-16 14:07:36, Johannes Weiner wrote: > > > The radix tree counts valid entries in each tree node. Entries stored > > > in the tree cannot be removed by simpling storing NULL

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-08 Thread Jan Kara
On Tue 08-11-16 11:12:45, Johannes Weiner wrote: > On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara wrote: > > On Mon 07-11-16 14:07:36, Johannes Weiner wrote: > > > The radix tree counts valid entries in each tree node. Entries stored > > > in the tree cannot be removed by simpling storing NULL

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-08 Thread Johannes Weiner
On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara wrote: > On Mon 07-11-16 14:07:36, Johannes Weiner wrote: > > The radix tree counts valid entries in each tree node. Entries stored > > in the tree cannot be removed by simpling storing NULL in the slot or > > the internal counters will be off and

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-08 Thread Johannes Weiner
On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara wrote: > On Mon 07-11-16 14:07:36, Johannes Weiner wrote: > > The radix tree counts valid entries in each tree node. Entries stored > > in the tree cannot be removed by simpling storing NULL in the slot or > > the internal counters will be off and

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-08 Thread Jan Kara
On Mon 07-11-16 14:07:36, Johannes Weiner wrote: > The radix tree counts valid entries in each tree node. Entries stored > in the tree cannot be removed by simpling storing NULL in the slot or > the internal counters will be off and the node never gets freed again. > > When collapsing a shmem

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-08 Thread Jan Kara
On Mon 07-11-16 14:07:36, Johannes Weiner wrote: > The radix tree counts valid entries in each tree node. Entries stored > in the tree cannot be removed by simpling storing NULL in the slot or > the internal counters will be off and the node never gets freed again. > > When collapsing a shmem

[PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-07 Thread Johannes Weiner
The radix tree counts valid entries in each tree node. Entries stored in the tree cannot be removed by simpling storing NULL in the slot or the internal counters will be off and the node never gets freed again. When collapsing a shmem page fails, restore the holes that were filled with

[PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-07 Thread Johannes Weiner
The radix tree counts valid entries in each tree node. Entries stored in the tree cannot be removed by simpling storing NULL in the slot or the internal counters will be off and the node never gets freed again. When collapsing a shmem page fails, restore the holes that were filled with