Re: [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators

2012-08-13 Thread Mark Brown
On Sat, Aug 11, 2012 at 10:22:54AM +0800, Axel Lin wrote: > We do have such case in drivers/regulator/max1586.c They should have a read operation implemented. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators

2012-08-13 Thread Mark Brown
On Sat, Aug 11, 2012 at 10:22:54AM +0800, Axel Lin wrote: We do have such case in drivers/regulator/max1586.c They should have a read operation implemented. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators

2012-08-10 Thread Axel Lin
2012/8/10 Mark Brown : > On Fri, Aug 10, 2012 at 08:27:32PM +0800, Axel Lin wrote: >> 2012/8/10 Mark Brown : > >> > We should be failing to register these regulators in the first place, or >> > at least complaining extremely loudly about them. > >> Oh. My original intention is to prevent using

Re: [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators

2012-08-10 Thread Mark Brown
On Fri, Aug 10, 2012 at 08:27:32PM +0800, Axel Lin wrote: > 2012/8/10 Mark Brown : > > We should be failing to register these regulators in the first place, or > > at least complaining extremely loudly about them. > Oh. My original intention is to prevent using list_voltage() to read > voltage

Re: [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators

2012-08-10 Thread Axel Lin
2012/8/10 Mark Brown : > On Fri, Aug 10, 2012 at 09:32:33AM +0800, Axel Lin wrote: >> Use list_voltage() to read single voltage regulators should be only applied >> to >> single voltage regulators, thus add checking n_voltages for this case. > > We should be failing to register these regulators

Re: [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators

2012-08-10 Thread Mark Brown
On Fri, Aug 10, 2012 at 09:32:33AM +0800, Axel Lin wrote: > Use list_voltage() to read single voltage regulators should be only applied to > single voltage regulators, thus add checking n_voltages for this case. We should be failing to register these regulators in the first place, or at least

Re: [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators

2012-08-10 Thread Mark Brown
On Fri, Aug 10, 2012 at 09:32:33AM +0800, Axel Lin wrote: Use list_voltage() to read single voltage regulators should be only applied to single voltage regulators, thus add checking n_voltages for this case. We should be failing to register these regulators in the first place, or at least

Re: [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators

2012-08-10 Thread Axel Lin
2012/8/10 Mark Brown broo...@opensource.wolfsonmicro.com: On Fri, Aug 10, 2012 at 09:32:33AM +0800, Axel Lin wrote: Use list_voltage() to read single voltage regulators should be only applied to single voltage regulators, thus add checking n_voltages for this case. We should be failing to

Re: [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators

2012-08-10 Thread Mark Brown
On Fri, Aug 10, 2012 at 08:27:32PM +0800, Axel Lin wrote: 2012/8/10 Mark Brown broo...@opensource.wolfsonmicro.com: We should be failing to register these regulators in the first place, or at least complaining extremely loudly about them. Oh. My original intention is to prevent using

Re: [PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators

2012-08-10 Thread Axel Lin
2012/8/10 Mark Brown broo...@opensource.wolfsonmicro.com: On Fri, Aug 10, 2012 at 08:27:32PM +0800, Axel Lin wrote: 2012/8/10 Mark Brown broo...@opensource.wolfsonmicro.com: We should be failing to register these regulators in the first place, or at least complaining extremely loudly about

[PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators

2012-08-09 Thread Axel Lin
Use list_voltage() to read single voltage regulators should be only applied to single voltage regulators, thus add checking n_voltages for this case. Signed-off-by: Axel Lin --- drivers/regulator/core.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 1/6] regulator: core: Add checking n_voltages if using list_voltage() to read voltage regulators

2012-08-09 Thread Axel Lin
Use list_voltage() to read single voltage regulators should be only applied to single voltage regulators, thus add checking n_voltages for this case. Signed-off-by: Axel Lin axel@gmail.com --- drivers/regulator/core.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git