Re: [PATCH 1/6] staging: kpc2000: make kconfig symbol 'KPC2000' select dependencies

On Thu, May 23, 2019 at 01:35:02AM +, Geordan Neukum wrote: > On Wed, May 22, 2019 at 12:27 PM Greg Kroah-Hartman > wrote: > > depends on is better than select. There's a change to depend on UIO for > > this code already in my -linus branch which will show up in Linus's tree > > in a week or

Re: [PATCH 1/6] staging: kpc2000: make kconfig symbol 'KPC2000' select dependencies

On Wed, May 22, 2019 at 12:27 PM Greg Kroah-Hartman wrote: > depends on is better than select. There's a change to depend on UIO for > this code already in my -linus branch which will show up in Linus's tree > in a week or so. Noted on both accounts. Thanks for the feedback and sorry for the

Re: [PATCH 1/6] staging: kpc2000: make kconfig symbol 'KPC2000' select dependencies

On Wed, May 22, 2019 at 12:13:57PM +, Geordan Neukum wrote: > The kpc2000 core makes calls against functions which are conditionally > exported upon the kconfig symbols 'MFD_CORE' and 'UIO' being selected > Therefore, in order to guarantee correct compilation, the 'KPC2000' > kconfig symbol

[PATCH 1/6] staging: kpc2000: make kconfig symbol 'KPC2000' select dependencies

The kpc2000 core makes calls against functions which are conditionally exported upon the kconfig symbols 'MFD_CORE' and 'UIO' being selected Therefore, in order to guarantee correct compilation, the 'KPC2000' kconfig symbol (which brings in that code) must explicitly select its hard dependencies.