Re: [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

2015-03-11 Thread Lorenzo Stoakes
On 11 March 2015 at 10:35, Sudip Mukherjee > i think i will better check v2 of your series on hardware This is incoming in just a moment (though I only v2 patches in the series I've changed which I think is the right way to make modifications with a patch series.) > , and while > you are

Re: [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

2015-03-11 Thread Sudip Mukherjee
On Wed, Mar 11, 2015 at 03:18:06PM +0530, Sudip Mukherjee wrote: > On Wed, Mar 11, 2015 at 09:11:52AM +, Lorenzo Stoakes wrote: > > On 11 March 2015 at 08:54, Dan Carpenter wrote: > > > Btw, do you have this hardware? Are you able to test these changes? > > > > Unfortunately not, I am

Re: [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

2015-03-11 Thread Sudip Mukherjee
On Wed, Mar 11, 2015 at 09:11:52AM +, Lorenzo Stoakes wrote: > On 11 March 2015 at 08:54, Dan Carpenter wrote: > > Btw, do you have this hardware? Are you able to test these changes? > > Unfortunately not, I am trying to keep these changes as simple code > fixes that ought not to affect

Re: [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

2015-03-11 Thread Dan Carpenter
On Wed, Mar 11, 2015 at 09:11:52AM +, Lorenzo Stoakes wrote: > On 11 March 2015 at 08:54, Dan Carpenter wrote: > > When I see a patch like this, then I worry, "What if the Sparse > > annotations are wrong? The patch description doesn't say anything about > > that." After review then I think

Re: [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

2015-03-11 Thread Lorenzo Stoakes
On 11 March 2015 at 08:54, Dan Carpenter wrote: > When I see a patch like this, then I worry, "What if the Sparse > annotations are wrong? The patch description doesn't say anything about > that." After review then I think the annotations are correct so that's > fine. How do you mean? I was

Re: [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

2015-03-11 Thread Dan Carpenter
On Wed, Mar 11, 2015 at 01:28:40AM +, Lorenzo Stoakes wrote: > This patch uses memset_io instead of memset when using memset on __iomem > qualified pointers. This fixes the following sparse warnings:- > > drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1 >

Re: [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

2015-03-11 Thread Dan Carpenter
On Wed, Mar 11, 2015 at 09:11:52AM +, Lorenzo Stoakes wrote: On 11 March 2015 at 08:54, Dan Carpenter dan.carpen...@oracle.com wrote: When I see a patch like this, then I worry, What if the Sparse annotations are wrong? The patch description doesn't say anything about that. After

Re: [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

2015-03-11 Thread Lorenzo Stoakes
On 11 March 2015 at 10:35, Sudip Mukherjee i think i will better check v2 of your series on hardware This is incoming in just a moment (though I only v2 patches in the series I've changed which I think is the right way to make modifications with a patch series.) , and while you are preparing

Re: [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

2015-03-11 Thread Sudip Mukherjee
On Wed, Mar 11, 2015 at 03:18:06PM +0530, Sudip Mukherjee wrote: On Wed, Mar 11, 2015 at 09:11:52AM +, Lorenzo Stoakes wrote: On 11 March 2015 at 08:54, Dan Carpenter dan.carpen...@oracle.com wrote: Btw, do you have this hardware? Are you able to test these changes? Unfortunately

Re: [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

2015-03-11 Thread Dan Carpenter
On Wed, Mar 11, 2015 at 01:28:40AM +, Lorenzo Stoakes wrote: This patch uses memset_io instead of memset when using memset on __iomem qualified pointers. This fixes the following sparse warnings:- drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1 (different

Re: [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

2015-03-11 Thread Sudip Mukherjee
On Wed, Mar 11, 2015 at 09:11:52AM +, Lorenzo Stoakes wrote: On 11 March 2015 at 08:54, Dan Carpenter dan.carpen...@oracle.com wrote: Btw, do you have this hardware? Are you able to test these changes? Unfortunately not, I am trying to keep these changes as simple code fixes that ought

Re: [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

2015-03-11 Thread Lorenzo Stoakes
On 11 March 2015 at 08:54, Dan Carpenter dan.carpen...@oracle.com wrote: When I see a patch like this, then I worry, What if the Sparse annotations are wrong? The patch description doesn't say anything about that. After review then I think the annotations are correct so that's fine. How do

[PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

2015-03-10 Thread Lorenzo Stoakes
This patch uses memset_io instead of memset when using memset on __iomem qualified pointers. This fixes the following sparse warnings:- drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1 (different address spaces) drivers/staging/sm750fb/sm750.c:490:17: warning:

[PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

2015-03-10 Thread Lorenzo Stoakes
This patch uses memset_io instead of memset when using memset on __iomem qualified pointers. This fixes the following sparse warnings:- drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1 (different address spaces) drivers/staging/sm750fb/sm750.c:490:17: warning: