Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

2016-02-17 Thread Arnd Bergmann
On Wednesday 17 February 2016 17:08:27 Felipe Balbi wrote: > > Hi, > > Arnd Bergmann writes: > > ixp4xx and pxa25x both use this driver and provide a slightly > > different set of register definitions for it. Aside from that, > > the definition in the ixp4xx-regs.h header conflicts with the > >

Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

2016-02-17 Thread Felipe Balbi
Hi, Arnd Bergmann writes: > ixp4xx and pxa25x both use this driver and provide a slightly > different set of register definitions for it. Aside from that, > the definition in the ixp4xx-regs.h header conflicts with the > on in the pxa27x device driver when compile-testing that: > > In file inclu

Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

2016-01-29 Thread Krzysztof HaƂasa
Arnd Bergmann writes: > This addresses both issues by moving all the definitions into the > pxa25x_udc driver itself. It turns out the only difference between > them was 'UDCCS_IO_ROF', and that could well be a mistake when it > was incorrectly copied from pxa25x to ixp4xx. > > Signed-off-by: Arn

Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

2016-01-29 Thread Robert Jarzmik
Arnd Bergmann writes: > On Friday 29 January 2016 10:32:07 Robert Jarzmik wrote: >> > This addresses both issues by moving all the definitions into the >> > pxa25x_udc driver itself. It turns out the only difference between >> > them was 'UDCCS_IO_ROF', and that could well be a mistake when it >>

Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

2016-01-29 Thread Arnd Bergmann
On Friday 29 January 2016 10:32:07 Robert Jarzmik wrote: > > This addresses both issues by moving all the definitions into the > > pxa25x_udc driver itself. It turns out the only difference between > > them was 'UDCCS_IO_ROF', and that could well be a mistake when it > > was incorrectly copied from

Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

2016-01-29 Thread Robert Jarzmik
Arnd Bergmann writes: > ixp4xx and pxa25x both use this driver and provide a slightly > different set of register definitions for it. Aside from that, > the definition in the ixp4xx-regs.h header conflicts with the > on in the pxa27x device driver when compile-testing that: > > In file included f

[PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

2016-01-28 Thread Arnd Bergmann
ixp4xx and pxa25x both use this driver and provide a slightly different set of register definitions for it. Aside from that, the definition in the ixp4xx-regs.h header conflicts with the on in the pxa27x device driver when compile-testing that: In file included from ../drivers/usb/gadget/udc/pxa27