Re: [PATCH 1/8] clk: renesas: Remove usage of CLK_IS_BASIC

2018-12-13 Thread Stephen Boyd 
Quoting Stephen Boyd (2018-12-06 13:58:51)
> This flag doesn't look to be used by any code, just set in various clk
> init structures and then never tested again. Remove it from these
> drivers as it doesn't provide any benefit.
> 
> Cc: Geert Uytterhoeven 
> Cc: 
> Signed-off-by: Stephen Boyd 
> ---

Applied to clk-next

Re: [PATCH 1/8] clk: renesas: Remove usage of CLK_IS_BASIC

2018-12-07 Thread Stephen Boyd 
Quoting Geert Uytterhoeven (2018-12-07 00:27:11)
> Hi Stephen,
> 
> On Thu, Dec 6, 2018 at 10:59 PM Stephen Boyd  wrote:
> > This flag doesn't look to be used by any code, just set in various clk
> > init structures and then never tested again. Remove it from these
> > drivers as it doesn't provide any benefit.
> >
> > Cc: Geert Uytterhoeven 
> > Cc: 
> > Signed-off-by: Stephen Boyd 
> 
> Thanks!
> 
> Reviewed-by: Geert Uytterhoeven 
> 
> I assume you want to apply this yourself, with the rest of the series?
> 

Yes I'll apply it to clk-next. Thanks.

Re: [PATCH 1/8] clk: renesas: Remove usage of CLK_IS_BASIC

2018-12-07 Thread Geert Uytterhoeven 
Hi Stephen,

On Thu, Dec 6, 2018 at 10:59 PM Stephen Boyd  wrote:
> This flag doesn't look to be used by any code, just set in various clk
> init structures and then never tested again. Remove it from these
> drivers as it doesn't provide any benefit.
>
> Cc: Geert Uytterhoeven 
> Cc: 
> Signed-off-by: Stephen Boyd 

Thanks!

Reviewed-by: Geert Uytterhoeven 

I assume you want to apply this yourself, with the rest of the series?

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH 1/8] clk: renesas: Remove usage of CLK_IS_BASIC

2018-12-06 Thread Stephen Boyd 
This flag doesn't look to be used by any code, just set in various clk
init structures and then never tested again. Remove it from these
drivers as it doesn't provide any benefit.

Cc: Geert Uytterhoeven 
Cc: 
Signed-off-by: Stephen Boyd 
---
 drivers/clk/renesas/clk-div6.c | 2 +-
 drivers/clk/renesas/clk-mstp.c | 2 +-
 drivers/clk/renesas/r9a06g032-clocks.c | 8 
 drivers/clk/renesas/rcar-gen3-cpg.c| 2 +-
 drivers/clk/renesas/renesas-cpg-mssr.c | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/clk/renesas/clk-div6.c b/drivers/clk/renesas/clk-div6.c
index 57c934164306..e98a9f5b3c90 100644
--- a/drivers/clk/renesas/clk-div6.c
+++ b/drivers/clk/renesas/clk-div6.c
@@ -274,7 +274,7 @@ struct clk * __init cpg_div6_register(const char *name,
/* Register the clock. */
init.name = name;
init.ops = &cpg_div6_clock_ops;
-   init.flags = CLK_IS_BASIC;
+   init.flags = 0;
init.parent_names = parent_names;
init.num_parents = valid_parents;
 
diff --git a/drivers/clk/renesas/clk-mstp.c b/drivers/clk/renesas/clk-mstp.c
index 1c1768c2cc82..2ba6105937e3 100644
--- a/drivers/clk/renesas/clk-mstp.c
+++ b/drivers/clk/renesas/clk-mstp.c
@@ -158,7 +158,7 @@ static struct clk * __init cpg_mstp_clock_register(const 
char *name,
 
init.name = name;
init.ops = &cpg_mstp_clock_ops;
-   init.flags = CLK_IS_BASIC | CLK_SET_RATE_PARENT;
+   init.flags = CLK_SET_RATE_PARENT;
/* INTC-SYS is the module clock of the GIC, and must not be disabled */
if (!strcmp(name, "intc-sys")) {
pr_debug("MSTP %s setting CLK_IS_CRITICAL\n", name);
diff --git a/drivers/clk/renesas/r9a06g032-clocks.c 
b/drivers/clk/renesas/r9a06g032-clocks.c
index 6d2b56891559..658cb11b6f55 100644
--- a/drivers/clk/renesas/r9a06g032-clocks.c
+++ b/drivers/clk/renesas/r9a06g032-clocks.c
@@ -424,7 +424,7 @@ r9a06g032_register_gate(struct r9a06g032_priv *clocks,
 
init.name = desc->name;
init.ops = &r9a06g032_clk_gate_ops;
-   init.flags = CLK_IS_BASIC | CLK_SET_RATE_PARENT;
+   init.flags = CLK_SET_RATE_PARENT;
init.parent_names = parent_name ? &parent_name : NULL;
init.num_parents = parent_name ? 1 : 0;
 
@@ -595,7 +595,7 @@ r9a06g032_register_div(struct r9a06g032_priv *clocks,
 
init.name = desc->name;
init.ops = &r9a06g032_clk_div_ops;
-   init.flags = CLK_IS_BASIC | CLK_SET_RATE_PARENT;
+   init.flags = CLK_SET_RATE_PARENT;
init.parent_names = parent_name ? &parent_name : NULL;
init.num_parents = parent_name ? 1 : 0;
 
@@ -683,7 +683,7 @@ r9a06g032_register_bitsel(struct r9a06g032_priv *clocks,
 
init.name = desc->name;
init.ops = &clk_bitselect_ops;
-   init.flags = CLK_IS_BASIC | CLK_SET_RATE_PARENT;
+   init.flags = CLK_SET_RATE_PARENT;
init.parent_names = names;
init.num_parents = 2;
 
@@ -777,7 +777,7 @@ r9a06g032_register_dualgate(struct r9a06g032_priv *clocks,
 
init.name = desc->name;
init.ops = &r9a06g032_clk_dualgate_ops;
-   init.flags = CLK_IS_BASIC | CLK_SET_RATE_PARENT;
+   init.flags = CLK_SET_RATE_PARENT;
init.parent_names = &parent_name;
init.num_parents = 1;
g->hw.init = &init;
diff --git a/drivers/clk/renesas/rcar-gen3-cpg.c 
b/drivers/clk/renesas/rcar-gen3-cpg.c
index 4ba38f98cc7b..48e003c69cd1 100644
--- a/drivers/clk/renesas/rcar-gen3-cpg.c
+++ b/drivers/clk/renesas/rcar-gen3-cpg.c
@@ -368,7 +368,7 @@ static struct clk * __init cpg_sd_clk_register(const struct 
cpg_core_clk *core,
 
init.name = core->name;
init.ops = &cpg_sd_clock_ops;
-   init.flags = CLK_IS_BASIC | CLK_SET_RATE_PARENT;
+   init.flags = CLK_SET_RATE_PARENT;
init.parent_names = &parent_name;
init.num_parents = 1;
 
diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c 
b/drivers/clk/renesas/renesas-cpg-mssr.c
index f7bb817420b4..30df0dc853f0 100644
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -412,7 +412,7 @@ static void __init cpg_mssr_register_mod_clk(const struct 
mssr_mod_clk *mod,
 
init.name = mod->name;
init.ops = &cpg_mstp_clock_ops;
-   init.flags = CLK_IS_BASIC | CLK_SET_RATE_PARENT;
+   init.flags = CLK_SET_RATE_PARENT;
for (i = 0; i < info->num_crit_mod_clks; i++)
if (id == info->crit_mod_clks[i]) {
dev_dbg(dev, "MSTP %s setting CLK_IS_CRITICAL\n",
-- 
Sent by a computer through tubes