On May 19, 2014, at 4:25 PM, Andi Kleen wrote:
> On Mon, May 19, 2014 at 10:00:52PM +, Rustad, Mark D wrote:
>> On May 16, 2014, at 2:43 PM, Andi Kleen wrote:
>>
>>> From: Andi Kleen
>>>
>>> ixgbe_read_reg and ixgbe_write_reg are frequently called and are very big
>>> because they have
On May 19, 2014, at 4:25 PM, Andi Kleen a...@linux.intel.com wrote:
On Mon, May 19, 2014 at 10:00:52PM +, Rustad, Mark D wrote:
On May 16, 2014, at 2:43 PM, Andi Kleen a...@firstfloor.org wrote:
From: Andi Kleen a...@linux.intel.com
ixgbe_read_reg and ixgbe_write_reg are frequently
On Mon, May 19, 2014 at 10:00:52PM +, Rustad, Mark D wrote:
> On May 16, 2014, at 2:43 PM, Andi Kleen wrote:
>
> > From: Andi Kleen
> >
> > ixgbe_read_reg and ixgbe_write_reg are frequently called and are very big
> > because they have complex error handling code.
>
> Actually, this patch
On May 16, 2014, at 2:43 PM, Andi Kleen wrote:
> From: Andi Kleen
>
> ixgbe_read_reg and ixgbe_write_reg are frequently called and are very big
> because they have complex error handling code.
Actually, this patch doesn't do anything to ixgbe_write_reg, which would almost
certainly be very
From: Andi Kleen
> ixgbe_read_reg and ixgbe_write_reg are frequently called and are very big
> because they have complex error handling code.
Have you measured the performance impact?
I suspect that it might me measurable.
Clearly the calls during initialisation don't need to be inline,
but
On May 16, 2014, at 2:43 PM, Andi Kleen a...@firstfloor.org wrote:
From: Andi Kleen a...@linux.intel.com
ixgbe_read_reg and ixgbe_write_reg are frequently called and are very big
because they have complex error handling code.
Actually, this patch doesn't do anything to ixgbe_write_reg,
On Mon, May 19, 2014 at 10:00:52PM +, Rustad, Mark D wrote:
On May 16, 2014, at 2:43 PM, Andi Kleen a...@firstfloor.org wrote:
From: Andi Kleen a...@linux.intel.com
ixgbe_read_reg and ixgbe_write_reg are frequently called and are very big
because they have complex error handling
From: Andi Kleen
ixgbe_read_reg and ixgbe_write_reg are frequently called and are very big
because they have complex error handling code.
Have you measured the performance impact?
I suspect that it might me measurable.
Clearly the calls during initialisation don't need to be inline,
but there
From: Andi Kleen
ixgbe_read_reg and ixgbe_write_reg are frequently called and are very big
because they have complex error handling code.
Moving them out of line saves ~27k text in the ixgbe driver.
textdata bss dec hex filename
142208732008072 1507328 17736273
From: Andi Kleen a...@linux.intel.com
ixgbe_read_reg and ixgbe_write_reg are frequently called and are very big
because they have complex error handling code.
Moving them out of line saves ~27k text in the ixgbe driver.
textdata bss dec hex filename
142208732008072
10 matches
Mail list logo