Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-09 Thread Russell King - ARM Linux
On Fri, Oct 09, 2015 at 01:02:11PM -0300, Fabio Estevam wrote: > On Fri, Oct 9, 2015 at 1:00 PM, Russell King - ARM Linux > wrote: > > >> Thanks, Russell! > >> > >> Got audio to play on my HDMI TV :-) > >> > >> For the entire series: > >> > >> Tested-by: Fabio Estevam > > > > Just to confirm -

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-09 Thread Fabio Estevam
On Fri, Oct 9, 2015 at 1:00 PM, Russell King - ARM Linux wrote: >> Thanks, Russell! >> >> Got audio to play on my HDMI TV :-) >> >> For the entire series: >> >> Tested-by: Fabio Estevam > > Just to confirm - that's for _all_ of these 8 patches, including the > changes to the ACR code in the

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-09 Thread Russell King - ARM Linux
On Tue, Oct 06, 2015 at 05:25:16PM -0300, Fabio Estevam wrote: > On Tue, Oct 6, 2015 at 3:54 PM, Russell King - ARM Linux > wrote: > > > Make sure you have the ALSA config file, as alsalib won't get on > > with dw-hdmi only accepting 24-bit audio without this. A copy is > > attached. It also

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-09 Thread Russell King - ARM Linux
On Tue, Oct 06, 2015 at 05:25:16PM -0300, Fabio Estevam wrote: > On Tue, Oct 6, 2015 at 3:54 PM, Russell King - ARM Linux > wrote: > > > Make sure you have the ALSA config file, as alsalib won't get on > > with dw-hdmi only accepting 24-bit audio without this. A copy is

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-09 Thread Fabio Estevam
On Fri, Oct 9, 2015 at 1:00 PM, Russell King - ARM Linux wrote: >> Thanks, Russell! >> >> Got audio to play on my HDMI TV :-) >> >> For the entire series: >> >> Tested-by: Fabio Estevam > > Just to confirm - that's for _all_ of these 8

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-09 Thread Russell King - ARM Linux
On Fri, Oct 09, 2015 at 01:02:11PM -0300, Fabio Estevam wrote: > On Fri, Oct 9, 2015 at 1:00 PM, Russell King - ARM Linux > wrote: > > >> Thanks, Russell! > >> > >> Got audio to play on my HDMI TV :-) > >> > >> For the entire series: > >> > >> Tested-by: Fabio Estevam

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-06 Thread Fabio Estevam
On Tue, Oct 6, 2015 at 3:54 PM, Russell King - ARM Linux wrote: > Make sure you have the ALSA config file, as alsalib won't get on > with dw-hdmi only accepting 24-bit audio without this. A copy is > attached. It also tells ALSA how to deal with multi-channel audio > as well. Thanks, Russell!

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-06 Thread Russell King - ARM Linux
On Tue, Oct 06, 2015 at 03:45:32PM -0300, Fabio Estevam wrote: > On Tue, Oct 6, 2015 at 3:18 PM, Russell King - ARM Linux > wrote: > > > Sorry, I've been out for most of the day. There's no DT patches required. > > > > The dw_hdmi bridge driver creates its own platform device for the audio, > >

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-06 Thread Fabio Estevam
On Tue, Oct 6, 2015 at 3:18 PM, Russell King - ARM Linux wrote: > Sorry, I've been out for most of the day. There's no DT patches required. > > The dw_hdmi bridge driver creates its own platform device for the audio, > which should then bind to the dw_hdmi-ahb-audio driver using normal Linux >

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-06 Thread Russell King - ARM Linux
On Tue, Oct 06, 2015 at 03:07:40PM -0300, Fabio Estevam wrote: > On Sat, Aug 8, 2015 at 1:10 PM, Russell King > wrote: > > Add ALSA based HDMI AHB audio driver for dw_hdmi. The only buffer > > format supported by the hardware is its own special IEC958 based format, > > which is not compatible

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-06 Thread Fabio Estevam
On Sat, Aug 8, 2015 at 1:10 PM, Russell King wrote: > Add ALSA based HDMI AHB audio driver for dw_hdmi. The only buffer > format supported by the hardware is its own special IEC958 based format, > which is not compatible with any ALSA format. To avoid doing too much > data manipulation within

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-06 Thread Fabio Estevam
On Sat, Aug 8, 2015 at 1:10 PM, Russell King wrote: > Add ALSA based HDMI AHB audio driver for dw_hdmi. The only buffer > format supported by the hardware is its own special IEC958 based format, > which is not compatible with any ALSA format. To avoid doing too much

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-06 Thread Russell King - ARM Linux
On Tue, Oct 06, 2015 at 03:07:40PM -0300, Fabio Estevam wrote: > On Sat, Aug 8, 2015 at 1:10 PM, Russell King > wrote: > > Add ALSA based HDMI AHB audio driver for dw_hdmi. The only buffer > > format supported by the hardware is its own special IEC958 based format, >

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-06 Thread Fabio Estevam
On Tue, Oct 6, 2015 at 3:18 PM, Russell King - ARM Linux wrote: > Sorry, I've been out for most of the day. There's no DT patches required. > > The dw_hdmi bridge driver creates its own platform device for the audio, > which should then bind to the dw_hdmi-ahb-audio

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-06 Thread Russell King - ARM Linux
On Tue, Oct 06, 2015 at 03:45:32PM -0300, Fabio Estevam wrote: > On Tue, Oct 6, 2015 at 3:18 PM, Russell King - ARM Linux > wrote: > > > Sorry, I've been out for most of the day. There's no DT patches required. > > > > The dw_hdmi bridge driver creates its own platform

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-10-06 Thread Fabio Estevam
On Tue, Oct 6, 2015 at 3:54 PM, Russell King - ARM Linux wrote: > Make sure you have the ALSA config file, as alsalib won't get on > with dw-hdmi only accepting 24-bit audio without this. A copy is > attached. It also tells ALSA how to deal with multi-channel audio > as

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-08-10 Thread Mark Brown
On Mon, Aug 10, 2015 at 05:49:41PM +0100, Russell King - ARM Linux wrote: > I'm not sure what the right solution is here: modifying every audio > player out there to make HDMI work sanely is crazy. Having alsalib > automatically generate the correct AES channel status bytes for > linear audio

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-08-10 Thread Russell King - ARM Linux
On Mon, Aug 10, 2015 at 02:23:07PM +0200, Takashi Iwai wrote: > I admit that alsa-lib code is very horrible to follow -- but I guess > the change you'd need for iec958 plugin would be fairly small. We can > add a config option and let iec958 behaving slightly differently > depending on it. Yes,

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-08-10 Thread Takashi Iwai
On Mon, 10 Aug 2015 12:39:21 +0200, Russell King - ARM Linux wrote: > > On Mon, Aug 10, 2015 at 12:05:07PM +0200, Takashi Iwai wrote: > > On Sat, 08 Aug 2015 18:10:06 +0200, > > Russell King wrote: > > > +static irqreturn_t snd_dw_hdmi_irq(int irq, void *data) > > > +{ > > > + struct snd_dw_hdmi

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-08-10 Thread Russell King - ARM Linux
On Mon, Aug 10, 2015 at 12:05:07PM +0200, Takashi Iwai wrote: > On Sat, 08 Aug 2015 18:10:06 +0200, > Russell King wrote: > > +static irqreturn_t snd_dw_hdmi_irq(int irq, void *data) > > +{ > > + struct snd_dw_hdmi *dw = data; > > + struct snd_pcm_substream *substream; > > + unsigned stat; >

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-08-10 Thread Takashi Iwai
On Sat, 08 Aug 2015 18:10:06 +0200, Russell King wrote: > > Add ALSA based HDMI AHB audio driver for dw_hdmi. The only buffer > format supported by the hardware is its own special IEC958 based format, > which is not compatible with any ALSA format. To avoid doing too much > data manipulation

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-08-10 Thread Russell King - ARM Linux
On Mon, Aug 10, 2015 at 02:23:07PM +0200, Takashi Iwai wrote: I admit that alsa-lib code is very horrible to follow -- but I guess the change you'd need for iec958 plugin would be fairly small. We can add a config option and let iec958 behaving slightly differently depending on it. Yes, but

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-08-10 Thread Mark Brown
On Mon, Aug 10, 2015 at 05:49:41PM +0100, Russell King - ARM Linux wrote: I'm not sure what the right solution is here: modifying every audio player out there to make HDMI work sanely is crazy. Having alsalib automatically generate the correct AES channel status bytes for linear audio

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-08-10 Thread Takashi Iwai
On Sat, 08 Aug 2015 18:10:06 +0200, Russell King wrote: Add ALSA based HDMI AHB audio driver for dw_hdmi. The only buffer format supported by the hardware is its own special IEC958 based format, which is not compatible with any ALSA format. To avoid doing too much data manipulation within

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-08-10 Thread Russell King - ARM Linux
On Mon, Aug 10, 2015 at 12:05:07PM +0200, Takashi Iwai wrote: On Sat, 08 Aug 2015 18:10:06 +0200, Russell King wrote: +static irqreturn_t snd_dw_hdmi_irq(int irq, void *data) +{ + struct snd_dw_hdmi *dw = data; + struct snd_pcm_substream *substream; + unsigned stat; + +

Re: [PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-08-10 Thread Takashi Iwai
On Mon, 10 Aug 2015 12:39:21 +0200, Russell King - ARM Linux wrote: On Mon, Aug 10, 2015 at 12:05:07PM +0200, Takashi Iwai wrote: On Sat, 08 Aug 2015 18:10:06 +0200, Russell King wrote: +static irqreturn_t snd_dw_hdmi_irq(int irq, void *data) +{ + struct snd_dw_hdmi *dw = data;

[PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-08-08 Thread Russell King
Add ALSA based HDMI AHB audio driver for dw_hdmi. The only buffer format supported by the hardware is its own special IEC958 based format, which is not compatible with any ALSA format. To avoid doing too much data manipulation within the driver, we support only ALSAs IEC958 LE and 24-bit PCM

[PATCH 1/9] drm: bridge/dw_hdmi-ahb-audio: add audio driver

2015-08-08 Thread Russell King
Add ALSA based HDMI AHB audio driver for dw_hdmi. The only buffer format supported by the hardware is its own special IEC958 based format, which is not compatible with any ALSA format. To avoid doing too much data manipulation within the driver, we support only ALSAs IEC958 LE and 24-bit PCM