Re: [PATCH 1/9] mm, hugetlb: move up the code which check availability of free huge page

2013-07-22 Thread Michal Hocko
On Mon 15-07-13 18:52:39, Joonsoo Kim wrote: > We don't need to proceede the processing if we don't have any usable > free huge page. So move this code up. > > Signed-off-by: Joonsoo Kim Acked-by: Michal Hocko after you add a note about hugetlb_lock which stabilizes hstate so the retry

Re: [PATCH 1/9] mm, hugetlb: move up the code which check availability of free huge page

2013-07-22 Thread Michal Hocko
On Mon 15-07-13 18:52:39, Joonsoo Kim wrote: We don't need to proceede the processing if we don't have any usable free huge page. So move this code up. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Acked-by: Michal Hocko mho...@suse.cz after you add a note about hugetlb_lock which

Re: [PATCH 1/9] mm, hugetlb: move up the code which check availability of free huge page

2013-07-15 Thread Joonsoo Kim
On Tue, Jul 16, 2013 at 09:06:04AM +0530, Aneesh Kumar K.V wrote: > Joonsoo Kim writes: > > > On Mon, Jul 15, 2013 at 07:31:33PM +0530, Aneesh Kumar K.V wrote: > >> Joonsoo Kim writes: > >> > >> > We don't need to proceede the processing if we don't have any usable > >> > free huge page. So

Re: [PATCH 1/9] mm, hugetlb: move up the code which check availability of free huge page

2013-07-15 Thread Aneesh Kumar K.V
Joonsoo Kim writes: > On Mon, Jul 15, 2013 at 07:31:33PM +0530, Aneesh Kumar K.V wrote: >> Joonsoo Kim writes: >> >> > We don't need to proceede the processing if we don't have any usable >> > free huge page. So move this code up. >> >> I guess you can also mention that since we are holding

Re: [PATCH 1/9] mm, hugetlb: move up the code which check availability of free huge page

2013-07-15 Thread Joonsoo Kim
On Mon, Jul 15, 2013 at 07:31:33PM +0530, Aneesh Kumar K.V wrote: > Joonsoo Kim writes: > > > We don't need to proceede the processing if we don't have any usable > > free huge page. So move this code up. > > I guess you can also mention that since we are holding hugetlb_lock > hstate values

Re: [PATCH 1/9] mm, hugetlb: move up the code which check availability of free huge page

2013-07-15 Thread Aneesh Kumar K.V
Joonsoo Kim writes: > We don't need to proceede the processing if we don't have any usable > free huge page. So move this code up. I guess you can also mention that since we are holding hugetlb_lock hstate values can't change. Also. > > Signed-off-by: Joonsoo Kim > > diff --git

[PATCH 1/9] mm, hugetlb: move up the code which check availability of free huge page

2013-07-15 Thread Joonsoo Kim
We don't need to proceede the processing if we don't have any usable free huge page. So move this code up. Signed-off-by: Joonsoo Kim diff --git a/mm/hugetlb.c b/mm/hugetlb.c index e2bfbf7..d87f70b 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -539,10 +539,6 @@ static struct page

[PATCH 1/9] mm, hugetlb: move up the code which check availability of free huge page

2013-07-15 Thread Joonsoo Kim
We don't need to proceede the processing if we don't have any usable free huge page. So move this code up. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com diff --git a/mm/hugetlb.c b/mm/hugetlb.c index e2bfbf7..d87f70b 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -539,10 +539,6 @@ static

Re: [PATCH 1/9] mm, hugetlb: move up the code which check availability of free huge page

2013-07-15 Thread Aneesh Kumar K.V
Joonsoo Kim iamjoonsoo@lge.com writes: We don't need to proceede the processing if we don't have any usable free huge page. So move this code up. I guess you can also mention that since we are holding hugetlb_lock hstate values can't change. Also. Signed-off-by: Joonsoo Kim

Re: [PATCH 1/9] mm, hugetlb: move up the code which check availability of free huge page

2013-07-15 Thread Joonsoo Kim
On Mon, Jul 15, 2013 at 07:31:33PM +0530, Aneesh Kumar K.V wrote: Joonsoo Kim iamjoonsoo@lge.com writes: We don't need to proceede the processing if we don't have any usable free huge page. So move this code up. I guess you can also mention that since we are holding hugetlb_lock

Re: [PATCH 1/9] mm, hugetlb: move up the code which check availability of free huge page

2013-07-15 Thread Aneesh Kumar K.V
Joonsoo Kim iamjoonsoo@lge.com writes: On Mon, Jul 15, 2013 at 07:31:33PM +0530, Aneesh Kumar K.V wrote: Joonsoo Kim iamjoonsoo@lge.com writes: We don't need to proceede the processing if we don't have any usable free huge page. So move this code up. I guess you can also

Re: [PATCH 1/9] mm, hugetlb: move up the code which check availability of free huge page

2013-07-15 Thread Joonsoo Kim
On Tue, Jul 16, 2013 at 09:06:04AM +0530, Aneesh Kumar K.V wrote: Joonsoo Kim iamjoonsoo@lge.com writes: On Mon, Jul 15, 2013 at 07:31:33PM +0530, Aneesh Kumar K.V wrote: Joonsoo Kim iamjoonsoo@lge.com writes: We don't need to proceede the processing if we don't have any