Re: [PATCH 1/9] platform/surface: Add Surface Aggregator subsystem

2020-11-19 Thread Maximilian Luz
On 11/19/20 4:54 PM, Barnabás Pőcze wrote: Hi [...] +enum ssam_ssh_tc { + /* Known SSH/EC target categories. */ + // category 0x00 is invalid for EC use + SSAM_SSH_TC_SAM = 0x01, // generic system functionality, real-time clock +

Re: [PATCH 1/9] platform/surface: Add Surface Aggregator subsystem

2020-11-19 Thread Barnabás Pőcze
Hi 2020. november 19., csütörtök 0:06 keltezéssel, Maximilian Luz írta: > [...] > >> +/** > >> + * ssam_nf_head_destroy() - Deinitialize the given notifier head. > >> + * @nh: The notifier head to deinitialize. > >> + */ > >> +static void ssam_nf_head_destroy(struct ssam_nf_head *nh) > >> +{

Re: [PATCH 1/9] platform/surface: Add Surface Aggregator subsystem

2020-11-18 Thread Maximilian Luz
On 11/18/20 1:28 AM, Barnabás Pőcze wrote: Hi I have attached some thoughts and comments inline. Thanks! 2020. november 15., vasárnap 20:21 keltezéssel, Maximilian Luz írta: [...] +/* -- Event notifier/callbacks. - */ +/* + * The notifier

Re: [PATCH 1/9] platform/surface: Add Surface Aggregator subsystem

2020-11-17 Thread Barnabás Pőcze
Hi I have attached some thoughts and comments inline. 2020. november 15., vasárnap 20:21 keltezéssel, Maximilian Luz írta: > [...] > +/* -- Event notifier/callbacks. > - */ > +/* > + * The notifier system is based on linux/notifier.h, specifically

Re: [PATCH 1/9] platform/surface: Add Surface Aggregator subsystem

2020-11-16 Thread Maximilian Luz
On 11/16/20 6:03 PM, Maximilian Luz wrote: On 11/16/20 2:33 PM, Andy Shevchenko wrote: On Sun, Nov 15, 2020 at 9:25 PM Maximilian Luz wrote: [...] READ_ONCE and WRITE_ONCE are used to ensure proper access to state that can be changed outside of the queue/pending locks (or under any one of

Re: [PATCH 1/9] platform/surface: Add Surface Aggregator subsystem

2020-11-16 Thread Maximilian Luz
On 11/16/20 2:33 PM, Andy Shevchenko wrote: On Sun, Nov 15, 2020 at 9:25 PM Maximilian Luz wrote: Add Surface System Aggregator Module core and Surface Serial Hub driver, required for the embedded controller found on Microsoft Surface devices. The Surface System Aggregator Module (SSAM, SAM

Re: [PATCH 1/9] platform/surface: Add Surface Aggregator subsystem

2020-11-16 Thread Andy Shevchenko
On Sun, Nov 15, 2020 at 9:25 PM Maximilian Luz wrote: > > Add Surface System Aggregator Module core and Surface Serial Hub driver, > required for the embedded controller found on Microsoft Surface devices. > > The Surface System Aggregator Module (SSAM, SAM or Surface Aggregator) > is an embedded