Re: [PATCH 10/10] staging: ozwpan: Separate success & failure case for oz_hcd_pd_arrived()

2013-08-13 Thread Dan Carpenter
On Tue, Aug 13, 2013 at 06:29:26PM +0100, Rupesh Gujare wrote: > From: Dan Carpenter > > This patch separates success & failure block along with fixing > following issues:- > > 1. The way oz_hcd_pd_arrived() looks now it's easy to think we free "ep" but > actually we do this spaghetti thing of

[PATCH 10/10] staging: ozwpan: Separate success & failure case for oz_hcd_pd_arrived()

2013-08-13 Thread Rupesh Gujare
From: Dan Carpenter This patch separates success & failure block along with fixing following issues:- 1. The way oz_hcd_pd_arrived() looks now it's easy to think we free "ep" but actually we do this spaghetti thing of setting it to NULL on success. 2. It is hard to read it because there are

[PATCH 10/10] staging: ozwpan: Separate success failure case for oz_hcd_pd_arrived()

2013-08-13 Thread Rupesh Gujare
From: Dan Carpenter dan.carpen...@oracle.com This patch separates success failure block along with fixing following issues:- 1. The way oz_hcd_pd_arrived() looks now it's easy to think we free ep but actually we do this spaghetti thing of setting it to NULL on success. 2. It is hard to read it

Re: [PATCH 10/10] staging: ozwpan: Separate success failure case for oz_hcd_pd_arrived()

2013-08-13 Thread Dan Carpenter
On Tue, Aug 13, 2013 at 06:29:26PM +0100, Rupesh Gujare wrote: From: Dan Carpenter dan.carpen...@oracle.com This patch separates success failure block along with fixing following issues:- 1. The way oz_hcd_pd_arrived() looks now it's easy to think we free ep but actually we do this