Re: [PATCH 10/11] iommu/exynos: Make use of iommu_device_register interface

[Joerg Roedel]

On Fri, Feb 10, 2017 at 02:46:59PM +0100, Marek Szyprowski wrote:
> Hi
> 
> On 2017-02-09 12:32, Joerg Roedel wrote:
> >From: Joerg Roedel 
> >
> >Register Exynos IOMMUs to the IOMMU core and make them
> >visible in sysfs. This patch does not add the links between
> >IOMMUs and translated devices yet.
> >
> >Cc: Marek Szyprowski 
> >Cc: linux-arm-ker...@lists.infradead.org
> >Cc: linux-samsung-...@vger.kernel.org
> >Signed-off-by: Joerg Roedel 
> 
> Acked-by: Marek Szyprowski 
> Tested-by: Marek Szyprowski 

Thanks a lot for testing!

Re: [PATCH 10/11] iommu/exynos: Make use of iommu_device_register interface

[Joerg Roedel]

On Fri, Feb 10, 2017 at 02:46:59PM +0100, Marek Szyprowski wrote:
> Hi
> 
> On 2017-02-09 12:32, Joerg Roedel wrote:
> >From: Joerg Roedel 
> >
> >Register Exynos IOMMUs to the IOMMU core and make them
> >visible in sysfs. This patch does not add the links between
> >IOMMUs and translated devices yet.
> >
> >Cc: Marek Szyprowski 
> >Cc: linux-arm-ker...@lists.infradead.org
> >Cc: linux-samsung-...@vger.kernel.org
> >Signed-off-by: Joerg Roedel 
> 
> Acked-by: Marek Szyprowski 
> Tested-by: Marek Szyprowski 

Thanks a lot for testing!

Re: [PATCH 10/11] iommu/exynos: Make use of iommu_device_register interface

[Marek Szyprowski]

Hi

On 2017-02-09 12:32, Joerg Roedel wrote:

From: Joerg Roedel 

Register Exynos IOMMUs to the IOMMU core and make them
visible in sysfs. This patch does not add the links between
IOMMUs and translated devices yet.

Cc: Marek Szyprowski 
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-...@vger.kernel.org
Signed-off-by: Joerg Roedel 


Acked-by: Marek Szyprowski 
Tested-by: Marek Szyprowski 


---
  drivers/iommu/exynos-iommu.c | 14 ++
  1 file changed, 14 insertions(+)

diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index 57ba0d3..64325d8 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -276,6 +276,8 @@ struct sysmmu_drvdata {
struct list_head owner_node;/* node for owner controllers list */
phys_addr_t pgtable;/* assigned page table structure */
unsigned int version;   /* our version */
+
+   struct iommu_device iommu;  /* IOMMU core handle */
  };
  
  static struct exynos_iommu_domain *to_exynos_domain(struct iommu_domain *dom)

@@ -611,6 +613,18 @@ static int __init exynos_sysmmu_probe(struct 
platform_device *pdev)
data->sysmmu = dev;
spin_lock_init(>lock);
  
+	ret = iommu_device_sysfs_add(>iommu, >dev, NULL,

+dev_name(data->sysmmu));
+   if (ret)
+   return ret;
+
+   iommu_device_set_ops(>iommu, _iommu_ops);
+   iommu_device_set_fwnode(>iommu, >of_node->fwnode);
+
+   ret = iommu_device_register(>iommu);
+   if (ret)
+   return ret;
+
platform_set_drvdata(pdev, data);
  
  	__sysmmu_get_version(data);


Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland

Re: [PATCH 10/11] iommu/exynos: Make use of iommu_device_register interface

[Marek Szyprowski]

Hi

On 2017-02-09 12:32, Joerg Roedel wrote:

From: Joerg Roedel 

Register Exynos IOMMUs to the IOMMU core and make them
visible in sysfs. This patch does not add the links between
IOMMUs and translated devices yet.

Cc: Marek Szyprowski 
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-...@vger.kernel.org
Signed-off-by: Joerg Roedel 


Acked-by: Marek Szyprowski 
Tested-by: Marek Szyprowski 


---
  drivers/iommu/exynos-iommu.c | 14 ++
  1 file changed, 14 insertions(+)

diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index 57ba0d3..64325d8 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -276,6 +276,8 @@ struct sysmmu_drvdata {
struct list_head owner_node;/* node for owner controllers list */
phys_addr_t pgtable;/* assigned page table structure */
unsigned int version;   /* our version */
+
+   struct iommu_device iommu;  /* IOMMU core handle */
  };
  
  static struct exynos_iommu_domain *to_exynos_domain(struct iommu_domain *dom)

@@ -611,6 +613,18 @@ static int __init exynos_sysmmu_probe(struct 
platform_device *pdev)
data->sysmmu = dev;
spin_lock_init(>lock);
  
+	ret = iommu_device_sysfs_add(>iommu, >dev, NULL,

+dev_name(data->sysmmu));
+   if (ret)
+   return ret;
+
+   iommu_device_set_ops(>iommu, _iommu_ops);
+   iommu_device_set_fwnode(>iommu, >of_node->fwnode);
+
+   ret = iommu_device_register(>iommu);
+   if (ret)
+   return ret;
+
platform_set_drvdata(pdev, data);
  
  	__sysmmu_get_version(data);


Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland

[PATCH 10/11] iommu/exynos: Make use of iommu_device_register interface

[Joerg Roedel]

From: Joerg Roedel 

Register Exynos IOMMUs to the IOMMU core and make them
visible in sysfs. This patch does not add the links between
IOMMUs and translated devices yet.

Cc: Marek Szyprowski 
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-...@vger.kernel.org
Signed-off-by: Joerg Roedel 
---
 drivers/iommu/exynos-iommu.c | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index 57ba0d3..64325d8 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -276,6 +276,8 @@ struct sysmmu_drvdata {
struct list_head owner_node;/* node for owner controllers list */
phys_addr_t pgtable;/* assigned page table structure */
unsigned int version;   /* our version */
+
+   struct iommu_device iommu;  /* IOMMU core handle */
 };
 
 static struct exynos_iommu_domain *to_exynos_domain(struct iommu_domain *dom)
@@ -611,6 +613,18 @@ static int __init exynos_sysmmu_probe(struct 
platform_device *pdev)
data->sysmmu = dev;
spin_lock_init(>lock);
 
+   ret = iommu_device_sysfs_add(>iommu, >dev, NULL,
+dev_name(data->sysmmu));
+   if (ret)
+   return ret;
+
+   iommu_device_set_ops(>iommu, _iommu_ops);
+   iommu_device_set_fwnode(>iommu, >of_node->fwnode);
+
+   ret = iommu_device_register(>iommu);
+   if (ret)
+   return ret;
+
platform_set_drvdata(pdev, data);
 
__sysmmu_get_version(data);
-- 
1.9.1

[PATCH 10/11] iommu/exynos: Make use of iommu_device_register interface

[Joerg Roedel]

From: Joerg Roedel 

Register Exynos IOMMUs to the IOMMU core and make them
visible in sysfs. This patch does not add the links between
IOMMUs and translated devices yet.

Cc: Marek Szyprowski 
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-...@vger.kernel.org
Signed-off-by: Joerg Roedel 
---
 drivers/iommu/exynos-iommu.c | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index 57ba0d3..64325d8 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -276,6 +276,8 @@ struct sysmmu_drvdata {
struct list_head owner_node;/* node for owner controllers list */
phys_addr_t pgtable;/* assigned page table structure */
unsigned int version;   /* our version */
+
+   struct iommu_device iommu;  /* IOMMU core handle */
 };
 
 static struct exynos_iommu_domain *to_exynos_domain(struct iommu_domain *dom)
@@ -611,6 +613,18 @@ static int __init exynos_sysmmu_probe(struct 
platform_device *pdev)
data->sysmmu = dev;
spin_lock_init(>lock);
 
+   ret = iommu_device_sysfs_add(>iommu, >dev, NULL,
+dev_name(data->sysmmu));
+   if (ret)
+   return ret;
+
+   iommu_device_set_ops(>iommu, _iommu_ops);
+   iommu_device_set_fwnode(>iommu, >of_node->fwnode);
+
+   ret = iommu_device_register(>iommu);
+   if (ret)
+   return ret;
+
platform_set_drvdata(pdev, data);
 
__sysmmu_get_version(data);
-- 
1.9.1